CIRCL
/
AIL-framework
mirror of https://github.com/CIRCL/AIL-framework
2
1
Fork 0
Code Issues Releases Wiki Activity

Fix IndexError in get_last_tag_from_remote function 

This commit adds a check to ensure that the output from the subprocess command in the get_last_tag_from_remote function has a sufficient number of lines before attempting to access specific indices. This change prevents the IndexError that occurred when the git command's output was shorter than expected.
pull/604/head
Markus Lassfolk 2024-01-01 21:54:29 +01:00 committed by GitHub
parent 38157f8a01
commit 81f9a860d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
bin/packages/git_status.py
View File

@ -129,17 +129,25 @@ def get_last_tag_from_local(verbose=False):
print('{}{}{}'.format(TERMINAL_RED, process.stderr.decode(), TERMINAL_DEFAULT)) print('{}{}{}'.format(TERMINAL_RED, process.stderr.decode(), TERMINAL_DEFAULT))
return '' return ''
# Get last local tag # Get last remote tag
def get_last_tag_from_remote(verbose=False): def get_last_tag_from_remote(verbose=False):
if verbose: if verbose:
print('retrieving last remote tag ...') print('retrieving last remote tag ...')
#print('git ls-remote --tags') #print('git ls-remote --tags')
process = subprocess.run(['git', 'ls-remote', '--tags'], stdout=subprocess.PIPE, stderr=subprocess.PIPE) process = subprocess.run(['git', 'ls-remote', '--tags'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
if process.returncode == 0: if process.returncode == 0:
res = process.stdout.split(b'\n')[-2].split(b'/')[-1].replace(b'^{}', b'').decode() output_lines = process.stdout.split(b'\n')
if verbose: if len(output_lines) > 1:
print(res) # Assuming we want the second-to-last line as before
return res res = output_lines[-2].split(b'/')[-1].replace(b'^{}', b'').decode()
if verbose:
print(res)
return res
else:
if verbose:
print("No tags found or insufficient output from git command.")
return ''
else: else:
if verbose: if verbose: