Mock out GroomerLogger in test_filecheck

pull/16/head
Dan Puttick 2017-07-13 17:00:41 -04:00
parent d3576db35d
commit 14b9d71da8
1 changed files with 5 additions and 5 deletions

View File

@ -90,7 +90,7 @@ def get_filename(sample_file):
return os.path.basename(sample_file.path) return os.path.basename(sample_file.path)
@fixture(scope='session') @fixture(scope='module')
def dest_dir_path(tmpdir_factory): def dest_dir_path(tmpdir_factory):
return tmpdir_factory.mktemp('dest').strpath return tmpdir_factory.mktemp('dest').strpath
@ -102,18 +102,18 @@ def groomer(dest_dir_path):
@fixture @fixture
def logger(dest_dir_path): def mock_logger(dest_dir_path):
return mock.Mock(GroomerLogger) return mock.MagicMock(spec=GroomerLogger)
@parametrize( @parametrize(
argnames="sample_file", argnames="sample_file",
argvalues=gather_sample_files(), argvalues=gather_sample_files(),
ids=get_filename) ids=get_filename)
def test_sample_files(sample_file, groomer, logger, dest_dir_path): def test_sample_files(mock_logger, sample_file, groomer, dest_dir_path):
if sample_file.xfail: if sample_file.xfail:
pytest.xfail(reason='Marked xfail in file catalog') pytest.xfail(reason='Marked xfail in file catalog')
file_dest_path = os.path.join(dest_dir_path, sample_file.filename) file_dest_path = os.path.join(dest_dir_path, sample_file.filename)
file = File(sample_file.path, file_dest_path, logger) file = File(sample_file.path, file_dest_path, mock_logger)
groomer.process_file(file) groomer.process_file(file)
assert file.is_dangerous == sample_file.exp_dangerous assert file.is_dangerous == sample_file.exp_dangerous