Prevent following arbitrarily nested symlinks

bin/filecheck.py

@@ -737,7 +737,9 @@ class KittenGroomerFileCheck(KittenGroomerBase):
             if os.path.isdir(full_path):
                 queue.append(full_path)
                 queue += self.list_files_dirs(full_path)
-            elif os.path.isfile(full_path):
+            elif os.path.isfile(full_path, follow_symlinks=False):
+                queue.append(full_path)
+            elif os.path.islink(full_path):
                 queue.append(full_path)
         return queue
 

tests/test_filecheck.py

@@ -90,6 +90,10 @@ def get_filename(sample_file):
     return os.path.basename(sample_file.path)
 
 
+@fixture(scope='module')
+def src_dir_path(tmpdir_factory):
+    return tmpdir_factory.mktemp('src').strpath
+
 @fixture(scope='module')
 def dest_dir_path(tmpdir_factory):
     return tmpdir_factory.mktemp('dest').strpath