fix: [sync] Fixed some issues throwing notices when pulling

pull/3658/head
iglocska 2018-09-09 15:55:42 +02:00
parent 55fe130385
commit 0123f23739
2 changed files with 3 additions and 3 deletions

View File

@ -624,7 +624,6 @@ class ServersController extends AppController
$this->set('successes', $result[0]);
$this->set('fails', $result[1]);
$this->set('pulledProposals', $result[2]);
$this->set('lastpulledid', $result[3]);
} else {
$this->loadModel('Job');
$this->Job->create();

View File

@ -1900,12 +1900,12 @@ class Server extends AppModel
$event = $eventModel->downloadEventFromServer(
$eventId,
$server
);
);;
if (!empty($event)) {
if ($this->__checkIfEventIsBlockedBeforePull($event)) {
return false;
}
$this->__updatePulledEventBeforeInsert($event, $server, $user);
$event = $this->__updatePulledEventBeforeInsert($event, $server, $user);
$this->__checkIfPulledEventExistsAndAddOrUpdate($event, $eventId, $successes, $fails, $eventModel, $server, $user, $jobId);
} else {
// error
@ -2028,6 +2028,7 @@ class Server extends AppModel
'recursive' => -1,
'conditions' => $conditions
));
$pulledProposals = array();
if (!empty($events)) {
$proposals = $eventModel->downloadProposalsFromServer($events, $server);
$pulledProposals = $this->__handlePulledProposals($proposals, $events, $job, $jobId, $eventModel, $user);