configProxy() checks for empty arguments, no need to do it twice

pull/439/head
Richard van den Berg 2015-03-19 09:55:11 +01:00
parent 9e7ea8fe74
commit 0d242d8549
1 changed files with 2 additions and 7 deletions

View File

@ -10,13 +10,8 @@ class SyncTool {
$HttpSocket = new HttpSocket($params);
$proxy = Configure::read('Proxy');
if(!empty($proxy['host']) && !empty($proxy['port'])) {
if(!empty($proxy['method']) && !empty($proxy['user']) && !empty($proxy['password'])) {
$HttpSocket->configProxy($proxy['host'], $proxy['port']);
} else {
$HttpSocket->configProxy($proxy['host'], $proxy['port'], $proxy['method'], $proxy['user'], $proxy['password']);
}
}
$HttpSocket->configProxy($proxy['host'], $proxy['port'], $proxy['method'], $proxy['user'], $proxy['password']);
return $HttpSocket;
}
}