chg: [diagnostic] Beter parsing of submodule output

pull/4425/head
mokaddem 2019-04-02 08:52:23 +02:00
parent 215fd7ee82
commit 2aa5b3cadf
2 changed files with 10 additions and 7 deletions

View File

@ -4570,13 +4570,16 @@ class Server extends AppModel
public function getSubmodulesGitStatus()
{
exec('cd ' . APP . '../; git submodule |cut -f3 -d\ ', $submodulesNames);
exec('cd ' . APP . '../; git submodule status | cut -b 2- | cut -d " " -f 1,2 ', $submodulesNames);
$status = array();
foreach ($submodulesNames as $submoduleName) {
$temp = $this->getSubmoduleGitStatus($submoduleName);
if ( ! empty($temp) ) {
$status[$submoduleName] = $this->getSubmoduleGitStatus($submoduleName);
}
foreach ($submodulesNames as $submoduleNameInfo) {
$submoduleNameInfo = explode(' ', $submoduleNameInfo);
$submoduleCommitId = $submoduleNameInfo[0];
$submoduleName = $submoduleNameInfo[1];
$temp = $this->getSubmoduleGitStatus($submoduleName);
if ( !empty($temp) ) {
$status[$submoduleName] = $this->getSubmoduleGitStatus($submoduleName);
}
}
return $status;
}

View File

@ -61,7 +61,7 @@
<pre class="hidden green bold" id="gitResult"></pre>
<button title="<?php echo __('Pull the latest MISP version from github');?>" class="btn btn-inverse" style="padding-top:1px;padding-bottom:1px;" onClick = "updateMISP();"><?php echo __('Update MISP');?></button>
</div>
<h3><?php echo __('Submodules version');?><it id="refreshSubmoduleStatus" class="fa fa-refresh useCursorPointer" style="font-size: small; margin-left: 5px;"></it></h3>
<h3><?php echo __('Submodules version');?><it id="refreshSubmoduleStatus" class="fas fa-sync useCursorPointer" style="font-size: small; margin-left: 5px;"></it></h3>
<div id="divSubmoduleVersions" style="background-color:#f7f7f9;">
</div>