From 4c0e4984e1d2abae166ba839441b954a4e102489 Mon Sep 17 00:00:00 2001
From: mokaddem <sami.mokaddem@circl.lu>
Date: Wed, 13 May 2020 11:01:16 +0200
Subject: [PATCH] chg: [clusterRelations] Moved relation_tree into its own
 `tool` and added modal support for galaxyQuickView

---
 app/Controller/GalaxiesController.php         |  2 +-
 app/Controller/GalaxyClustersController.php   | 56 ++++++-------
 app/Lib/Tools/ClusterRelationsTreeTool.php    | 78 +++++++++++++++++++
 .../GalaxyClusters/view_relation_tree.ctp     |  4 +-
 app/View/Elements/galaxyQuickViewMini.ctp     | 27 ++++++-
 app/View/Events/view.ctp                      | 11 ---
 app/View/GalaxyClusters/view_relations.ctp    |  6 +-
 app/webroot/css/main.css                      |  4 +
 app/webroot/js/misp.js                        | 36 ++++++++-
 9 files changed, 169 insertions(+), 55 deletions(-)
 create mode 100644 app/Lib/Tools/ClusterRelationsTreeTool.php

diff --git a/app/Controller/GalaxiesController.php b/app/Controller/GalaxiesController.php
index 101b15f1e..b6b075ea1 100644
--- a/app/Controller/GalaxiesController.php
+++ b/app/Controller/GalaxiesController.php
@@ -517,7 +517,7 @@ class GalaxiesController extends AppController
             'recursive' => -1,
             'conditions' => array('Galaxy.id' => $galaxyId)
         ));
-        $tree = $this->Galaxy->generateForkTree($clusters, $galaxy, $pruneRootLeaves=true); // moved this to Lib/Tool
+        $tree = $this->Galaxy->generateForkTree($clusters, $galaxy, $pruneRootLeaves=true);
         if ($this->_isRest()) {
             return $this->RestResponse->viewData($tree, $this->response->type());
         }
diff --git a/app/Controller/GalaxyClustersController.php b/app/Controller/GalaxyClustersController.php
index b213e9ed0..07f592692 100644
--- a/app/Controller/GalaxyClustersController.php
+++ b/app/Controller/GalaxyClustersController.php
@@ -834,41 +834,11 @@ class GalaxyClustersController extends AppController
         $cluster = $this->GalaxyCluster->attachReferencingRelations($this->Auth->user(), $cluster);
         $cluster = $this->GalaxyCluster->attachClusterToRelations($this->Auth->user(), $cluster);
 
-        $treeRight = array(array(
-            'GalaxyCluster' => $cluster['GalaxyCluster'],
-            'children' => array()
-        ));
-        // add relation info between the two clusters
-        foreach($cluster['GalaxyClusterRelation'] as $relation) {
-            $tmp = array(
-                'Relation' => array_diff_key($relation, array_flip(array('GalaxyCluster'))),
-                'children' => array(
-                    array('GalaxyCluster' => $relation['GalaxyCluster']),
-                )
-            );
-            $treeRight[0]['children'][] = $tmp;
-        }
+        App::uses('ClusterRelationsTreeTool', 'Tools');
+        $grapher = new ClusterRelationsTreeTool();
+        $grapher->construct($this->Auth->user(), $this->GalaxyCluster);
+        $tree = $grapher->getTree($cluster);
 
-        $treeLeft = array(array(
-            'GalaxyCluster' => $cluster['GalaxyCluster'],
-            'children' => array()
-        ));
-        if (!empty($cluster['ReferencingGalaxyClusterRelation'])) {
-            foreach($cluster['ReferencingGalaxyClusterRelation'] as $relation) {
-                $tmp = array(
-                    'Relation' => array_diff_key($relation, array_flip(array('GalaxyCluster'))),
-                    'children' => array(
-                        array('GalaxyCluster' => $relation['GalaxyCluster']),
-                    )
-                );
-                $treeLeft[0]['children'][] = $tmp;
-            }
-        }
-
-        $tree = array(
-            'right' => $treeRight,
-            'left' => $treeLeft,
-        );
         $this->set('existingRelations', $existingRelations);
         $this->set('cluster', $cluster);
         $relations = $this->GalaxyCluster->GalaxyClusterRelation->fetchRelations($this->Auth->user(), array(
@@ -885,4 +855,22 @@ class GalaxyClustersController extends AppController
         unset($distributionLevels[5]);
         $this->set('distributionLevels', $distributionLevels);
     }
+
+    public function viewRelationTree($clusterId)
+    {
+        $options = array('conditions' => array('GalaxyCluster.id' => $clusterId));
+        $cluster = $this->GalaxyCluster->fetchGalaxyClusters($this->Auth->user(), $options, true);
+        if (empty($cluster)) {
+            throw new NotFoundException('Invalid galaxy cluster');
+        }
+        $cluster = $cluster[0];
+        $cluster = $this->GalaxyCluster->attachReferencingRelations($this->Auth->user(), $cluster);
+        $cluster = $this->GalaxyCluster->attachClusterToRelations($this->Auth->user(), $cluster);
+        App::uses('ClusterRelationsTreeTool', 'Tools');
+        $grapher = new ClusterRelationsTreeTool();
+        $grapher->construct($this->Auth->user(), $this->GalaxyCluster);
+        $tree = $grapher->getTree($cluster);
+        $this->set('tree', $tree);
+        $this->render('/Elements/GalaxyClusters/view_relation_tree');
+    }
 }
diff --git a/app/Lib/Tools/ClusterRelationsTreeTool.php b/app/Lib/Tools/ClusterRelationsTreeTool.php
new file mode 100644
index 000000000..8c62f245e
--- /dev/null
+++ b/app/Lib/Tools/ClusterRelationsTreeTool.php
@@ -0,0 +1,78 @@
+<?php
+    class ClusterRelationsTreeTool
+    {
+        private $GalaxyCluster = false;
+        private $user = false;
+        private $lookup = array();
+
+        public function construct($user, $GalaxyCluster)
+        {
+            $this->GalaxyCluster = $GalaxyCluster;
+            $this->user = $user;
+            return true;
+        }
+
+        public function getTree($cluster)
+        {
+            $treeRight = array(array(
+                'GalaxyCluster' => $cluster['GalaxyCluster'],
+                'children' => array()
+            ));
+            // add relation info between the two clusters
+            foreach($cluster['GalaxyClusterRelation'] as $relation) {
+                $tmp = array(
+                    'Relation' => array_diff_key($relation, array_flip(array('GalaxyCluster'))),
+                    'children' => array(
+                        array('GalaxyCluster' => $relation['GalaxyCluster']),
+                    )
+                );
+                $treeRight[0]['children'][] = $tmp;
+            }
+    
+            $treeLeft = array(array(
+                'GalaxyCluster' => $cluster['GalaxyCluster'],
+                'children' => array()
+            ));
+            if (!empty($cluster['ReferencingGalaxyClusterRelation'])) {
+                foreach($cluster['ReferencingGalaxyClusterRelation'] as $relation) {
+                    $tmp = array(
+                        'Relation' => array_diff_key($relation, array_flip(array('GalaxyCluster'))),
+                        'children' => array(
+                            array('GalaxyCluster' => $relation['GalaxyCluster']),
+                        )
+                    );
+                    $treeLeft[0]['children'][] = $tmp;
+                }
+            }
+    
+            $tree = array(
+                'right' => $treeRight,
+                'left' => $treeLeft,
+            );
+            return $tree;
+        }
+
+        private function attachOwnerInsideCluster($cluster)
+        {
+            if (!empty($cluster['Org']) && !isset($cluster['GalaxyCluster']['Org'])) {
+                $cluster['GalaxyCluster']['Org'] = array(
+                    'id' => $cluster['Org']['id'],
+                    'name' => $cluster['Org']['name'],
+                );
+            }
+            if (!empty($cluster['Orgc']) && !isset($cluster['GalaxyCluster']['Orgc'])) {
+                $cluster['GalaxyCluster']['Orgc'] = array(
+                    'id' => $cluster['Orgc']['id'],
+                    'name' => $cluster['Orgc']['name'],
+                );
+            }
+            if (!empty($cluster['SharingGroup']) && !isset($cluster['GalaxyCluster']['SharingGroup'])) {
+                $cluster['GalaxyCluster']['SharingGroup'] = array(
+                    'id' => $cluster['SharingGroup']['id'],
+                    'name' => $cluster['SharingGroup']['name'],
+                    'description' => $cluster['SharingGroup']['description'],
+                );
+            }
+            return $cluster;
+        }
+    }
diff --git a/app/View/Elements/GalaxyClusters/view_relation_tree.ctp b/app/View/Elements/GalaxyClusters/view_relation_tree.ctp
index e02030728..f6bc138c4 100644
--- a/app/View/Elements/GalaxyClusters/view_relation_tree.ctp
+++ b/app/View/Elements/GalaxyClusters/view_relation_tree.ctp
@@ -4,8 +4,8 @@ echo $this->element('genericElements/assetLoader', array(
 ));
 ?>
 
-<div style="padding: 5px; min-height: 600px;">
-    <svg id="treeSVG" style="width: 100%; height: 100%; min-height: 500px;"></svg>
+<div style="padding: 5px; display: flex; position: absolute; top: 0; left: 0; right: 0; bottom: 0;">
+    <svg id="treeSVG" style="width: 100%; height: 100%;"></svg>
 </div>
 
 <script>
diff --git a/app/View/Elements/galaxyQuickViewMini.ctp b/app/View/Elements/galaxyQuickViewMini.ctp
index ec6acedb0..e29ee4703 100644
--- a/app/View/Elements/galaxyQuickViewMini.ctp
+++ b/app/View/Elements/galaxyQuickViewMini.ctp
@@ -64,8 +64,9 @@
             echo sprintf(
                 '<div class="large-left-margin">%s %s %s %s</div>',
                 sprintf(
-                    '<span class="bold blue expandable useCursorPointer" data-toggle="popover" data-content="%s">%s</span>',
+                    '<span class="bold blue expandable useCursorPointer" data-content="%s" data-clusterid="%s">%s</span>',
                     h($popover_data),
+                    h($cluster['id']),
                     sprintf(
                         '<span><i class="fas fa-%s"></i> %s</span>',
                         $cluster['local'] ? 'user' : 'globe-americas',
@@ -138,9 +139,31 @@
 
 <script type="text/javascript">
 $(document).ready(function () {
-    $('<?= isset($rowId) ? '#'.$rowId : '' ?> .expandable').popover({
+    $('<?= isset($rowId) ? '#'.$rowId : '' ?> .expandable')
+    .on('click', function() {
+        loadClusterRelations($(this).data('clusterid'));
+    })
+    .popover({
         html: true,
         trigger: 'hover'
     });
 });
+
+function loadClusterRelations(clusterId) {
+    if (clusterId !== undefined) {
+        openGenericModal(
+            '<?= $baseurl ?>/GalaxyClusters/viewRelationTree/' + clusterId,
+            {
+                header: "<?= __('Cluster relation tree') ?>",
+                classes: "modal-xl",
+                bodyStyle: {"min-height": "500px"}
+            },
+            function() {
+                if (window.buildTree !== undefined) {
+                    buildTree();
+                }
+            }
+        );
+    }
+}
 </script>
diff --git a/app/View/Events/view.ctp b/app/View/Events/view.ctp
index 8510b135c..165435434 100644
--- a/app/View/Events/view.ctp
+++ b/app/View/Events/view.ctp
@@ -517,9 +517,6 @@
         <button class="btn btn-inverse toggle qet galaxy-toggle-button" id="attackmatrix_toggle" data-toggle-type="attackmatrix" onclick="enable_attack_matrix();">
             <span class="icon-plus icon-white" title="<?php echo __('Toggle ATT&CK matrix');?>" role="button" tabindex="0" aria-label="<?php echo __('Toggle ATT&CK matrix');?>" style="vertical-align:top;"></span><?php echo __('ATT&CK matrix');?>
         </button>
-        <button class="btn btn-inverse toggle qet galaxy-toggle-button" id="clusterrelation_toggle" data-toggle-type="clusterrelation" onclick="enable_galaxy_relations();">
-            <span class="icon-plus icon-white" title="<?php echo __('Toggle Cluster relationships');?>" role="button" tabindex="0" aria-label="<?php echo __('Toggle Cluster relationships');?>" style="vertical-align:top;"></span><?php echo __('Cluster relations');?>
-        </button>
         <button class="btn btn-inverse toggle qet galaxy-toggle-button" id="attributes_toggle" data-toggle-type="attributes">
             <span class="icon-minus icon-white" title="<?php echo __('Toggle attributes');?>" role="button" tabindex="0" aria-label="<?php echo __('Toggle attributes');?>" style="vertical-align:top;"></span><?php echo __('Attributes');?>
         </button>
@@ -585,13 +582,5 @@ function enable_attack_matrix() {
         $("#attackmatrix_div").html(data);
     });
 }
-
-function enable_galaxy_relations() {
-    if ($("#clusterrelation_div").find('svg').length == 0) {
-        $.get("<?= $baseurl ?>/events/viewClusterRelations/<?php echo h($event['Event']['id']); ?>", function(data) {
-            $("#clusterrelation_div").html(data);
-        });
-    }
-}
 </script>
 <input type="hidden" value="/shortcuts/event_view.json" class="keyboardShortcutsConfig" />
diff --git a/app/View/GalaxyClusters/view_relations.ctp b/app/View/GalaxyClusters/view_relations.ctp
index e24999e1b..6042eea16 100644
--- a/app/View/GalaxyClusters/view_relations.ctp
+++ b/app/View/GalaxyClusters/view_relations.ctp
@@ -151,7 +151,9 @@
             </form>
         </div>
     </div>
-    <?php echo $this->element('GalaxyClusters/view_relation_tree'); ?>
+    <div style="min-height: 600px; position: relative;">
+        <?php echo $this->element('GalaxyClusters/view_relation_tree'); ?>
+    </div>
 </div>
 <div id="referencesTable_div" style="position: relative;" class="statistics_attack_matrix hidden">
     <?= $relationTable ?>
@@ -163,7 +165,7 @@ function toggleClusterRelations() {
         duration: 300,
         complete: function() {
             if (window.buildTree !== undefined) {
-                buildTree();
+                ();
             }
         }
     });
diff --git a/app/webroot/css/main.css b/app/webroot/css/main.css
index b540a4aab..3a63b2051 100644
--- a/app/webroot/css/main.css
+++ b/app/webroot/css/main.css
@@ -941,6 +941,10 @@ a.proposal_link_red:hover {
 .modal-body-long {
     max-height: 600px;
 }
+.modal-xl {
+    width: 1000px;
+    margin-left: -500px;
+}
 
 .ajax_popover_form {
     display:none;
diff --git a/app/webroot/js/misp.js b/app/webroot/js/misp.js
index dfaa2fe9c..50e1af436 100644
--- a/app/webroot/js/misp.js
+++ b/app/webroot/js/misp.js
@@ -1170,14 +1170,44 @@ function clickCreateButton(event, type) {
     simplePopup("/" + destination + "/add/" + event);
 }
 
-function openGenericModal(url) {
+function openGenericModal(url, modalData, callback) {
     $.ajax({
         type: "get",
         url: url,
         success: function (data) {
             $('#genericModal').remove();
-            $('body').append(data);
-            $('#genericModal').modal();
+            if (modalData !== undefined) {
+                $modal = $('<div id="genericModal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="genericModalLabel" aria-hidden="true"></div>');
+                if (modalData.classes !== undefined) {
+                    $modal.addClass(modalData.classes);
+                }
+                $modalHeaderText = $('<h3 id="genericModalLabel"></h3>');
+                if (modalData.header !== undefined) {
+                    $modalHeaderText.text(modalData.header)
+                }
+                $modalHeader = $('<div class="modal-header"></div>').append(
+                    $('<button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button>'),
+                    $modalHeaderText
+                );
+                $modalBody = $('<div class="modal-body"></div>').html(data);
+                if (modalData.bodyStyle !== undefined) {
+                    $modalBody.css(modalData.bodyStyle);
+                }
+                $modal.append(
+                    $modalHeader,
+                    $modalBody
+                );
+                htmlData = $modal[0].outerHTML;
+            } else {
+                htmlData = data;
+            }
+            $('body').append(htmlData);
+            $('#genericModal').modal().on('shown', function() {
+                if (callback !== undefined) {
+                    callback();
+                }
+            });
+            
         },
         error: function (data, textStatus, errorThrown) {
             showMessage('fail', textStatus + ": " + errorThrown);