MISP
/
MISP
mirror of https://github.com/MISP/MISP
2
2
Fork 0
Code Issues Releases Wiki Activity

chg: [fast_update] Only run recorrelation on attributes that need to be recorrelated

pull/9432/head
iglocska 2023-11-23 12:28:53 +01:00
parent 3f4c5c9cb6
commit 4f36105d56
No known key found for this signature in database
GPG Key ID: BEA224F1FEF113AC
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/Model/Attribute.php
View File

@ -2584,6 +2584,7 @@ class Attribute extends AppModel
if (isset($attribute['encrypt'])) {
$attribute = $this->onDemandEncrypt($attribute);
}
$attribute['_materialChange'] = false;
unset($attribute['id']);
if (isset($attribute['uuid'])) {
$existingAttribute = $this->find('first', array(
@ -2615,10 +2616,17 @@ class Attribute extends AppModel
} else {
$attribute['timestamp'] = time();
}
foreach (['value','type','distribution','sharing_group_id'] as $relevantField) {
if (isset($attribute[$relevantField]) && $existingAttribute['Attribute'][$relevantField] !== $attribute[$relevantField]) {
$attribute['_materialChange'] = true;
}
}
} else {
$attribute['_materialChange'] = true;
$this->create();
}
} else {
$attribute['_materialChange'] = true;
$this->create();
}
$attribute['event_id'] = $eventId;
@ -2762,7 +2770,11 @@ class Attribute extends AppModel
}
if ($this->fast_update) {
// Let's recorrelate the event
$this->Correlation->generateCorrelation(false, $event['Event']['id']);
foreach ($attributes as $attribute) {
if (!empty($attribute['_materialChange'])) {
$this->Correlation->generateCorrelation(false, $event['Event']['id'], $attribute['id']);
}
}
// Instead of incrementing / decrementing the event
$attribute_count = $this->find('count', [
'conditions' => [