From 653118162f076b0dca95850fcf956ece6b67c931 Mon Sep 17 00:00:00 2001
From: Olivier BERT <olivier.bert@cert-ist.com>
Date: Mon, 11 Feb 2019 13:19:44 +0100
Subject: [PATCH] Accessibility: added aria properties for the warning list
 icon, which was not visible for screen readers.

---
 app/View/Elements/Events/View/row_attribute.ctp  | 2 +-
 app/View/Elements/Events/View/row_proposal.ctp   | 2 +-
 app/View/Elements/Feeds/View/row_attribute.ctp   | 2 +-
 app/View/Elements/Servers/View/row_attribute.ctp | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/View/Elements/Events/View/row_attribute.ctp b/app/View/Elements/Events/View/row_attribute.ctp
index 4d42f4e62..9f3281345 100644
--- a/app/View/Elements/Events/View/row_attribute.ctp
+++ b/app/View/Elements/Events/View/row_attribute.ctp
@@ -140,7 +140,7 @@
                 foreach ($object['warnings'][$component] as $warning) $temp .= '<span class=\'bold\'>' . h($valueParts[$valuePart]) . '</span>: <span class=\'red\'>' . h($warning) . '</span><br />';
               }
             }
-            echo ' <span class="icon-warning-sign" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover" data-placement="right">&nbsp;</span>';
+            echo ' <span aria-label="' . __('warning') . '" role="img" tabindex="0" class="icon-warning-sign" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover" data-placement="right">&nbsp;</span>';
           }
         ?>
       </div>
diff --git a/app/View/Elements/Events/View/row_proposal.ctp b/app/View/Elements/Events/View/row_proposal.ctp
index 0dddebb39..e56b341b7 100644
--- a/app/View/Elements/Events/View/row_proposal.ctp
+++ b/app/View/Elements/Events/View/row_proposal.ctp
@@ -107,7 +107,7 @@
               foreach ($object['warnings'][$component] as $warning) $temp .= '<span class=\'bold\'>' . h($valueParts[$valuePart]) . '</span>: <span class=\'red\'>' . h($warning) . '</span><br />';
             }
           }
-          echo ' <span class="icon-warning-sign icon-white" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover">&nbsp;</span>';
+          echo ' <span aria-label="' . __('warning') . '" role="img" tabindex="0" class="icon-warning-sign icon-white" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover">&nbsp;</span>';
         }
       ?>
     </div>
diff --git a/app/View/Elements/Feeds/View/row_attribute.ctp b/app/View/Elements/Feeds/View/row_attribute.ctp
index f2b7de421..2b3af5dd5 100644
--- a/app/View/Elements/Feeds/View/row_attribute.ctp
+++ b/app/View/Elements/Feeds/View/row_attribute.ctp
@@ -58,7 +58,7 @@ if ($object['value'] == 'MERGE') debug($object);
                 foreach ($object['warnings'][$component] as $warning) $temp .= '<span class=\'bold\'>' . h($valueParts[$valuePart]) . '</span>: <span class=\'red\'>' . h($warning) . '</span><br />';
               }
             }
-            echo ' <span class="icon-warning-sign" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover">&nbsp;</span>';
+            echo ' <span aria-label="' . __('warning') . '" role="img" tabindex="0" class="icon-warning-sign" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover">&nbsp;</span>';
           }
         ?>
       </div>
diff --git a/app/View/Elements/Servers/View/row_attribute.ctp b/app/View/Elements/Servers/View/row_attribute.ctp
index 81b75d1dc..98cae930c 100644
--- a/app/View/Elements/Servers/View/row_attribute.ctp
+++ b/app/View/Elements/Servers/View/row_attribute.ctp
@@ -65,7 +65,7 @@ if ($object['value'] == 'MERGE') debug($object);
                 foreach ($object['warnings'][$component] as $warning) $temp .= '<span class=\'bold\'>' . h($valueParts[$valuePart]) . '</span>: <span class=\'red\'>' . h($warning) . '</span><br />';
               }
             }
-            echo ' <span class="icon-warning-sign" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover">&nbsp;</span>';
+            echo ' <span aria-label="' . __('warning') . '" role="img" tabindex="0" class="icon-warning-sign" data-placement="right" data-toggle="popover" data-content="' . h($temp) . '" data-trigger="hover">&nbsp;</span>';
           }
         ?>
       </div>