MISP
/
MISP
mirror of https://github.com/MISP/MISP
2
2
Fork 0
Code Issues Releases Wiki Activity

fix: [security] XSS in the template file uploads 

- as reported by Dawid Czarnecki from Zigrin Security
pull/8831/head
iglocska 2022-12-22 15:37:43 +01:00
parent 206f540f02
commit 684d3e5139
No known key found for this signature in database
GPG Key ID: BEA224F1FEF113AC
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/View/Templates/upload_file.ctp
View File

@ -6,7 +6,7 @@ if ($batch == 'yes') {
$multiple = false;
if (isset($filenames)) {
$buttonText = __('Replace File');
} else {
} else {
$buttonText = __('Upload File');
}
}
@ -18,13 +18,13 @@ if ($batch == 'yes') {
echo $this->Form->end();
?>
</div>
<span id="fileUploadButton_<?php echo $element_id; ?>" role="button" tabindex="0" aria-label="<?php echo $buttonText; ?>" title="<?php echo $buttonText; ?>" class="btn btn-primary" onClick="templateFileUploadTriggerBrowse('<?php echo $element_id; ?>');"><?php echo $buttonText; ?></span>
<span id="fileUploadButton_<?php echo h($element_id); ?>" role="button" tabindex="0" aria-label="<?php echo $buttonText; ?>" title="<?php echo $buttonText; ?>" class="btn btn-primary" onClick="templateFileUploadTriggerBrowse(<?php echo json_encode($element_id); ?>);"><?php echo $buttonText; ?></span>
<script type="text/javascript">
$(document).ready(function() {
<?php if (isset($filenames)): ?>
var fileArray = JSON.parse('<?php echo $fileArray;?>');
templateFileHiddenAdd(fileArray, '<?php echo $element_id; ?>', '<?php echo $batch; ?>');
showMessage('<?php echo $upload_error ? 'fail' : 'success'; ?>', '<?php echo $result; ?>', 'iframe');
templateFileHiddenAdd(fileArray, '<?php echo h($element_id); ?>', '<?php echo h($batch); ?>');
showMessage('<?php echo $upload_error ? 'fail' : 'success'; ?>', '<?php echo h($result); ?>', 'iframe');
<?php endif; ?>
});