From b9ab95fa505f6a774799d64c30c2c36d261be3c1 Mon Sep 17 00:00:00 2001 From: Christophe Vandeplas Date: Tue, 9 Jan 2024 17:02:51 +0000 Subject: [PATCH] fix: cosmetic fixes --- src/Lib/Tools/HttpTool.php | 2 +- templates/Cerebrates/index.php | 2 -- templates/Users/index.php | 1 + tests/Helper/ApiTestTrait.php | 2 +- tests/TestCase/Tool/HttpToolTest.php | 2 +- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Lib/Tools/HttpTool.php b/src/Lib/Tools/HttpTool.php index c7da589e4..bfeacb260 100644 --- a/src/Lib/Tools/HttpTool.php +++ b/src/Lib/Tools/HttpTool.php @@ -317,7 +317,7 @@ class HttpTool extends CakeClient */ public static function parseCertificate(mixed $certificate): array { - /* @var $parsed array */ + /** @var array $parsed */ $parsed = openssl_x509_parse($certificate); if (!$parsed) { throw new CakeException("Couldn't get parse X.509 certificate: " . openssl_error_string()); diff --git a/templates/Cerebrates/index.php b/templates/Cerebrates/index.php index 49af39d1a..a499389c2 100644 --- a/templates/Cerebrates/index.php +++ b/templates/Cerebrates/index.php @@ -41,8 +41,6 @@ ] ]; -use Cake\Core\Configure; - echo $this->element('genericElements/IndexTable/index_table', [ 'data' => [ 'data' => $data, diff --git a/templates/Users/index.php b/templates/Users/index.php index 8010fac86..67c39a8aa 100644 --- a/templates/Users/index.php +++ b/templates/Users/index.php @@ -145,6 +145,7 @@ echo $this->element('genericElements/IndexTable/index_table', [ 'sort' => 'certif_public', 'class' => 'short', 'data_path' => 'certif_public', + 'colors' => true, 'requirement' => Configure::read('SMIME.enabled') ], [ diff --git a/tests/Helper/ApiTestTrait.php b/tests/Helper/ApiTestTrait.php index dc1dcad3a..8ef4297dc 100644 --- a/tests/Helper/ApiTestTrait.php +++ b/tests/Helper/ApiTestTrait.php @@ -38,7 +38,7 @@ trait ApiTestTrait /** @var ServerRequest */ protected $_psrRequest; - /* @var boolean */ + /** @var boolean */ protected $_skipOpenApiValidations = false; public function setUp(): void diff --git a/tests/TestCase/Tool/HttpToolTest.php b/tests/TestCase/Tool/HttpToolTest.php index 3923c6598..263e9cf63 100644 --- a/tests/TestCase/Tool/HttpToolTest.php +++ b/tests/TestCase/Tool/HttpToolTest.php @@ -184,7 +184,7 @@ xWV4oBk= { $this->markTestSkipped("This is not very well implemented yet."); $client = new HttpTool(); - /* @var $certificates array */ + /** @var array $certificates */ $certificates = $client->fetchCertificates('https://www.google.com'); // $certificates = $client->fetchCertificates(self::HTTPS_SELF_SIGNED_URI); // $certificates = $client->fetchCertificates('http://www.google.com');