MISP
/
MISP
mirror of https://github.com/MISP/MISP
2
2
Fork 0
Code Issues Releases Wiki Activity

chg: [internal] Do not keep original variable to save memory

pull/7640/head
Jakub Onderka 2021-07-20 15:40:48 +02:00
parent 164c85f5c0
commit c797cb6ac0
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/Model/Event.php
View File

@ -768,7 +768,7 @@ class Event extends AppModel
* @param array $user
* @param int $id Event ID when $scope is 'event', Attribute ID when $scope is 'attribute'
* @param bool $shadowAttribute
* @param string $scope
* @param string $scope 'event' or 'attribute'
* @return array
*/
public function getRelatedAttributes(array $user, $id, $shadowAttribute = false, $scope = 'event')
@ -852,26 +852,26 @@ class Event extends AppModel
$events = $this->find('all', array(
'recursive' => -1,
'conditions' => $conditions,
'fields' => array('Event.id', 'Event.orgc_id', 'Event.info', 'Event.date'),
'fields' => ['Event.id', 'Event.orgc_id', 'Event.info', 'Event.date'],
));
$eventInfos = array_column(array_column($events, 'Event'), null, 'id');
$events = array_column(array_column($events, 'Event'), null, 'id');
$relatedAttributes = array();
$relatedAttributes = [];
foreach ($correlations as $correlation) {
// User don't have access to correlated attribute event, skip.
if (!isset($eventInfos[$correlation['event_id']])) {
if (!isset($events[$correlation['event_id']])) {
continue;
}
$eventInfo = $eventInfos[$correlation['event_id']];
$event = $events[$correlation['event_id']];
$current = array(
'id' => $correlation['event_id'],
'attribute_id' => $correlation['attribute_id'],
'value' => $correlation['value'],
'org_id' => $eventInfo['orgc_id'],
'info' => $eventInfo['info'],
'date' => $eventInfo['date'],
'org_id' => $event['orgc_id'],
'info' => $event['info'],
'date' => $event['date'],
);
$parentId = $correlation[$settings['parentIdField']];
$relatedAttributes[$parentId][] = $current;