From e54b75cebddbb299a7bc047d2d3568c6be56618d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Vinot?= <raphael@vinot.info>
Date: Wed, 25 Oct 2023 10:39:13 +0200
Subject: [PATCH] fix: Update requirements.txt to match
 app/Controller/AppController.php, add test.

---
 .github/workflows/main.yml  |  3 +++
 requirements.txt            |  2 +-
 tests/check_requirements.py | 15 +++++++++++++++
 3 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 tests/check_requirements.py

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index bab43fcd3..3995d2170 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -274,6 +274,9 @@ jobs:
               python tools/misp-feed/validate.py
               deactivate
 
+      - name: Check requirements.txt
+        run: python tests/check_requirements.py
+
       - name: Logs
         if: ${{ always() }}
         run: |
diff --git a/requirements.txt b/requirements.txt
index 90a0bd762..42b1b5bf2 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -6,7 +6,7 @@ misp-lib-stix2>=3.0.1.1
 mixbox>=1.0.5
 plyara>=2.1.1
 pydeep2>=0.5.1
-pymisp==2.4.176
+pymisp==2.4.178
 python-magic>=0.4.27
 pyzmq>=25.1.1
 redis>=5.0.1
diff --git a/tests/check_requirements.py b/tests/check_requirements.py
new file mode 100644
index 000000000..9b25499b3
--- /dev/null
+++ b/tests/check_requirements.py
@@ -0,0 +1,15 @@
+#!/usr/bin/env python3
+
+import re
+
+requirements_file = 'requirements.txt'
+app_controller = 'app/Controller/AppController.php'
+
+with open(requirements_file) as f:
+    req_version = re.findall('pymisp==(.*)', f.read())[0]
+
+with open(app_controller) as f:
+    controler_version = re.findall('pyMispVersion = \'(.*)\'', f.read())[0]
+
+if not req_version == controler_version:
+    raise Exception(f'PyMISP in {requirements_file} ({req_version}) differs from the one in {app_controller} ({controler_version})')