diff --git a/app/View/Elements/genericElements/viewMetaTable.ctp b/app/View/Elements/genericElements/viewMetaTable.ctp index 7db280ce1..47ab6f982 100644 --- a/app/View/Elements/genericElements/viewMetaTable.ctp +++ b/app/View/Elements/genericElements/viewMetaTable.ctp @@ -18,13 +18,29 @@ ... ); */ - $rows = array(); + echo ''; foreach ($table_data as $row) { - $element = false; - if (!empty($row['element'])) { - $element = $this->element($row['element'], empty($row['element_params']) ? array() : $row['element_params']); + $html = ""; + if (isset($row['boolean'])) { + $html = sprintf( + '%s', + (empty($row['class']) && empty($row['value_class'])) ? + (empty($row['boolean']) ? 'label label-important label-padding' : 'label label-success label-padding') : '', + empty($row['boolean']) ? __('No') : __('Yes')); } - $rows[] = sprintf( + if (!empty($row['value'])) { + $html .= nl2br(h(trim($row['value'])), false); + } + if (!empty($row['html'])) { + $html .= $row['html']; + } + if (!empty($row['url'])) { + $html .= sprintf('%s', h($row['url']), h($row['url'])); + } + if (!empty($row['element'])) { + $html .= $this->element($row['element'], empty($row['element_params']) ? array() : $row['element_params']); + } + echo sprintf( '', sprintf( 'meta_table_key %s %s', @@ -38,24 +54,7 @@ empty($row['class']) ? '' : h($row['class']), empty($row['value_class']) ? '' : h($row['value_class']) ), - sprintf( - '%s%s%s%s%s', - !isset($row['boolean']) ? '' : sprintf( - '%s', - (empty($row['class']) && empty($row['value_class'])) ? - (empty($row['boolean']) ? 'bold red' : 'bold green') : '', - empty($row['boolean']) ? 'No' : 'Yes' - ), - empty($row['value']) ? '' : nl2br(h(trim($row['value']))), - empty($row['html']) ? '' : $row['html'], - empty($row['url']) ? '' : sprintf('%s', h($row['url']), h($row['url'])), - empty($element) ? '' : $element - ) - ); + $html + ) . PHP_EOL; } - $rows = implode(PHP_EOL, $rows); - echo sprintf( - '
%s%s
%s
', - 'meta_table table table-striped table-condensed', - $rows - ); + echo ''; diff --git a/app/View/Warninglists/view.ctp b/app/View/Warninglists/view.ctp index 71e27aaa2..abd701275 100644 --- a/app/View/Warninglists/view.ctp +++ b/app/View/Warninglists/view.ctp @@ -13,35 +13,37 @@ 'key' => __('Enabled'), 'boolean' => $data['enabled'], 'html' => sprintf( - ' (%s)', + ' %s', $baseurl, h($warninglist['Warninglist']['id']), $data['enabled'] ? '' : '/1', $data['enabled'] ? __('Disable') : __('Enable'), - $data['enabled'] ? __('disable') : __('enable') + $data['enabled'] ? __('Disable') : __('Enable') ) ), ); $values = []; foreach ($warninglist['WarninglistEntry'] as $entry) { - $value = h($entry['value']); + $value = ''. h($entry['value']) . ''; if ($entry['comment']) { - $value .= ' # ' . h($entry['comment']) . ''; + $value .= ' # ' . h($entry['comment']) . ''; } $values[] = $value; } + echo '
'; echo sprintf( - '
%s

%s

%s
', + '
%s

%s

', sprintf( '

%s

%s', h(mb_strtoupper($warninglist['Warninglist']['name'])), $this->element('genericElements/viewMetaTable', array('table_data' => $table_data)) ), - __('Values'), - implode('
', $values) + __('Values') ); + echo implode('
', $values); + echo '
'; echo $this->element('/genericElements/SideMenu/side_menu', [ 'menuList' => 'warninglist', 'menuItem' => 'view', diff --git a/app/webroot/css/main.css b/app/webroot/css/main.css index ef074b902..5b86b2ad0 100644 --- a/app/webroot/css/main.css +++ b/app/webroot/css/main.css @@ -2839,3 +2839,16 @@ Query builder #event-correlations .event-correlation time { font-style: italic; } + +.label-padding { + padding: 2px 10px; + margin-right: 5px +} + +.warninglist-value { + font-family: Monaco, Menlo, Consolas, "Courier New", monospace; +} + +.warninglist-comment { + color: gray; +}