MISP
/
MISP
mirror of https://github.com/MISP/MISP
2
2
Fork 0
Code Issues Releases Wiki Activity
25,717 Commits
34 Branches
364 Tags
187 MiB
Commit Graph

7061 Commits (2.4)

Author SHA1 Message Date
Jakub Onderka c68031edd8
Merge pull request #9658 from JakubOnderka/stix-exception-logging 
chg: [internal] Log exception when importing stix file
 2024-04-03 16:33:31 +02:00
Jakub Onderka 5159a72d11
Merge pull request #9660 from JakubOnderka/duplicate-sighting-uuid 
fix: [sync] Avoid problem with duplicate sightings UUID
 2024-04-03 16:32:56 +02:00
Sami Mokaddem 87c71ecfc9
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-04-03 15:19:31 +02:00
iglocska 946c012e62
fix: [analyst data chunk size] increased 2024-04-03 15:12:53 +02:00
Sami Mokaddem 1624c2a8d1
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-04-03 14:44:47 +02:00
Sami Mokaddem 16439afde5
new: [analyst-data] Added Inbound Relationship to all views. 2024-04-03 14:44:08 +02:00
Jakub Onderka 2f72afd59f fix: [sync] Avoid problem with duplicate sightings UUID 2024-04-03 13:42:23 +02:00
Jakub Onderka 67e2478845
Merge pull request #8760 from JakubOnderka/sightings-conditions-simplify 
chg: [internal] Speedup sighting rest search
 2024-04-03 13:09:16 +02:00
Jakub Onderka e8d3d76fd9 chg: [internal] Log exception when importing stix file 2024-04-03 12:18:33 +02:00
Alexandre Dulaunoy e60fe35e0a
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-04-03 12:09:09 +02:00
iglocska ebef5a388c
chg: [UI] event view now only load analyst data for objects/attributes actually shown via pagination 2024-04-03 12:06:17 +02:00
Alexandre Dulaunoy 02bf0ebd54
new: [attribute] new attribute type added `integer` 
Initially, we utilised a counter type across numerous objects.

However, the semantic significance of this type became unclear when establishing relationships with integers in various objects.

Signed-off-by: Alexandre Dulaunoy <a@foo.be>
 2024-04-03 12:04:46 +02:00
iglocska 51782c1d03
chg: [curl client] added option for timeout 2024-04-03 09:50:57 +02:00
Jakub Onderka 1f3f018bf7 fix: [internal] Attribute.php code style fix 2024-04-02 19:40:14 +02:00
Jakub Onderka 5247b9cd6d fix: [internal] Check if values is not empty for MysqlExtended 2024-03-24 13:35:00 +01:00
Jakub Onderka aaa8301ab2 fix: [internal] Undefined index in error message during sync 2024-03-24 13:31:11 +01:00
Jakub Onderka 0a77e3c3b8
Merge pull request #9635 from JakubOnderka/error-handling-sighting 
chg: [internal] Better error handling when fetching sightings
 2024-03-23 11:51:51 +01:00
Jakub Onderka 646c58095f chg: [internal] Better error handling when fetching sightings 2024-03-23 11:30:44 +01:00
iglocska 74579bb1fe
fix: [attribute search] enforce unpublishedprivate directive 2024-03-22 15:24:05 +01:00
Jakub Onderka 9fb1939b70
Merge pull request #9631 from JakubOnderka/attachment-scan-error 
fix: [internal] Error handling for error message in AttachmentScan
 2024-03-21 15:12:48 +01:00
Jakub Onderka 7894b9e7e7 fix: [internal] Error handling for error message in AttachmentScan 2024-03-21 14:34:17 +01:00
iglocska 7f0b4cd9ab
fix: [sync] if push rules don't have the type_attributes set, don't throw an error 2024-03-21 14:30:49 +01:00
iglocska 394d680a7b
chg: [version] bump 2024-03-20 14:09:22 +01:00
iglocska 94d7537eec
chg: [attribute search] rework 
- Massive performance improvement when using MysqlExtended or MysqlObserverExtended data sources
- event level lookup moved to subqueries, allowing for simpler, much faster indexed queries
- Ignoring the deleted index as it slows things down
 2024-03-20 13:07:10 +01:00
iglocska 7072451d0f
new: [datasource] improvements 
- Some datasources updated with the ignoreIndexHint parameter
  - mysqlExtended
  - mysqlObserverExtended

- Also fixed forceIndexHint
 2024-03-20 13:04:36 +01:00
Sami Mokaddem 1be477c457
Merge remote-tracking branch 'origin/develop' into pr-9589 2024-03-19 14:22:32 +01:00
Vincenzo Caputo 752638528b Fix key error on shadow attribute's id 2024-03-16 16:27:57 +00:00
Vincenzo Caputo 044923ee3a Change trigger's icon 2024-03-16 15:33:45 +00:00
Vincenzo Caputo ee3508182d Change scope to 'shadow-attribute' 2024-03-16 15:32:42 +00:00
iglocska 3022d51a06
fix: [performance] load analyst data in bulk 
speeds up event loading dramatically
 2024-03-15 08:41:55 +01:00
iglocska 945f875e10
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-03-15 07:48:18 +01:00
iglocska 6b408a6be5
chg: [attribute fetch] slightly refactored 
- simplify conditions
- don't load acl conditions twice
 2024-03-15 07:43:58 +01:00
Alexandre Dulaunoy fa0fa036b5
Merge branch '2.4' into develop 2024-03-14 16:24:52 +01:00
Alexandre Dulaunoy 4834fa96a4
Merge branch '2.4' into develop 2024-03-13 11:18:19 +01:00
Vincenzo Caputo f0e1dcb3da
Add include attachments option when fetching event in EventDelegation.php 2024-03-13 10:57:39 +01:00
Sami Mokaddem c797865c7c
chg: [sightings:getLastSighting] Added support of sighting policy 
Fix #8660
 2024-03-12 14:41:22 +01:00
Sami Mokaddem 7d8b1b0260
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-03-12 11:33:54 +01:00
Sami Mokaddem ec769c3f27
chg: [attribute:restSearch] Improved performance of `includeDecayScore` by a factor of 5 2024-03-12 11:32:10 +01:00
Jakub Onderka df27db5644 fix: [UI] Add missing `MISP.email_reply_to` to server config 2024-03-12 10:06:48 +01:00
Jakub Onderka 031afce5d2 chg: [internal] Add title to alert template 2024-03-12 09:33:44 +01:00
iglocska 3c79ebbc06
new: [settings] added setting to (temporarily) disable the loading of sightings via the API 
- affected endpoints: restsearch and /events/view
- temporarily skips the loading of sightings

- helps alleviate absolutely massive sighting data sets from killing server performance
- temporary measure, doesn't prevent the creation of sightings / viewing of sightings via the UI
 2024-03-12 08:24:13 +01:00
Sami Mokaddem aaf3633cb0
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-03-07 10:54:44 +01:00
Sami Mokaddem 3dcf54aad5
fix: [events:restsearch] Correctly unset variable by reference after looping 
- This avoid attributes being overridden others when using `includeAnalystData` parameter
 2024-03-07 10:52:54 +01:00
iglocska b6d7755e9e
fix: [sync] pulls should continue after an event save failure 
- fixes #9558
 2024-03-06 13:28:11 +01:00
iglocska 826c60b62c
Merge branch '2.4' into develop 2024-03-06 11:01:47 +01:00
Andras Iklody 11865f6755
Merge pull request #9602 from karenyousefi/2.4 
Update Event.php
 2024-03-06 11:00:39 +01:00
iglocska aac29ad6af
fix: [db update] added IF NOT EXISTS clauses to create table calls 2024-03-06 10:57:30 +01:00
iglocska 6979fef446
fix: [API consistency] 
- represent the local field for tags as a boolean rather than an int
 2024-03-06 10:47:28 +01:00
iglocska 30e8aa454a
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-03-06 10:40:41 +01:00
iglocska dc0cb15675
fix: [logging] fixed using removeTagFromObject() 
- no longer creates erroneous log entries when unpublishing the event
 2024-03-06 10:39:55 +01:00
Andras Iklody e42802bcfb
fix: [database update] fix 
- for older mysql versions
 2024-03-06 10:24:54 +01:00
Andras Iklody bdc0637e3d
Update AppModel.php 
fix: [analyst data] update script

- remove default current_timestamp() on older versions of v121 of the db updates
- avoids chicken and egg problem on ancient mysql versions
 2024-03-06 10:18:09 +01:00
Jakub Onderka 5acf0a922c fix: [pull] Fix pulling from remote server when analyst data is not supported 2024-03-04 15:36:34 +01:00
Karen Yousefi 939764d274
Update Event.php 
fix error Undefined offset: 0 in [/var/www/MISP/app/Model/Event.php, line 3682]
 2024-03-01 22:03:58 +03:30
Sami Mokaddem a4f0a6681b
fix: [event:_mergeExtension] Include analyst data on extension if originally requested in the request 2024-02-29 14:52:52 +01:00
Sami Mokaddem e6dd70bd64
fix: [analyst-data:hasMoreNotesOrOpinions] Use correct model to fetch additional opinions 2024-02-29 14:24:45 +01:00
iglocska b870728f6b
fix: [analystdata] push and pull fixes 
- push: check sharing group data correctly
- pull: Don't throw errors if not all 3 types of notes exist on the remote
 2024-02-29 11:18:06 +01:00
Bradley Logan ee986fc2fc
chg: Set BrowscapPHP logging from default DEBUG to INFO 2024-02-28 15:22:14 -08:00
Jakub Onderka 8854fa58b2
Merge pull request #9508 from JakubOnderka/redis-info 
new: [UI] Show dragonfly version in diagnostics
 2024-02-28 13:53:59 +01:00
iglocska cf0910dc04
fix: [analystdata] removed invalid field from the change before the last 2024-02-27 09:06:15 +01:00
iglocska 060cf4f45d
fix: [analystdata] restrict what to display in associated models 2024-02-27 09:03:17 +01:00
iglocska 38c6ffd7a0
fix: [analystdata] fixed editing of context specific editable fields 2024-02-27 08:44:34 +01:00
iglocska 9f859892c2
fix: [analyst data] zero out sharing group ID when other distribution setting is selected 2024-02-27 08:24:24 +01:00
Vincenzo Caputo 84eed089c2 Remove newline in overhead message 2024-02-25 16:00:01 +00:00
Vincenzo Caputo 74c7133be8 Add overhead message 2024-02-25 15:59:14 +00:00
Vincenzo Caputo eca3cd9cbf Add call to trigger before saving shadow attribute 2024-02-25 15:54:42 +00:00
Vincenzo Caputo 02de43a49e Add shadow attribute before save trigger 2024-02-25 15:51:01 +00:00
Alexandre Dulaunoy 8d1a74b40b
Merge branch '2.4' into develop 2024-02-24 13:46:09 +01:00
Vincenzo Caputo 626fafc40f Fix Tag replacement workflow module description 2024-02-24 11:31:17 +00:00
Christian Studer 354da05e19
fix: [upload_stix] Fixed naive copy paste failing after an arbitrary variable name change 2024-02-23 22:44:38 +01:00
Christian Studer 41b20f96d3
add: [stix2 import] Added organisation UUID parameter to be used when generating custom Galaxy Clusters UUID 2024-02-23 21:41:08 +01:00
Christian Studer 1163539038
fix: [upload_stix] Fixed undefined index `cluster_sharing_group_id` when uploading stix file 2024-02-23 16:03:00 +01:00
Christian Studer 9221682157
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-02-23 15:49:03 +01:00
Jakub Onderka f8a92524ee
fix: [UI] Custom logos 2024-02-23 10:31:42 +01:00
iglocska e6ec7871e3
fix: [notes] changed timestamp output to not include timezone 
- doesn't work on all versions of mariadb/mysql
 2024-02-23 10:18:29 +01:00
Sami Mokaddem 224415c3b4
chg: [analyst-data:edit] Added support of editable fields 2024-02-22 08:32:47 +01:00
Sami Mokaddem 720336f65d
chg: [analyst-data:datetimes] Moved datetime manamgent of created and modified field from the DB to the app. 
- This change is to enforce the usage of UTC time as using MySQL's CURRENT_TIMESTAMP uses the TZ of the server
 2024-02-21 16:20:07 +01:00
Jakub Onderka 2c43d5c277 fix: [UI] Custom logos 2024-02-20 16:17:43 +01:00
Sami Mokaddem d8bf22b422
Merge remote-tracking branch 'origin/develop' into notes 2024-02-20 11:16:01 +01:00
Sami Mokaddem 752807ef37
fix: [workflowModules:attributeEditionOperation] Make sure to call Attribute->editAttribute on data to be saved 2024-02-19 15:02:27 +01:00
Jeroen Pinoy 31cd3f2023
fix: [workflow] fix attribute edit module actions 2024-02-18 18:05:08 +01:00
Sami Mokaddem 6f99b148f0
Merge remote-tracking branch 'origin/develop' into notes 2024-02-16 15:29:03 +01:00
Sami Mokaddem 8530d6344b
fix: [analyst-data:relationship] Make sure to rearrange data only when the referrenced element exists 2024-02-16 15:26:11 +01:00
iglocska c47f1987dc
Merge branch 'develop' of github.com:MISP/MISP into develop 2024-02-16 14:24:44 +01:00
iglocska c1638e0a9c
fix: [sighting sync] speculative fix for critical sync issue 
- pulls from an instance with extremely high numbers of sightings (~300M+) can lead to the pulled instance becoming unusable
- This fix addresses multiple issues:
  - The use of last:0 as a sighting pull filter parameter lead to a search using an unindexed field
  - Internally searching for sighting IDs across 500 events in one shot can lead to massive data-sets
  - Internally searching for sighting IDs by Event.uuid on a joined table is extremely slow compared to searching on the sighting table alone
 2024-02-16 14:21:10 +01:00
Sami Mokaddem 159f5278ef
fix: [analyst-data:view] Fixed analyst-data/view/all endpoint 2024-02-16 10:30:26 +01:00
Sami Mokaddem 9d66ff0815
fix: [app] Fixed error while merging in db_change number 2024-02-16 08:38:45 +01:00
Sami Mokaddem 66cd091ac4
Merge remote-tracking branch 'origin/develop' into notes 2024-02-16 08:30:04 +01:00
Andras Iklody aa67046917
Merge pull request #9564 from Wachizungu/fix-objects-restsearch-first-seen 
fix: fix objects restsearch first_seen filter
 2024-02-15 17:26:43 +01:00
iglocska 9c244eb115
fix: [security] Org image upload moved out of webroot 
- images will no longer be accessible directly, only via inclusion via file-read/b64 encoding
- The new store for org images is MISP/app/files/img/orgs

- As reported by Yusuke Nakajima
 2024-02-15 15:35:12 +01:00
Sami Mokaddem 502682ee51
fix: [analyst-data:pull] Return early if there is nothing to pull 2024-02-15 15:21:00 +01:00
Sami Mokaddem 25869b189f
fix: [object:editObject] Call function from the correct model 2024-02-15 14:12:55 +01:00
Sami Mokaddem 147c9b1af4
fix: [object:editObject] Avoid un-nesting object when not applicable 2024-02-15 13:31:53 +01:00
Sami Mokaddem 5827170008
fix: [aclComponent] Make queryACL not complaining 2024-02-15 13:30:16 +01:00
Sami Mokaddem df95b4ba7f
fix: [eventReport:editReport] Call function from the correct model 2024-02-15 13:27:54 +01:00
Sami Mokaddem 66926d1b60
fix: [attribute:editAttributePostProcessing] Call function from the correct model 2024-02-15 12:09:36 +01:00
Jeroen Pinoy bf6a148bc8
fix: fix objects restsearch first_seen filter 2024-02-14 15:40:06 +01:00
Sami Mokaddem 54b3c566d4
new: [Event:_edit] Added support of recursive update of analyst data 2024-02-14 11:22:43 +01:00
Sami Mokaddem 006c900c8e
new: [Event:_add] Added support of recursive capture of analyst data 2024-02-14 09:48:11 +01:00
Sami Mokaddem 714cb9ea78
chg: [event:restSearch] Added support of `includeAnalystData` options 
Also export analyst data using the event `Download as` function by default
 2024-02-14 08:36:28 +01:00