Commit Graph

1048 Commits (19c2e90e3b0dda81af3078b0ba9e796abd5469b5)

Author SHA1 Message Date
Iglocska 5f1196eba5 Fix to an issue that blocked event blacklist entries from being added manually, fixes #676 2015-09-24 11:26:23 +02:00
Iglocska a55e38ffda Fix to the previous commit 2015-09-23 12:32:00 +02:00
Iglocska 6ef7772e0b Fixed an issue with old upgraded instances that didn't use the db session handler
- diagnostic tool would throw exceptions because the db session tables are still missing in some older instances
- if a different session handler is used, the test is skipped
2015-09-23 12:14:32 +02:00
Iglocska 4a16fb3941 Changed behaviour where REST delete returns the index on success, fixes #673
- REST delete of events lacked an API specific response
- simply redirected to the index

- it now returns eitehr "Event deleted" or "Event was not deleted" depending on the outcome
2015-09-22 19:41:24 +02:00
iglocska 3234aaf887 Fixes to the user index, fixes #556
- index can now be sorted case insensitive
- removed a notice error during sorting (sorting parameters should not be displayed as a filter)
2015-09-18 10:42:50 +02:00
iglocska cfec8d65e4 Fix to an issue introduced in 2.3.128 that incorrectly causes MISP to not sync due to a version mismatch 2015-09-17 11:28:57 +02:00
iglocska 7f3996f43b Added an API to quickly check the current MISP version, fixes #664 2015-09-17 00:21:08 +02:00
iglocska 1d4e07d965 Merge branch 'master' of https://github.com/MISP/MISP 2015-09-16 19:07:21 +02:00
iglocska 1079c4a1ea Added a diagnostic to check and purge overgrown session tables 2015-09-16 18:55:28 +02:00
Raphaël Vinot 7b1155599b Fix #654
At least, I think so, please review :)
2015-09-16 16:04:12 +02:00
iglocska b8fae35f34 Added ID in the response of the upload sample API
- it now also returns the ID of the created/updated event
2015-09-16 14:54:07 +02:00
iglocska 0fe9794370 Removed redirect to the news page 2015-09-16 14:35:56 +02:00
iglocska c06e687b5e Event blacklist context completed 2015-09-16 14:19:22 +02:00
iglocska 26e640e19c Further progress on several issues 2015-09-16 12:15:43 +02:00
Iglocska df59748719 progress on several issues
- switching workstations, this is all WiP
2015-09-15 15:11:08 +02:00
Iglocska bc06362d19 Fixed XSS in several views
- reported by Roberto Suggi Liverani from NCIA
2015-09-09 19:26:06 +02:00
Iglocska 2142bf87c3 Several issues resolved
- fixed an issue where pushing a single event would fail

- both event and attribute edits via the API work without providing a timestamp. The current timestamp is instead attached

- both event and attribute edits fill the required fields from the data in the database if not supplied (as long as the uuid is found)
2015-09-07 14:25:24 +02:00
Iglocska 291ebc8393 Typo, fixes #632 2015-09-07 10:31:25 +02:00
Iglocska e7b54c2c61 Fix to a serious bug with adding attributes via the API and performance fixes
- due to a bug, setting an attribute ID in the /attributes/add API call can lead to overwriting an existing attribute

performance improvements:

- massive improvements to the correlation performance
- improvements to the attribute validation process
2015-09-07 10:06:34 +02:00
Iglocska 43c2290097 Enhancements to the reportValidationIssuesAttributes action
- now also shows issues not related to the value field
- takes an optional parameter to validate a single event's attributes
2015-09-03 10:58:54 +02:00
Iglocska 62532260ef Addition to the previous commit 2015-09-02 10:18:08 +02:00
Iglocska 0ded8805c0 Cleanup of some mistakes 2015-08-27 13:47:54 +02:00
Iglocska 01398b3ade Add / Remove tags from events via a new API 2015-08-27 12:38:50 +02:00
Iglocska 597e40fc0f Collection of fixes
- CSV export ignored the tag parameters
- tagging events didn't work as expected in some cases
- timing out and clicking on an admin action results in being redirected to a non-existing admin login page
- distribution setting ignored when uploading attachments
2015-08-27 09:44:58 +02:00
Iglocska 556688069a Resolved an issue that can lead to duplicate events showing up in MISP
- UUID uniqueness was previously not enforced
- changed the MYSQL.sql file to reflect the changes
- Added upgrade admin tool to remove duplicate events and make the database changes required
- Tweaked the tool for the attribute uuid fix so that it cannot created duplicate keys

- some minor fixes, such as automatically removing eventTag objects on event deletion
2015-08-25 10:32:26 +02:00
Iglocska 64485ad4a6 Fixed a bug with downloadSample that returns all accessible samples instead of the requested one, fixes #610
- fixed incorrect branch order causing this issue
2015-08-24 13:29:25 +02:00
Iglocska bd7555b185 Various fixes to the OpenIOC import and the password reset, fixes #600, fixes #599, fixes #565
- OpenIOC import now correctly sets IDS flags based on type
- OpenIOC import specifies the source file in the comments

- Fixed a blackhole issue with the password reset popups
2015-08-19 13:20:14 +02:00
Iglocska ebbc7390d1 Added event ID field to restSearch APIs, to assist #456
- eventid a new parameter for both event and attribute restsearch
- these APIs now accept arrays in both json and xml format (you can send "eventid": ["15", "16"] instead of "eventid": "15&&16" in addition to the old functionality
2015-08-18 19:51:41 +02:00
Iglocska ce2e6a769d Some fixes to the OpenIOC import tool
- added support for SHA types
- fixed an issue that caused the import to fail with duplicate attributes (the list gets pruned now)
- fixed an issue where no supplied contextual fields would lead to empty attributes being created
- removed the requirement for the files to have the .ioc extension
2015-08-18 17:16:58 +02:00
Iglocska 76b8aacc4c Added event ID/UUID to the event filters and attribute search
- enter a UUID in the event ID field of the attribute search to find attributes belonging to a certain event
- use event IDs / UUIDs to filter events on the event index
2015-08-18 15:37:49 +02:00
iglocska a93807439d Several bigger changes
- new functionality: Event blacklisting by UUID
  - site admins cna enable this feature in the server settings
  - enabling the feature will make the required db changes
  - any deleted event will automatically get blacklisted
  - this prevents deleted events from flowing back from a synced instance
  - site admins can manually add UUIDs to the list and remove entries

- fix to UUID duplication issues for attributes
  - simply run the admin script and it will regenerate the UUID of attributes that are duplicates, if any such exist
  - timestamps/event published status will not be affected

- config.core.php now includes a change that prevents from 404 exceptions being logged
  - the sync uses 404s to signal that an event with a given uuid does not exist when negotiating proposal synchronisation
  - this causes a dangerously high amount of noise in the logs
2015-08-17 16:10:10 +02:00
Iglocska 94398b8192 Download all samples for an event ID via the API
- as explained on the automation page
- also, better error handling

- all API calls that fail during authentication will now return a JSON/XML error message instead of redirecting to the login page
2015-08-07 16:10:40 +02:00
Iglocska 5273c2c5aa New functionality: API to download sample by hash
- simply pass an MD5 hash along and receive a sample if available zipped and base64 encoded in a response object
- pass any hash along with a flag set and receive any samples from events that have the passed hash

- Also, fix for an issue with the freetext import not using semi-colons as separators
2015-08-07 12:04:44 +02:00
Iglocska 7e10eb7b46 Some fixes to the upload malware API
- Threat level ID options correctly set
- Threat level ID validation tightened to reject anything but the existing threat levels
- The upload malware API now logs validation issues during the failed creation of attributes / events
2015-08-05 00:11:16 +02:00
Iglocska 0a26879d45 Additional parameters for the upload sample API 2015-08-04 02:30:22 +02:00
Iglocska 7db6e9ac47 A list of changes to the way attachments are uploaded, fixes #559, fixes #482
- new API for uploading malware samples
  - allows the upload of several files
  - can be used to populate a pre-existing event, or create a new event
  - expects a JSON or an XML object with the samples base64 encoded
- new way of storing malware samples
  - original filename not used any longer
  - samples are renamed to their md5 hashes
  - original filename preserved in a secondary txt file
- removed filename validation as it is no longer used for the command line execution
  - this allows unicode name files to be uploaded!
  - changed the UI attachment upload to reflect these changes
  - code more centralised and extendible
2015-08-04 02:00:21 +02:00
Iglocska ff01eebf70 Added the same functionality to the regex edit 2015-07-27 08:26:01 +02:00
Iglocska 0874faa991 Added error message if regex is added without choosing a type, fixes #575
- user will be taken back to the form if no type selected
2015-07-27 08:13:20 +02:00
Iglocska b089cf077f Some changes to the workers
- some fixes with the previous iteration of the background workers
- PID now checked using ps -p instead of looking for it in /proc
2015-07-17 15:06:38 +02:00
Iglocska 1645ee1e3b Rework of the diagnostics for background workers
- shows dead background workers
- allows site admins to add workers to any queue on the fly
- allows site admins to kill workers on the fly
2015-07-12 21:45:11 +02:00
Iglocska e706562cd5 Fixes to the RPZ export based on the testing of elhoim
- some errors in the format (wrong comment character used, rpz-ip not appended to IP addresses, missing semi-colon)
- removed hostnames that are on domains blocked by the rules based on domain attributes
2015-07-07 14:42:28 +02:00
Iglocska 27cc167c33 Fix to an incorrect validation of temporary filenames 2015-07-01 11:06:11 +02:00
Iglocska 45fdbf7839 File management fixed in server settings
- a previous patch removed the contents of the page
2015-07-01 09:50:51 +02:00
Iglocska 415d85102d Security fix: Fix to a possible PHP Object injection
- unserialized user input replaced with json_decode
2015-07-01 08:38:40 +02:00
Iglocska 3f215743f0 Complete rework of the ZeroMQ implementation
- python server running in the background doing the publishing
- MISP -> python script communication via redis
- configurable / controllable via the admin UI
2015-06-29 08:56:45 +02:00
Iglocska dc9fbf48d0 Proposal mass accept/discard, fixes #466 2015-06-25 11:51:36 +02:00
Iglocska 3d2b8c3c10 Added pub/sub feature using ZeroMQ, fixes #540 and fixes #526
- by installing the requirements described in the update and the install instructions (ubuntu only for now, centos/red-hat versions to be tested and described), administrators can enable the pub/sub feature
- assign a port to the service via the interface
- each time an event is published, MISP will use ZMQ's PUB feature to push out a MISP JSON package using the "misp_json" prefix
2015-06-24 17:38:15 +02:00
Iglocska ae0e1aeacb Merge branch 'feature/rpz' into hotfix-2.3.86
Conflicts:
	app/Console/Command/EventShell.php
	app/Model/Server.php
2015-06-23 17:19:08 +02:00
Iglocska ea0dd2a33f PGP key selection on fetch, fixes #554
- MISP will now fetch a list of all keys matching the e-mail address from the MIT server from the user edit view
- A popup will present all the matching keys (with the creation date, key ID, email addresses associated - and the fingerprint when hovering over them)
- Once the admin clicks on one, it will fetch the desired key

- future enhancement possibility: move the second stage (the actual key fetch) to the server side instead of a direct ajax query from the user's browser
2015-06-23 10:56:19 +02:00
Iglocska 0e09319eae Tuning of the complex type tool 2015-06-22 14:11:43 +02:00