Commit Graph

1988 Commits (19c2e90e3b0dda81af3078b0ba9e796abd5469b5)

Author SHA1 Message Date
Iglocska 76b8aacc4c Added event ID/UUID to the event filters and attribute search
- enter a UUID in the event ID field of the attribute search to find attributes belonging to a certain event
- use event IDs / UUIDs to filter events on the event index
2015-08-18 15:37:49 +02:00
Iglocska 80dcdcf9d8 Database update admin-actions are now logged and if they fail the errors are logged 2015-08-18 09:44:59 +02:00
iglocska a93807439d Several bigger changes
- new functionality: Event blacklisting by UUID
  - site admins cna enable this feature in the server settings
  - enabling the feature will make the required db changes
  - any deleted event will automatically get blacklisted
  - this prevents deleted events from flowing back from a synced instance
  - site admins can manually add UUIDs to the list and remove entries

- fix to UUID duplication issues for attributes
  - simply run the admin script and it will regenerate the UUID of attributes that are duplicates, if any such exist
  - timestamps/event published status will not be affected

- config.core.php now includes a change that prevents from 404 exceptions being logged
  - the sync uses 404s to signal that an event with a given uuid does not exist when negotiating proposal synchronisation
  - this causes a dangerously high amount of noise in the logs
2015-08-17 16:10:10 +02:00
Iglocska 94398b8192 Download all samples for an event ID via the API
- as explained on the automation page
- also, better error handling

- all API calls that fail during authentication will now return a JSON/XML error message instead of redirecting to the login page
2015-08-07 16:10:40 +02:00
Iglocska 5273c2c5aa New functionality: API to download sample by hash
- simply pass an MD5 hash along and receive a sample if available zipped and base64 encoded in a response object
- pass any hash along with a flag set and receive any samples from events that have the passed hash

- Also, fix for an issue with the freetext import not using semi-colons as separators
2015-08-07 12:04:44 +02:00
Iglocska 7e10eb7b46 Some fixes to the upload malware API
- Threat level ID options correctly set
- Threat level ID validation tightened to reject anything but the existing threat levels
- The upload malware API now logs validation issues during the failed creation of attributes / events
2015-08-05 00:11:16 +02:00
Iglocska 0a26879d45 Additional parameters for the upload sample API 2015-08-04 02:30:22 +02:00
Iglocska 7db6e9ac47 A list of changes to the way attachments are uploaded, fixes #559, fixes #482
- new API for uploading malware samples
  - allows the upload of several files
  - can be used to populate a pre-existing event, or create a new event
  - expects a JSON or an XML object with the samples base64 encoded
- new way of storing malware samples
  - original filename not used any longer
  - samples are renamed to their md5 hashes
  - original filename preserved in a secondary txt file
- removed filename validation as it is no longer used for the command line execution
  - this allows unicode name files to be uploaded!
  - changed the UI attachment upload to reflect these changes
  - code more centralised and extendible
2015-08-04 02:00:21 +02:00
Iglocska ff01eebf70 Added the same functionality to the regex edit 2015-07-27 08:26:01 +02:00
Iglocska 0874faa991 Added error message if regex is added without choosing a type, fixes #575
- user will be taken back to the form if no type selected
2015-07-27 08:13:20 +02:00
Iglocska d8cfbac67f Mass IDS toggle for freetext import, fixes #576
- added a toggle for the IDS fields in the freetext import to quickly set all found attributes to being IDS worthy
2015-07-23 08:33:04 +02:00
Iglocska 616629e9b5 Fixed an issue with the NIDS export not correctly working for single events 2015-07-22 19:27:56 +02:00
Iglocska 684be69ed0 Incremental export generation for HIDS and NIDS exports
- Instead of fetching all events at once for the export, events are fetched one by one
- Greatly reduces memory footprint (It mostly depends on the event with the most eligible attributes now, instead of the combined list of all events)
- Because of the lower memory usage, the time taken for the export is also slashed to a fragment of what it was before
2015-07-20 16:25:16 +02:00
Iglocska 265088a0ea Merge branch '570' into hotfix-2.3.98 2015-07-17 15:09:27 +02:00
Iglocska b089cf077f Some changes to the workers
- some fixes with the previous iteration of the background workers
- PID now checked using ps -p instead of looking for it in /proc
2015-07-17 15:06:38 +02:00
Iglocska 93f9a01c87 Changes to the hids exports
- fixed some issues with unset variables (from, to, last) when triggered by the background workers
- reduced memory usage of the hids exports (removed storing the hashes twice in memory, drastically removed the data retrieved from the db when preparing the export)
2015-07-17 10:50:50 +02:00
Richard van den Berg 0b7df293ea Convert tab to spaces 2015-07-16 18:05:41 +02:00
Richard van den Berg 93c1849780 Remove unused relatedTTP 2015-07-16 18:04:39 +02:00
Richard van den Berg b126db534a Add timezone +00:00 to timestamp 2015-07-16 17:56:52 +02:00
Richard van den Berg 27d09b4e22 Change incident description to title 2015-07-16 17:53:49 +02:00
Richard van den Berg 2e1864f28d Add Indicated_TTP 2015-07-16 17:49:51 +02:00
Richard van den Berg ab2aeeb868 Add Valid_Time_Position 2015-07-16 12:55:20 +02:00
Richard van den Berg f68bd3f785 Add indicator types 2015-07-16 12:36:42 +02:00
Richard van den Berg c15a178013 Add condition attributes 2015-07-15 17:10:55 +02:00
Iglocska c906cacd81 Merge branch 'pr567' into hotfix-2.3.97 2015-07-13 11:23:29 +02:00
Iglocska 47ad24fbad Merge branch 'pr564' into hotfix-2.3.97 2015-07-13 11:23:24 +02:00
Iglocska 6a9893affd Merge branch 'pr546' into hotfix-2.3.97 2015-07-13 11:23:19 +02:00
Richard van den Berg 4b5bc3736a Use setupHttpSocket for fetchPGPKey 2015-07-13 11:05:53 +02:00
Iglocska 1645ee1e3b Rework of the diagnostics for background workers
- shows dead background workers
- allows site admins to add workers to any queue on the fly
- allows site admins to kill workers on the fly
2015-07-12 21:45:11 +02:00
David André 2b6ec81891 Edited comment for RPZ_Policy
Removed copy/pasta and added a correct comment for RPZ_Policy
2015-07-09 11:49:58 +02:00
Iglocska 2438ec2f35 Some tuning to the hostname / url type recognition in the freetext import tool, fixes #562 2015-07-09 10:56:17 +02:00
Iglocska 6a25471ea4 Fix to an error with very large strings in an array causing a failure in the XML conversion of simpleXML, fixes #500
Moved the XML conversion in restfullEventToServer() to MISP's own xml conversion tool
2015-07-08 10:37:20 +02:00
Iglocska e706562cd5 Fixes to the RPZ export based on the testing of elhoim
- some errors in the format (wrong comment character used, rpz-ip not appended to IP addresses, missing semi-colon)
- removed hostnames that are on domains blocked by the rules based on domain attributes
2015-07-07 14:42:28 +02:00
Iglocska 27cc167c33 Fix to an incorrect validation of temporary filenames 2015-07-01 11:06:11 +02:00
Iglocska 45fdbf7839 File management fixed in server settings
- a previous patch removed the contents of the page
2015-07-01 09:50:51 +02:00
Iglocska a05afbdd11 GnuPG.binary demoted to optional setting as it should be 2015-07-01 09:01:32 +02:00
Iglocska 341f1d52de Version bump 2015-07-01 08:45:01 +02:00
Iglocska 812ac878c3 Fix to XSS in the template creation process 2015-07-01 08:42:21 +02:00
Iglocska 415d85102d Security fix: Fix to a possible PHP Object injection
- unserialized user input replaced with json_decode
2015-07-01 08:38:40 +02:00
Iglocska ad5693e7e6 Version bump and debug code removed 2015-06-29 12:28:12 +02:00
Iglocska 96362bdb3d Fix for disabled fields causing issues with the security component fixes #555
- the disabled fields are no longer created via the form helper
2015-06-29 12:25:15 +02:00
Iglocska 3f215743f0 Complete rework of the ZeroMQ implementation
- python server running in the background doing the publishing
- MISP -> python script communication via redis
- configurable / controllable via the admin UI
2015-06-29 08:56:45 +02:00
Iglocska 73f2944793 Removed debug code 2015-06-25 14:23:27 +02:00
Iglocska 994c850a1c Several fixes
- added multi edit to freetext import comments
- added a missing file from hotfix-2.3.87 (pgp key import view)
- updated gitignore to ignore some items that are outside of the scope of the git package
2015-06-25 12:21:37 +02:00
Iglocska dc9fbf48d0 Proposal mass accept/discard, fixes #466 2015-06-25 11:51:36 +02:00
Iglocska df1c6b1961 Merge branch 'fix-stix-date-ranges' into hotfix-2.3.86
Conflicts:
	app/View/Events/automation.ctp
2015-06-24 17:50:26 +02:00
Iglocska 3d2b8c3c10 Added pub/sub feature using ZeroMQ, fixes #540 and fixes #526
- by installing the requirements described in the update and the install instructions (ubuntu only for now, centos/red-hat versions to be tested and described), administrators can enable the pub/sub feature
- assign a port to the service via the interface
- each time an event is published, MISP will use ZMQ's PUB feature to push out a MISP JSON package using the "misp_json" prefix
2015-06-24 17:38:15 +02:00
Iglocska c120c5bdd3 Some merge issues resolved 2015-06-23 17:21:19 +02:00
Iglocska ae0e1aeacb Merge branch 'feature/rpz' into hotfix-2.3.86
Conflicts:
	app/Console/Command/EventShell.php
	app/Model/Server.php
2015-06-23 17:19:08 +02:00
Iglocska 6135804afa Removed some junk 2015-06-23 11:00:53 +02:00
Iglocska ea0dd2a33f PGP key selection on fetch, fixes #554
- MISP will now fetch a list of all keys matching the e-mail address from the MIT server from the user edit view
- A popup will present all the matching keys (with the creation date, key ID, email addresses associated - and the fingerprint when hovering over them)
- Once the admin clicks on one, it will fetch the desired key

- future enhancement possibility: move the second stage (the actual key fetch) to the server side instead of a direct ajax query from the user's browser
2015-06-23 10:56:19 +02:00
Iglocska 0e09319eae Tuning of the complex type tool 2015-06-22 14:11:43 +02:00
iglocska a0afab66a7 Various changes and bug fixes
- contact reporter first tries to contact orgc users on the instance, if they don't exist, it will contact the owner (instead of going straight to the owner)
- hostname / domain name validation change broke validation of hostnames/domain names / email addresses with a "-"
- Some documentation changes for the REST API (more coming)
- some tuning of the freetext import
2015-06-18 14:49:25 +02:00
iglocska 3d51e34386 Small tweak to the email/domain/hostname validation, affects #551 2015-06-17 10:31:25 +02:00
iglocska 5820d899c0 Relaxed validation of tlds in domain/hostname/email-src/email-dst attributes to allow for longer custom tlds 2015-06-16 16:34:15 +02:00
Richard van den Berg cdd8ed0415 Move example to bottom of h3 2015-06-15 11:24:08 +02:00
Richard van den Berg 7a383e985d Fix bold and spacing 2015-06-15 11:20:50 +02:00
Richard van den Berg 7dc9fbfc1a Add/move missing tags examples 2015-06-15 11:13:03 +02:00
Richard van den Berg ccd6396081 Clarify the use of empty parameters in URL 2015-06-15 10:53:16 +02:00
Richard van den Berg 82e83555df Clarify more date formats 2015-06-15 10:43:37 +02:00
Richard van den Berg cfafdf040c Clarify date format 2015-06-15 10:36:22 +02:00
Richard van den Berg cc1744dd46 Add $from and $to to Event->stix() 2015-06-15 10:25:59 +02:00
Richard van den Berg 68615ffb23 dateFieldCheck actually expects YYYY-MM-DD 2015-06-15 10:06:46 +02:00
Iglocska 3c6f73e41c Some further cleanup / refactoring 2015-06-10 13:01:36 +02:00
Iglocska 707140243a Updated the documentation to reflect the correct STIX / CyBox versions required
- Updated the admin tool to check the STIX / Cybox versions
2015-06-10 12:47:00 +02:00
Iglocska 822172d425 Fixes to the e-mailer and the HIDS export
- HIDS exports did not include filename|hash types
- Sending a password reset / welcome message picked the opposite subject line
- line breaks were sent as literals.
2015-06-10 09:50:38 +02:00
David André b6c89061a3 Use innodb engine for cake sessions table 2015-06-10 07:09:42 +02:00
Iglocska 47d02845d2 Added the option to use an alternat executable for gpg, fixes #498
- users can specify an alternate gnupg executable
- Since GnuPG2 is not compatible with the last stable CryptGPG version, there are 3 options for CentOS / Red Hat users:
  1. Don't use a passphrase for the server's PGP key
  2. Install the beta version of CryptGPG (1.4.0b4)
  3. Install GnuPG classic and point MISP to the executable

- This patch enables option 3, administrators can point MISP to the alternate executable in the server settings
2015-06-09 13:04:33 +02:00
Iglocska a81f4a19ed Server setting changes logged, fixes #531 2015-06-09 09:55:22 +02:00
Iglocska f7afb01324 Documentation for the new export option added 2015-06-06 20:09:18 +02:00
Iglocska 71635b00a1 Added a new API parameter that allows to restrict events to the most recently published ones, #527
- added the new flag "last" to the list of parameters
- exports affected: XML, CSV, NIDS, HIDS, STIX, Text, RestSearch
- Valid values: number + format where format can be d, m, h for day, minute, hour (examples: 5d or 12h or 30m)
2015-06-06 20:00:57 +02:00
Iglocska 49e605db6d Tags sorted by name not ID, fixes #522
- Affected views: Tag index, event view tag attach dropdown
2015-06-05 15:34:21 +02:00
Iglocska 2b0a1e5c4e Fixed an issue with log entries being truncated (Requires administrator action!)
- added a new entry to the admin tools (Administartion -> Administrative tools)
- converts title and change columns in the logs table to text from varchar(255)
2015-06-05 15:24:26 +02:00
Iglocska b7ab62c337 Fix to non publish users being able to get around the restriction
- fixed an incorrect privilege check on the publish pop-up
2015-06-05 11:09:03 +02:00
Iglocska 1386fb627a Auth users should only be able to create events for their org
- Sync users should be able to create an event for another orgc, but auth users should not
- Fixed
2015-06-04 15:41:18 +02:00
Iglocska 4caf9b2d81 Freetext import tool now prunes duplicate values, fixes #517 2015-06-04 11:04:34 +02:00
Iglocska 0ca832887c Oversanitisation breaks links in attribute values, fixes #371 2015-06-04 10:52:38 +02:00
Iglocska b36c0da66a Timing for rescheduling of tasks changed slightly
- The rescheduling now happens before the task is executed - this way a failed job will not prevent the rescheduling of the next execution time
2015-06-03 23:49:37 +02:00
Iglocska b200cbb83a AJAX attribute creation would block a follow-up publish request, fixes #514
- Popover_form purged after the form has been submitted
- a duplicate hidden div was created for confirmation popups within the attribute creation popup and clicking publish populated the wrong div
2015-06-03 11:38:19 +02:00
Iglocska 17f4eecb2c Fixes issue with firefox not pasting the fetched PGP key, fixes #514 2015-06-03 11:28:20 +02:00
Iglocska ff46811386 Fixed the max width of the attribute value field, fixes #512 2015-06-02 12:47:58 +02:00
Iglocska 8b203324d7 Updated bootstrap datepicker, fixes #507 2015-06-02 12:31:27 +02:00
Iglocska fbd03a025d NIDS filename changes, fixes #509
- instead of misp.rules the filename becomes misp.format.eventid.rules where eventid is only set if a single event is exported
2015-06-02 12:10:14 +02:00
Iglocska d4b72bd0cc Disablerestalert setting clarified and default set to true, fixes 511 2015-06-02 12:06:32 +02:00
Iglocska 197e6a69cc Free text import tool tuning, fixes #510
- comma separated values now correctly parsed
- Ports in IP/url/link/domain/hostname now added as a comment
- virustotal now automatically recognised as external analysis / link
2015-06-02 12:02:07 +02:00
Iglocska b467f0a9a9 Events without attributes are now blocked from pull/push, fixes #476
- Events published / pushed will now refuse to sync if the situation arises where no attributes would be eligible to be synced
- Events pulled that contain no attributes will be thrown away
2015-06-01 17:45:50 +02:00
Aaron Kaplan d9ae3c19b8 Merge branch 'master' of https://github.com/MISP/MISP 2015-05-27 21:10:33 +02:00
iglocska 2fd600b44a Left of tuning of complex type tool in previous commit
- also, appcontroller now loads the security component, so that the blackhole override doesn't produce errors
2015-05-27 19:10:14 +02:00
iglocska 42841b59c1 Finished the e-mailing rework branch, fixes #505, fixes #504, fixes #502, fixes #499
- this commit is mostly here to capture what was changed in hotfix 2.3.69

- e-mailing completely reworked, all e-mails now flow through the same method
- that method will handle all encryption and the decisions whether to send e-mails unencrypted to users without an encryption key, whether to keep the body of the e-mail untruncated, etc
- all e-mails are now also logged here (including the reason of a potential failure)

- new server settings for default template messages for password resets / new user welcome messages

- admin e-mail interface reworked and org admins now also have access to the features

- password resets / new user for site and org admins (where applicable) - quickly reset the password of a user and alert them using the pre-defined reset template

=====

- Tuned the freetext import to really accept free-text. Let me know if you have any tips for tuning the detection further!

- it now breaks the passed string on whitespace and line-break and tries to resolve the rest. Filename resolution tightened to exclude anthing that starts or ends with a .
2015-05-27 18:27:53 +02:00
iglocska 3584e52ccf Blackhole message due to csrf replaced with something more obvious, fixes #504
- user will get an explanation of the csrf error and that going back and refreshing the form will fix it
- also, there is a link that will take the user to the baseurl (which will redirect to the login page if the csrf issue occured on the login page)
2015-05-27 18:22:51 +02:00
iglocska 620b7d1adb New emailer finished 2015-05-27 17:46:01 +02:00
iglocska ecf9facf07 Further progress 2015-05-25 20:54:10 +02:00
iglocska 3431d2cc0d Rework of the e-mailing, part 1
- Reworking the way e-mails are sent - all of it goes through a centralised e-mail method
- just pass the recipient, recipient encryption key collection, body, alternate body if the message cannot be encrypted, subject, reply to address and pgp key for reply to along and the method will do the rest

- encrypt if possible, check if sending without encryption is allowed, signing, adding attachment for reply to encryption key, using alternate sanitised body if it is enforced for accounts that cannot use encryption is all done in one place

- easy to maintain and expand with future changes (such as the S/MIME pull request on github)
2015-05-25 17:18:39 +02:00
iglocska 9b4974d394 Merge branch 'unencrypted' into hotfix-2.3.69 2015-05-25 10:25:25 +02:00
iglocska de50a99f44 Merge branch 'email-notifications' into hotfix-2.3.69 2015-05-25 10:24:04 +02:00
iglocska 5559536bf1 Freetext import tool now splits the input by line break and whitespace, fixes #502 2015-05-24 10:09:41 +02:00
iglocska 0cbedf5847 Date set to today's date by default, fixes #495 2015-05-21 14:21:09 +02:00
iglocska 2f27d374d1 Opened up the rpz API for automation 2015-05-20 16:37:49 +02:00
iglocska a0031a48e0 Merge branch 'master' into feature/rpz 2015-05-20 16:37:30 +02:00
iglocska 85e52810a4 Ignoring non MISP AUTHORIZATION headers, fixes #478
- Users being logged on would not be able to use the actions that are also used for automation
- Those actions trigger a check of the authorization header, which in certain use cases can be set with values that is outside of the scope of MISP

- MISP will now try to only detect MISP auth keys in the headers and if it detects something else it ignores it
2015-05-20 16:32:04 +02:00