Commit Graph

2022 Commits (35cd740b6e2fd169c2e1718fa789c546e03208a8)

Author SHA1 Message Date
iglocska afdcc1af0c Fixed a security issue with the CSRF protection being avoidable using some site admin functionality
- as discovered and reported by Egidio Romano of Minded Security

- Lacking checks of HTTP methods in some functionality could lead to a site admin uploading and executing malicious scripts

- Tightened HTTP method verification across the board for actions that modify data
- Turned some administrative tasks to POST only actions
2015-11-13 23:57:03 +01:00
iglocska a380458d2e Fixed a security issue with the site admin file uploader
- as discovered and reported by Egidio Romano of Minded Security

- The site admin file upload tool allowed for unrestricted file upload that could lead to RCE
- Fixed the file uploader to be much more restrictive
- removed the interactive terms file upload
2015-11-13 23:48:29 +01:00
iglocska 69031ab35e Fixed an issue where PGP keys that are set to never expire show up as expired 2015-11-12 09:46:33 +01:00
iglocska 675ceb2e0e Better verification of PGP keys
- checks whether the key can be used to encrypt and whether it's expired
2015-11-11 17:03:59 +01:00
iglocska 6548297b80 Merge branch 'hotfix-2.3.154' into hotfix-2.3.155
Conflicts:
	VERSION.json
2015-11-10 15:22:10 +01:00
iglocska 9f85c40145 Fix to a security issue
- as reported by RichieB2B
- Trying to view an event that doesn't exist and one that the user has no access to resulted in different error messages
2015-11-10 15:18:33 +01:00
iglocska c46922be12 Fix to a security issue in the PGP fetching tool
- reported by RichieB2B
- The scraped URL for the PGP fetching tool was not sanitised before being echoed
2015-11-10 15:17:15 +01:00
iglocska 0d758de89b Fixed an issue where a linebreak in an event info would break the CSV export, fixes #710
- also added comment field for attributes
- until now multi line fields were both escaped and the line breaks removed
  - this was overkill, linebreaks are now kept intact
2015-11-10 13:45:40 +01:00
iglocska 8f485ef98a Fixed a bug with the attribute search API 2015-11-09 23:18:51 +01:00
iglocska c83b1e2dd0 Fix to the CSV export, fixes #710 2015-11-08 22:56:00 +01:00
iglocska 16e7974fc0 Improved logging, fixes #695
- Added logging of failed login attempts
- Added (optional) logging of successful authentications
  - admin setting that has to be enabled
  - will log all API calls (both HTTP method and target url)

- optional logging of user IP address for all logs
  - each log entry created while this setting is enabled will log the IP address of the client
  - disabling it also hides the IPs from the interface
  - added new IP field for the log search (only if enabled)
2015-11-08 22:35:46 +01:00
iglocska 42ad040d3c Removed obsolete gitignore files, fixes #704 2015-11-03 17:06:21 +01:00
iglocska 4b24cf0c65 Documentation changes 2015-10-31 00:29:15 +01:00
iglocska 9c00d56ed4 View all proposals via the API
- Proposals that can be accepted / discarded via the API
- Can restrict the index to the proposals of a single event
2015-10-31 00:18:05 +01:00
iglocska 345e898f5f Tagging added to the API
- Create / Edit / Remove / index / view tags via the API
2015-10-30 16:28:51 +01:00
Iglocska 059a8aa43a Added API for proposals
- APIs for the following actions:
  - Add new proposed attribute to an event
  - Add proposed change to an attribute
  - View a proposal
  - Accept a proposal
  - Discard a proposal

- new APIs described on the automation page
2015-10-28 23:32:30 +01:00
Iglocska 80f29c1f33 More details on the PGP validation tool 2015-10-27 15:18:04 +01:00
Iglocska f9da3f2d2c Small fix to the pgp key validation tool
- doesn't break on completely invalid keys anymore
2015-10-27 14:00:31 +01:00
iglocska 7d651f094b Fix to a vulnerability found in attributescontroller
- vulnerability reported by Airbus Group CERT

- Deprecated ajax attribute view had inverse access control logic
- removed ajax path
- added XML/JSON view
2015-10-27 08:31:48 +01:00
iglocska 6fa27d659a Reverted change in proposal file storage path that wasn't needed 2015-10-22 09:51:31 +02:00
iglocska 26a4705bb3 Removed junk 2015-10-21 23:50:55 +02:00
iglocska 61e865956b Fixes to several issues, fixes #693
- Fixed a critical bug in the XML export
  - As of recently XML exports include relations as they were missing before
  - the sanitisation of the event info field in related attributes was incorrectly sanitized of unicode characters
  - this can lead to the XML export breaking and also for affected events to be blocked from synchronisation

- Proposal fixes
  - fixed an invalid uuid generation that lead to an exception
  - fixed the attachments for proposals still using the old attachment system that disallows most filenames
  - added the automatic creation of hashes for attachment proposals
2015-10-21 23:44:07 +02:00
Iglocska 4a358c9fee Removed junk 2015-10-15 17:44:33 +02:00
Iglocska 7fab2ce2be Added the attribute relations to the XML / JSON output, fixes #687 2015-10-15 17:39:17 +02:00
Iglocska 3dc83778c2 Fixed the current user check while removing dead workers, fixes #685
- as pointed out by RichieB2B
2015-10-14 15:07:29 +02:00
Iglocska c9bf8105e6 Replaced get_current_user for the process owner identification, fixes #685
- As RichieB2B noted, get_current_user() gets the owner of the script in CentOS / RHEL not the user executing the script (as in Ubuntu)

- Current solution uses posix_getpwuid and posix_geteuid if the php-posix package is installed
- if not, it uses whoami
2015-10-13 10:49:55 +02:00
Iglocska f9f9eed6fd Issue fixed with open_basedir preventing the worker diagnostics from working, fixes #685
- for some users the workers appeared to be dead even though the worker processes were functional and started by the correct user
- this was due to access to /proc being blocked by open_basedir directive settings
- added a check and the corresponding view changes to this being the case
2015-10-12 16:48:43 +02:00
Iglocska 24eae46640 Fix to a previous invalid check on the cakephp version 2015-10-09 20:51:12 +02:00
Iglocska f018c60c01 Fixed the worker diagnostics showing incorrect data under Red Hat / CentOS, fixes #685
- Under these distros, php is blocked from seeing concurrently running php processes even under the same user
- instead of running ps, the diagnostic now checks the existance of the pid file in /proc/
2015-10-09 17:09:33 +02:00
Iglocska 9223240efd Further fixes that caused issues with old PHP versions 2015-10-09 16:38:48 +02:00
Iglocska 00b74b43de Fixed a possible issue with the previous commit on certain php versions 2015-10-09 16:24:36 +02:00
Iglocska dc638adac2 Upgrade to CakePHP 2.7, fixes #684
- cakephp submodule updated to 2.7
- make sure that you update your instance!

- not updating will not break compatibility
2015-10-09 15:59:25 +02:00
Iglocska 3459661dc8 Left off view file 2015-10-09 10:07:12 +02:00
Iglocska f9d69393e8 Fix to an issue with the calendar and added view to help with gitbook page generation
- datepicker seems to bug out as of recently
  - misplaced popup that overlaps with the top bar
  - fixed by updating to a newer version of datepicker

- added a new view that generates a markdown version of the categories and types view, for easier gitbook generation
2015-10-08 10:00:42 +02:00
Iglocska 5f1196eba5 Fix to an issue that blocked event blacklist entries from being added manually, fixes #676 2015-09-24 11:26:23 +02:00
Iglocska 4a75b1d2b5 Fixed an issue where the recorrelation of all events would run into memory issues
- before the recorrelation admin tool would load all attributes into memory in one go
- now it loads them in chunks of 1k attributes at a time
2015-09-24 10:36:02 +02:00
Iglocska a55e38ffda Fix to the previous commit 2015-09-23 12:32:00 +02:00
Iglocska 6ef7772e0b Fixed an issue with old upgraded instances that didn't use the db session handler
- diagnostic tool would throw exceptions because the db session tables are still missing in some older instances
- if a different session handler is used, the test is skipped
2015-09-23 12:14:32 +02:00
Iglocska 4a16fb3941 Changed behaviour where REST delete returns the index on success, fixes #673
- REST delete of events lacked an API specific response
- simply redirected to the index

- it now returns eitehr "Event deleted" or "Event was not deleted" depending on the outcome
2015-09-22 19:41:24 +02:00
Raphaël Vinot b2876c6959 Update default version for cakephp, make sure PyMISP follows master 2015-09-22 17:36:41 +02:00
iglocska 6fa13b4ad0 Fix to the text export ignoring the rule to exclude unpublished and non-IDS flagged data, fixes #646 2015-09-18 10:53:03 +02:00
iglocska 3234aaf887 Fixes to the user index, fixes #556
- index can now be sorted case insensitive
- removed a notice error during sorting (sorting parameters should not be displayed as a filter)
2015-09-18 10:42:50 +02:00
iglocska f15fcf0584 Started admin FAQ section, added info on resetting a password using the command line, fixes #624 2015-09-18 10:23:55 +02:00
iglocska cfec8d65e4 Fix to an issue introduced in 2.3.128 that incorrectly causes MISP to not sync due to a version mismatch 2015-09-17 11:28:57 +02:00
iglocska 7f3996f43b Added an API to quickly check the current MISP version, fixes #664 2015-09-17 00:21:08 +02:00
iglocska 1d4e07d965 Merge branch 'master' of https://github.com/MISP/MISP 2015-09-16 19:07:21 +02:00
iglocska 1079c4a1ea Added a diagnostic to check and purge overgrown session tables 2015-09-16 18:55:28 +02:00
Raphaël Vinot 7b1155599b Fix #654
At least, I think so, please review :)
2015-09-16 16:04:12 +02:00
iglocska 14188f1367 Fix to a new bug introduced with the correlation engine
- an attribute could correlate with another attribut of the same event
2015-09-16 15:34:00 +02:00
iglocska b8fae35f34 Added ID in the response of the upload sample API
- it now also returns the ID of the created/updated event
2015-09-16 14:54:07 +02:00