MISP
/
PyMISP
mirror of https://github.com/MISP/PyMISP
2
0
Fork 0
Code Issues Releases Wiki Activity

fix: Properly strip value in MISPObject.add_attribute, take 2 

Fix #546
pull/591/head
Raphaël Vinot 2020-05-29 01:01:58 +02:00
parent 524aa13641
commit 74a5d04bda
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pymisp/mispevent.py
View File

@ -845,11 +845,15 @@ class MISPObject(AbstractMISP):
dictionary with all the keys supported by MISPAttribute""" dictionary with all the keys supported by MISPAttribute"""
if simple_value is not None: # /!\ The value *can* be 0 if simple_value is not None: # /!\ The value *can* be 0
value = {'value': simple_value} value = {'value': simple_value}
# Make sure we're not adding an empty value. if value.get('value') is None:
value['value'] = value['value'].strip() logger.warning("The value of the attribute you're trying to add is None, skipping it. Object relation: {}".format(object_relation))
if value.get('value') in [None, '']:
logger.warning("The value of the attribute you're trying to add is None or empty string, skipping it. Object relation: {}".format(object_relation))
return None return None
else:
# Make sure we're not adding an empty value.
value['value'] = value['value'].strip()
if value['value'] == '':
logger.warning("The value of the attribute you're trying to add is an empty string, skipping it. Object relation: {}".format(object_relation))
return None
if self._known_template and self._definition: if self._known_template and self._definition:
if object_relation in self._definition['attributes']: if object_relation in self._definition['attributes']:
attribute = MISPObjectAttribute(self._definition['attributes'][object_relation]) attribute = MISPObjectAttribute(self._definition['attributes'][object_relation])