MISP
/
PyMISP
mirror of https://github.com/MISP/PyMISP
2
0
Fork 0
Code Issues Releases Wiki Activity

fix: Big speed improvment when loading MISPEvent 

1. `properties` is a list comprehension
2. Massively reduce the amount of calls to `properties`
pull/470/head
Raphaël Vinot 2019-10-02 22:45:12 -07:00
parent 86c2357a5d
commit a2b66e943b
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pymisp/abstract.py
View File

@ -107,12 +107,7 @@ class AbstractMISP(MutableMapping):
"""All the class public properties that will be dumped in the dictionary, and the JSON export.
Note: all the properties starting with a `_` (private), or listed in __not_jsonable will be skipped.
"""
to_return = []
for prop, value in vars(self).items():
if prop.startswith('_') or prop in self.__not_jsonable:
continue
to_return.append(prop)
return to_return
return [k for k in vars(self).keys() if not (k[0] == '_' or k in self.__not_jsonable)]
def from_dict(self, **kwargs):
"""Loading all the parameters as class properties, if they aren't `None`.
@ -216,7 +211,8 @@ class AbstractMISP(MutableMapping):
raise Exception('edited can only be True or False')
def __setattr__(self, name, value):
if name in self.properties:
if name != '_AbstractMISP__edited':
if not self.__edited and name in self.properties:
self.__edited = True
super(AbstractMISP, self).__setattr__(name, value)