From c39328f30a58b3ce1cb8482c22066d4d75556949 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Vinot?= Date: Tue, 15 Sep 2020 17:01:56 +0200 Subject: [PATCH] fix: Do not modify default_attributes_parameters in MISPObject --- pymisp/mispevent.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pymisp/mispevent.py b/pymisp/mispevent.py index c424165..40002e3 100644 --- a/pymisp/mispevent.py +++ b/pymisp/mispevent.py @@ -1,6 +1,7 @@ # -*- coding: utf-8 -*- from datetime import timezone, datetime, date +import copy import json import os import base64 @@ -603,7 +604,7 @@ class MISPObject(AbstractMISP): 'sharing_group_id', 'comment', 'first_seen', 'last_seen', 'deleted'} - def __init__(self, name: str, strict: bool = False, standalone: bool = True, default_attributes_parameters: dict = {}, **kwargs): + def __init__(self, name: str, strict: bool = False, standalone: bool = True, default_attributes_parameters: Dict = {}, **kwargs): ''' Master class representing a generic MISP object :name: Name of the object @@ -637,7 +638,7 @@ class MISPObject(AbstractMISP): # Just make sure we're not modifying an existing MISPAttribute self._default_attributes_parameters = default_attributes_parameters.to_dict() else: - self._default_attributes_parameters = default_attributes_parameters + self._default_attributes_parameters = copy.copy(default_attributes_parameters) if self._default_attributes_parameters: # Let's clean that up self._default_attributes_parameters.pop('value', None) # duh