MISP
/
PyMISP
mirror of https://github.com/MISP/PyMISP
2
0
Fork 0
Code Issues Releases Wiki Activity

Remove unicode to ascii parts

pull/789/head
Sami Tainio 2021-09-28 16:42:15 +03:00 committed by GitHub
parent 2fb354a938
commit f6c8e2ad0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pymisp/tools/emailobject.py
View File

@ -251,16 +251,6 @@ class EMailObject(AbstractMISPObjectGenerator):
pass
return to_return
def unicode_to_ascii(self, arg):
"""
This function removes unicode characters and returns an ASCII string.
Spam messages commonly contain unicode encoded emojis which MISP cannot
handle. Those would either cause an error or show up as "?" in the UI.
"""
string_encode = arg.encode("ascii", "ignore")
string_decode = string_encode.decode()
return string_decode
def generate_attributes(self):
# Attach original & Converted
@ -296,8 +286,7 @@ class EMailObject(AbstractMISPObjectGenerator):
self.__add_emails("to", message["Delivered-To"])
if "From" in message:
from_ascii = self.unicode_to_ascii(message["From"])
self.__add_emails("from", from_ascii)
self.__add_emails("from", message["From"])
if "Return-Path" in message:
realname, address = email.utils.parseaddr(message["Return-Path"])
@ -310,8 +299,7 @@ class EMailObject(AbstractMISPObjectGenerator):
self.__add_emails("cc", message["Cc"])
if "Subject" in message:
subject_ascii = self.unicode_to_ascii(message["Subject"])
self.add_attribute("subject", subject_ascii)
self.add_attribute("subject", message["Subject"])
if "Message-ID" in message:
self.add_attribute("message-id", message["Message-ID"])