From 54f5fa6fa92b6410f343ab8f6430d23f6a419802 Mon Sep 17 00:00:00 2001 From: chrisr3d Date: Mon, 20 May 2019 09:19:38 +0200 Subject: [PATCH] fix: Avoiding dictionary indexes issues - Using tuples as a dictionary indexes is better than using generators... --- misp_modules/modules/import_mod/joe_import.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misp_modules/modules/import_mod/joe_import.py b/misp_modules/modules/import_mod/joe_import.py index 0b854e3..614d430 100644 --- a/misp_modules/modules/import_mod/joe_import.py +++ b/misp_modules/modules/import_mod/joe_import.py @@ -91,7 +91,7 @@ class JoeParser(): connections = defaultdict(list) for packet in network[protocol]['packet']: timestamp = self.parse_timestamp(packet['timestamp']) - connections[(packet[field] for field in fields)].append(datetime.strptime(timestamp, '%B %d, %Y %H:%M:%S.%f')) + connections[tuple(packet[field] for field in fields)].append(datetime.strptime(timestamp, '%B %d, %Y %H:%M:%S.%f')) for connection, timestamps in connections.items(): network_connection_object = MISPObject('network-connection') for field, value in zip(fields, connection):