From 729c86c3363e41964af8521505b2687f270bf33b Mon Sep 17 00:00:00 2001 From: chrisr3d Date: Mon, 22 Jul 2019 09:16:04 +0200 Subject: [PATCH] fix: Quick fix on siblings & url parsing --- misp_modules/modules/expansion/virustotal_public.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/misp_modules/modules/expansion/virustotal_public.py b/misp_modules/modules/expansion/virustotal_public.py index 619e3cd..12c73d5 100644 --- a/misp_modules/modules/expansion/virustotal_public.py +++ b/misp_modules/modules/expansion/virustotal_public.py @@ -29,9 +29,10 @@ class VirusTotalParser(): def parse_urls(self, query_result): for feature in ('detected_urls', 'undetected_urls'): - for url in query_result[feature]: - value = url['url'] if isinstance(url, dict) else url - self.misp_event.add_attribute('url', value) + if feature in query_result: + for url in query_result[feature]: + value = url['url'] if isinstance(url, dict) else url + self.misp_event.add_attribute('url', value) def parse_resolutions(self, resolutions, subdomains=None, uuids=None): domain_ip_object = MISPObject('domain-ip') @@ -87,9 +88,9 @@ class DomainQuery(VirusTotalParser): self.parse_resolutions(query_result['resolutions'], query_result['subdomains'], siblings) self.parse_urls(query_result) - def parse_siblings(domain): + def parse_siblings(self, domain): attribute = MISPAttribute() - attribute.from_dict(dict(type='domain', value=domain)) + attribute.from_dict(**dict(type='domain', value=domain)) self.misp_event.add_attribute(**attribute) return attribute.uuid