From 90a1644c8cbea8439e1e95a75fcc51ef3a8841ff Mon Sep 17 00:00:00 2001 From: chrisr3d Date: Wed, 10 Aug 2022 14:07:00 +0200 Subject: [PATCH] fix: [shodan] Fixed wrong asset used to add attribute to - This caused the input `ip-src` or `ip-dst` input attribute to be added to the `ip-api-addres` which does not have these attributes in their template, where they should be added to the Event instead --- misp_modules/modules/expansion/shodan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misp_modules/modules/expansion/shodan.py b/misp_modules/modules/expansion/shodan.py index f295deb..356abc5 100755 --- a/misp_modules/modules/expansion/shodan.py +++ b/misp_modules/modules/expansion/shodan.py @@ -73,7 +73,7 @@ class ShodanParser(): ip_address_object = MISPObject('ip-api-address') for attribute in ip_address_attributes: ip_address_object.add_attribute(**attribute) - ip_address_object.add_attribute(**self._get_source_attribute()) + self.misp_event.add_attribute(**self._get_source_attribute()) ip_address_object.add_reference(self.attribute.uuid, 'describes') self.misp_event.add_object(ip_address_object)