From 0f5532b2a1dcf1698f3d46caa9a0ff027630a667 Mon Sep 17 00:00:00 2001 From: Sid Odgers Date: Fri, 13 Oct 2023 15:59:27 +1100 Subject: [PATCH] Rename `files_iterator` and related variables to avoid overwriting `file_object` in virustotal enrichments --- misp_modules/modules/expansion/virustotal.py | 10 +++++----- misp_modules/modules/expansion/virustotal_public.py | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/misp_modules/modules/expansion/virustotal.py b/misp_modules/modules/expansion/virustotal.py index 2d9e714..93d0966 100644 --- a/misp_modules/modules/expansion/virustotal.py +++ b/misp_modules/modules/expansion/virustotal.py @@ -153,11 +153,11 @@ class VirusTotalParser: ('contacted_domains', 'communicates-with'), ('contacted_ips', 'communicates-with') ]: - files_iterator = self.client.iterator(f'/files/{file_report.id}/{relationship_name}', limit=self.limit) - for file in files_iterator: - file_object = self.create_misp_object(file) - file_object.add_reference(file_object.uuid, misp_name) - self.misp_event.add_object(**file_object) + related_files_iterator = self.client.iterator(f'/files/{file_report.id}/{relationship_name}', limit=self.limit) + for related_file in related_files_iterator: + related_file_object = self.create_misp_object(related_file) + related_file_object.add_reference(file_object.uuid, misp_name) + self.misp_event.add_object(**related_file_object) self.misp_event.add_object(**file_object) return file_object.uuid diff --git a/misp_modules/modules/expansion/virustotal_public.py b/misp_modules/modules/expansion/virustotal_public.py index f5bb76b..dba60fa 100644 --- a/misp_modules/modules/expansion/virustotal_public.py +++ b/misp_modules/modules/expansion/virustotal_public.py @@ -138,11 +138,11 @@ class VirusTotalParser: ('contacted_domains', 'communicates-with'), ('contacted_ips', 'communicates-with') ]: - files_iterator = self.client.iterator(f'/files/{file_report.id}/{relationship_name}', limit=self.limit) - for file in files_iterator: - file_object = self.create_misp_object(file) - file_object.add_reference(file_object.uuid, misp_name) - self.misp_event.add_object(**file_object) + related_files_iterator = self.client.iterator(f'/files/{file_report.id}/{relationship_name}', limit=self.limit) + for related_file in related_files_iterator: + related_file_object = self.create_misp_object(related_file) + related_file_object.add_reference(file_object.uuid, misp_name) + self.misp_event.add_object(**related_file_object) self.misp_event.add_object(**file_object) return file_object.uuid