From bc0c7c7d7d0a36f3bddd450e4d6064d88040fbbb Mon Sep 17 00:00:00 2001 From: chrisr3d Date: Tue, 15 Oct 2019 14:41:38 +0200 Subject: [PATCH] fix: Catching wikidata errors properly + fixed errors parsing --- tests/test_expansions.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_expansions.py b/tests/test_expansions.py index df5db40..6cfe953 100644 --- a/tests/test_expansions.py +++ b/tests/test_expansions.py @@ -18,7 +18,7 @@ class TestExpansions(unittest.TestCase): def misp_modules_post(self, query): return requests.post(urljoin(self.url, "query"), json=query) - def get_errors(self, reponse): + def get_errors(self, response): data = response.json() if not isinstance(data, dict): print(json.dumps(data, indent=2)) @@ -136,6 +136,8 @@ class TestExpansions(unittest.TestCase): response = self.misp_modules_post(query) try: self.assertEqual(self.get_values(response), 'http://www.wikidata.org/entity/Q95') + except KeyError: + self.assertEqual(self.get_errors(response), 'Something went wrong, look in the server logs for details') except Exception: self.assertEqual(self.get_values(response), 'No additional data found on Wikidata')