From 23ab7351199fbdfa521a99a0fc4ef066188ebc9e Mon Sep 17 00:00:00 2001
From: haxpak <haxpak@gmail.com>
Date: Sat, 13 Apr 2019 13:32:56 +0530
Subject: [PATCH] - added : attachment attribute to annotation - added : new
 object type device

---
 objects/annotation/definition.json   |  8 +++-
 objects/device/definition.json       | 61 ++++++++++++++++++++++++++++
 objects/organization/definition.json |  8 ++--
 3 files changed, 72 insertions(+), 5 deletions(-)
 create mode 100644 objects/device/definition.json

diff --git a/objects/annotation/definition.json b/objects/annotation/definition.json
index d062eca..2231bbc 100644
--- a/objects/annotation/definition.json
+++ b/objects/annotation/definition.json
@@ -61,7 +61,13 @@
       "description": "Last update of the annotation",
       "ui-priority": 0,
       "misp-attribute": "datetime"
-    }
+    },
+    "attachment" : {
+      "description" : "An attachment to support the annotation",
+      "ui-priority" : 0,
+      "misp-attribute": "attachment",
+      "multiple" : true
+    },
   },
   "version": 2,
   "description": "An annotation object allowing analysts to add annotations, comments, executive summary to a MISP event, objects or attributes.",
diff --git a/objects/device/definition.json b/objects/device/definition.json
new file mode 100644
index 0000000..dbe58ad
--- /dev/null
+++ b/objects/device/definition.json
@@ -0,0 +1,61 @@
+{
+  "requiredOneOf": [
+    "name"
+  ],
+  "attributes": {
+    "description": {
+      "description": "Description of the Device",
+      "ui-priority": 0,
+      "misp-attribute": "text",
+      "disable_correlation" : true
+    },
+    "name" : {
+      "description" : "Name of the Device",
+      "ui-priority" : 101,
+      "misp-attribute" : "text",
+    },
+    "alias" : {
+      "description" : "Alias of the Device",
+      "ui-priority" : 100,
+      "misp-attribute" : "text",
+      "multiple" : true
+    },
+    "device-type": {
+      "description": "Type of the device",
+      "ui-priority": 99,
+      "misp-attribute": "text",
+      "disable_correlation": true,
+      "categories": [
+        "PC",
+        "Mobile",
+        "Laptop",
+        "HID",
+        "TV",
+        "IoT",
+        "Hardware",
+        "Other"
+      ]
+    },
+    "ip-address": {
+      "description": "Device IP address",
+      "ui-priority": 0,
+      "misp-attribute": "ip-src"
+    },
+    "analysis-date": {
+      "description": "Date of device analysis",
+      "ui-priority": 0,
+      "misp-attribute": "datetime"
+    },
+    "attachment" : {
+      "description" : "An attachment",
+      "ui-priority" : 0,
+      "misp-attribute": "attachment",
+      "multiple" : true
+    },
+  },
+  "version": 3,
+  "description": "An object to define a device",
+  "meta-category": "device",
+  "uuid": "0c64b41a-e583-4f4d-ac92-d484163b9e52",
+  "name": "Device"
+}
diff --git a/objects/organization/definition.json b/objects/organization/definition.json
index 4d8bac1..b14bafc 100644
--- a/objects/organization/definition.json
+++ b/objects/organization/definition.json
@@ -55,7 +55,7 @@
     },
 
     "role": {
-      "description": "The role of a person.",
+      "description": "The role of the organization.",
       "ui-priority": 0,
       "misp-attribute": "text",
       "multiple": true,
@@ -71,9 +71,9 @@
       "disable_correlation": true
     }
   },
-  "version": 10,
-  "description": "An object which describes a person or an identity.",
+  "version": 1,
+  "description": "An object which describes an organization.",
   "meta-category": "organization",
-  "uuid": "ec8f8ca1-7f82-4d79-a9d0-2254303de686",
+  "uuid": "f750e12b-127a-432c-b022-b3f9153c4e2a",
   "name": "organization"
 }