From cce77727d6544ee44c9a2bd64bb69cd9dfaf5c7b Mon Sep 17 00:00:00 2001
From: Alexandre Dulaunoy <a@foo.be>
Date: Sun, 5 May 2019 12:31:41 +0200
Subject: [PATCH] chg: [x509] improve X.509 certificate description to match
 required ones from LIEF (as discussed in #180).

---
 objects/x509/definition.json | 35 +++++++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 10 deletions(-)

diff --git a/objects/x509/definition.json b/objects/x509/definition.json
index 42ecb04..2822cd3 100644
--- a/objects/x509/definition.json
+++ b/objects/x509/definition.json
@@ -15,12 +15,14 @@
     "pubkey-info-algorithm": {
       "description": "Algorithm of the public key",
       "ui-priority": 0,
-      "misp-attribute": "text"
+      "misp-attribute": "text",
+      "disable_correlation": true
     },
     "pubkey-info-size": {
       "description": "Length of the public key (in bits)",
       "ui-priority": 0,
-      "misp-attribute": "text"
+      "misp-attribute": "text",
+      "disable_correlation": true
     },
     "pubkey-info-exponent": {
       "description": "Exponent of the public key",
@@ -60,24 +62,27 @@
       "misp-attribute": "text"
     },
     "text": {
-      "description": "Free text description of hte certificate",
+      "description": "Free text description of the certificate",
       "ui-priority": 1,
       "misp-attribute": "text"
     },
     "validity-not-before": {
       "description": "Certificate invalid before that date",
       "ui-priority": 0,
-      "misp-attribute": "datetime"
+      "misp-attribute": "datetime",
+      "disable_correlation": true
     },
     "validity-not-after": {
       "description": "Certificate invalid after that date",
       "ui-priority": 0,
-      "misp-attribute": "datetime"
+      "misp-attribute": "datetime",
+      "disable_correlation": true
     },
     "issuer": {
       "description": "Issuer of the certificate",
       "ui-priority": 0,
-      "misp-attribute": "text"
+      "misp-attribute": "text",
+      "disable_correlation": true
     },
     "serial-number": {
       "description": "Serial number of the certificate",
@@ -87,26 +92,36 @@
     "version": {
       "description": "Version of the certificate",
       "ui-priority": 0,
-      "misp-attribute": "text"
+      "misp-attribute": "text",
+      "disable_correlation": true
     },
     "self_signed": {
       "description": "Self-signed certificate",
       "ui-priority": 0,
-      "misp-attribute": "boolean"
+      "misp-attribute": "boolean",
+      "disable_correlation": true
     },
     "is_ca": {
       "description": "CA certificate",
       "ui-priority": 0,
-      "misp-attribute": "boolean"
+      "misp-attribute": "boolean",
+      "disable_correlation": true
     },
     "dns_names": {
       "description": "DNS names",
       "multiple": true,
       "misp-attribute": "text",
       "ui-priority": 0
+    },
+    "signature_algorithm": {
+      "description": "Signature algorithm",
+      "misp-attribute": "text",
+      "ui-priority": 0,
+      "disable_correlation": true,
+      "sane_default": ["SHA1_WITH_RSA_ENCRYPTION","SHA256_WITH_RSA_ENCRYPTION"]
     }
   },
-  "version": 8,
+  "version": 9,
   "description": "x509 object describing a X.509 certificate",
   "meta-category": "network",
   "uuid": "d1ab756a-26b5-4349-9f43-765630f0911c",