Compare commits

...

10 Commits

Author SHA1 Message Date
Alexandre Dulaunoy fc4a005632
Merge pull request #43 from 0xThiebaut/patch-5
Correct `Object Reference`'s `object_id` attribute presence
2022-02-05 21:21:12 +01:00
Alexandre Dulaunoy d702e1af78
Merge pull request #44 from 0xThiebaut/patch-6
Correct `Object Reference`'s `relationship_type` attribute presence
2022-02-05 21:20:00 +01:00
Alexandre Dulaunoy b8cca65cc0
Merge pull request #41 from 0xThiebaut/patch-4
Correct `Object`'s `deleted` attribute
2022-02-05 21:18:42 +01:00
Alexandre Dulaunoy bc0a5c7287
Merge pull request #40 from 0xThiebaut/patch-3
Correct `Object`'s `template_uuid` and `template_version` attributes
2022-02-05 21:15:57 +01:00
Alexandre Dulaunoy 95281e4fbd
Merge pull request #39 from 0xThiebaut/patch-1
Correct `Object`'s `description` attribute presence
2022-02-05 21:14:52 +01:00
Maxime Thiebaut 32863e6274
Correct `Object Reference`'s `relationship_type` attribute presence
Correct `Object Reference`'s `relationship_type` attribute presence by changing references from `referenced_type` to `relationship_type`.
2022-02-05 20:16:27 +01:00
Maxime Thiebaut e1d316987a
Correct `Object Reference`'s `object_id` attribute presence
Correct `Object Reference`'s `object_id` attribute presence by changing references from `event_id` to `object_id`.
2022-02-05 20:05:13 +01:00
Maxime Thiebaut 0f5ae3ce82
Correct `Object`'s `deleted` attribute
Correct `Object`'s `deleted` attribute by referencing to the `object` and not the `attribute`.
2022-02-05 19:21:54 +01:00
Maxime Thiebaut 2eae5b9a65
Correct `Object`'s `template_uuid` and `template_version` attributes
Correct `Object`'s `template_uuid` and `template_version` attributes by adding a missing presence clause.

The clause was set to `MUST` as per the `Object` definition:

> A MISP document containing an Object **MUST** contain a name, a meta-category, a description, a template_uuid and a template_version as described in the "Object Attributes" section.

Furthermore, the attribute descriptions lacked the full attribute name as `template_uuid` and `template_version` were respectively referred to as `uuid` and `version`, causing a collision with the already defined `uuid` attribute of the `Object`.
2022-02-05 19:05:40 +01:00
Maxime Thiebaut 1da6baa570
Correct `Object`'s `description` attribute presence
The  `Object`'s `description` attribute presence incorrectly refers to the attribute as `id` while it should be `description`.
2022-02-05 18:51:31 +01:00
1 changed files with 10 additions and 8 deletions

View File

@ -752,32 +752,34 @@ id is represented as a JSON string. id **SHALL** be present.
name represents the human-readable name of the object describing the intent of the object package.
name is represented as a JSON string. name **MUST** be present
name is represented as a JSON string. name **MUST** be present.
#### meta-category
meta-category represents the sub-category of objects that the given object belongs to. meta-categories are not
tied to a fixed list of options but can be created on the fly.
meta-category is represented as a JSON string. meta-category **MUST** be present
meta-category is represented as a JSON string. meta-category **MUST** be present.
#### description
description is a human-readable description of the given object type, as derived from the template used for creation.
description is represented as a JSON string. id **SHALL** be present.
description is represented as a JSON string. description **SHALL** be present.
#### template\_uuid
uuid represents the Universally Unique IDentifier (UUID) [@!RFC4122] of the template used to create the object. The uuid **MUST** be preserved
template_uuid represents the Universally Unique IDentifier (UUID) [@!RFC4122] of the template used to create the object. The uuid **MUST** be preserved
to preserve the object's association with the correct template used for creation. UUID version 4 is **RECOMMENDED** when assigning it to a new object.
template_uuid is represented as a JSON string. template_uuid **MUST** be present.
#### template\_version
template_version represents a numeric incrementing version of the template used to create the object. It is used to associate the object to the
correct version of the template and together with the template_uuid forms an association to the correct template type and version.
version is represented as a JSON string. version **MUST** be present.
template_version is represented as a JSON string. template_version **MUST** be present.
#### event\_id
@ -827,7 +829,7 @@ comment is represented by a JSON string. comment **MAY** be present.
#### deleted
deleted represents a setting that allows attributes to be revoked. Revoked attributes are not actionable and exist merely to inform other instances of a revocation.
deleted represents a setting that allows objects to be revoked. Revoked objects are not actionable and exist merely to inform other instances of a revocation.
deleted is represented by a JSON boolean. deleted **MUST** be present.
@ -900,7 +902,7 @@ timestamp is represented as a JSON string. timestamp **MUST** be present.
object_id represents the human-readable identifier of the object that the object reference belongs to on a specific MISP instance. A human-readable identifier **MUST** be
represented as an unsigned integer.
event_id is represented as a JSON string. event_id **SHALL** be present.
object_id is represented as a JSON string. object_id **SHALL** be present.
#### event_id
@ -925,7 +927,7 @@ referenced_type is represented as a JSON string. referenced_type **MAY** be pres
relationship_type represents the human-readable context of the relationship between an object and another object or attribute as described by the object_reference.
referenced_type is represented as a JSON string. relationship_type **MUST** be present.
relationship_type is represented as a JSON string. relationship_type **MUST** be present.
#### comment