2021-11-09 14:10:58 +01:00
|
|
|
# Copyright 2021 The Matrix.org Foundation C.I.C.
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
|
|
|
from typing import List
|
|
|
|
|
2022-12-09 18:36:32 +01:00
|
|
|
from twisted.test.proto_helpers import MemoryReactor
|
|
|
|
|
2023-02-14 20:03:35 +01:00
|
|
|
from synapse.api.constants import Direction, EventTypes, RelationTypes
|
2021-11-09 14:10:58 +01:00
|
|
|
from synapse.api.filtering import Filter
|
|
|
|
from synapse.rest import admin
|
|
|
|
from synapse.rest.client import login, room
|
2022-12-09 18:36:32 +01:00
|
|
|
from synapse.server import HomeServer
|
2021-11-09 14:10:58 +01:00
|
|
|
from synapse.types import JsonDict
|
2022-12-09 18:36:32 +01:00
|
|
|
from synapse.util import Clock
|
2021-11-09 14:10:58 +01:00
|
|
|
|
|
|
|
from tests.unittest import HomeserverTestCase
|
|
|
|
|
|
|
|
|
|
|
|
class PaginationTestCase(HomeserverTestCase):
|
|
|
|
"""
|
|
|
|
Test the pre-filtering done in the pagination code.
|
|
|
|
|
|
|
|
This is similar to some of the tests in tests.rest.client.test_rooms but here
|
|
|
|
we ensure that the filtering done in the database is applied successfully.
|
|
|
|
"""
|
|
|
|
|
|
|
|
servlets = [
|
|
|
|
admin.register_servlets_for_client_rest_resource,
|
|
|
|
room.register_servlets,
|
|
|
|
login.register_servlets,
|
|
|
|
]
|
|
|
|
|
2022-12-09 18:36:32 +01:00
|
|
|
def default_config(self) -> JsonDict:
|
2021-11-09 14:10:58 +01:00
|
|
|
config = super().default_config()
|
2022-10-17 17:32:11 +02:00
|
|
|
config["experimental_features"] = {"msc3874_enabled": True}
|
2021-11-09 14:10:58 +01:00
|
|
|
return config
|
|
|
|
|
2022-12-09 18:36:32 +01:00
|
|
|
def prepare(
|
|
|
|
self, reactor: MemoryReactor, clock: Clock, homeserver: HomeServer
|
|
|
|
) -> None:
|
2021-11-09 14:10:58 +01:00
|
|
|
self.user_id = self.register_user("test", "test")
|
|
|
|
self.tok = self.login("test", "test")
|
|
|
|
self.room_id = self.helper.create_room_as(self.user_id, tok=self.tok)
|
|
|
|
|
|
|
|
self.second_user_id = self.register_user("second", "test")
|
|
|
|
self.second_tok = self.login("second", "test")
|
|
|
|
self.helper.join(
|
|
|
|
room=self.room_id, user=self.second_user_id, tok=self.second_tok
|
|
|
|
)
|
|
|
|
|
|
|
|
self.third_user_id = self.register_user("third", "test")
|
|
|
|
self.third_tok = self.login("third", "test")
|
|
|
|
self.helper.join(room=self.room_id, user=self.third_user_id, tok=self.third_tok)
|
|
|
|
|
2022-10-17 17:32:11 +02:00
|
|
|
# Store a token which is after all the room creation events.
|
|
|
|
self.from_token = self.get_success(
|
|
|
|
self.hs.get_event_sources().get_current_token_for_pagination(self.room_id)
|
|
|
|
)
|
|
|
|
|
2021-11-09 14:10:58 +01:00
|
|
|
# An initial event with a relation from second user.
|
|
|
|
res = self.helper.send_event(
|
|
|
|
room_id=self.room_id,
|
|
|
|
type=EventTypes.Message,
|
|
|
|
content={"msgtype": "m.text", "body": "Message 1"},
|
|
|
|
tok=self.tok,
|
|
|
|
)
|
|
|
|
self.event_id_1 = res["event_id"]
|
2022-10-17 17:32:11 +02:00
|
|
|
res = self.helper.send_event(
|
2021-11-09 14:10:58 +01:00
|
|
|
room_id=self.room_id,
|
|
|
|
type="m.reaction",
|
|
|
|
content={
|
|
|
|
"m.relates_to": {
|
|
|
|
"rel_type": RelationTypes.ANNOTATION,
|
|
|
|
"event_id": self.event_id_1,
|
|
|
|
"key": "👍",
|
|
|
|
}
|
|
|
|
},
|
|
|
|
tok=self.second_tok,
|
|
|
|
)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.event_id_annotation = res["event_id"]
|
2021-11-09 14:10:58 +01:00
|
|
|
|
|
|
|
# Another event with a relation from third user.
|
|
|
|
res = self.helper.send_event(
|
|
|
|
room_id=self.room_id,
|
|
|
|
type=EventTypes.Message,
|
|
|
|
content={"msgtype": "m.text", "body": "Message 2"},
|
|
|
|
tok=self.tok,
|
|
|
|
)
|
|
|
|
self.event_id_2 = res["event_id"]
|
2022-10-17 17:32:11 +02:00
|
|
|
res = self.helper.send_event(
|
2021-11-09 14:10:58 +01:00
|
|
|
room_id=self.room_id,
|
|
|
|
type="m.reaction",
|
|
|
|
content={
|
|
|
|
"m.relates_to": {
|
|
|
|
"rel_type": RelationTypes.REFERENCE,
|
|
|
|
"event_id": self.event_id_2,
|
|
|
|
}
|
|
|
|
},
|
|
|
|
tok=self.third_tok,
|
|
|
|
)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.event_id_reference = res["event_id"]
|
2021-11-09 14:10:58 +01:00
|
|
|
|
|
|
|
# An event with no relations.
|
2022-10-17 17:32:11 +02:00
|
|
|
res = self.helper.send_event(
|
2021-11-09 14:10:58 +01:00
|
|
|
room_id=self.room_id,
|
|
|
|
type=EventTypes.Message,
|
|
|
|
content={"msgtype": "m.text", "body": "No relations"},
|
|
|
|
tok=self.tok,
|
|
|
|
)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.event_id_none = res["event_id"]
|
2021-11-09 14:10:58 +01:00
|
|
|
|
2022-10-17 17:32:11 +02:00
|
|
|
def _filter_messages(self, filter: JsonDict) -> List[str]:
|
2021-11-09 14:10:58 +01:00
|
|
|
"""Make a request to /messages with a filter, returns the chunk of events."""
|
|
|
|
|
|
|
|
events, next_key = self.get_success(
|
2022-02-23 12:04:02 +01:00
|
|
|
self.hs.get_datastores().main.paginate_room_events(
|
2021-11-09 14:10:58 +01:00
|
|
|
room_id=self.room_id,
|
2022-10-17 17:32:11 +02:00
|
|
|
from_key=self.from_token.room_key,
|
2021-11-09 14:10:58 +01:00
|
|
|
to_key=None,
|
2023-02-14 20:03:35 +01:00
|
|
|
direction=Direction.FORWARDS,
|
2021-11-09 14:10:58 +01:00
|
|
|
limit=10,
|
|
|
|
event_filter=Filter(self.hs, filter),
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
2022-10-17 17:32:11 +02:00
|
|
|
return [ev.event_id for ev in events]
|
2021-11-09 14:10:58 +01:00
|
|
|
|
2022-12-09 18:36:32 +01:00
|
|
|
def test_filter_relation_senders(self) -> None:
|
2021-11-09 14:10:58 +01:00
|
|
|
# Messages which second user reacted to.
|
2022-03-10 16:36:13 +01:00
|
|
|
filter = {"related_by_senders": [self.second_user_id]}
|
2021-11-09 14:10:58 +01:00
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertEqual(chunk, [self.event_id_1])
|
2021-11-09 14:10:58 +01:00
|
|
|
|
|
|
|
# Messages which third user reacted to.
|
2022-03-10 16:36:13 +01:00
|
|
|
filter = {"related_by_senders": [self.third_user_id]}
|
2021-11-09 14:10:58 +01:00
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertEqual(chunk, [self.event_id_2])
|
2021-11-09 14:10:58 +01:00
|
|
|
|
|
|
|
# Messages which either user reacted to.
|
2022-03-10 16:36:13 +01:00
|
|
|
filter = {"related_by_senders": [self.second_user_id, self.third_user_id]}
|
2021-11-09 14:10:58 +01:00
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertCountEqual(chunk, [self.event_id_1, self.event_id_2])
|
2021-11-09 14:10:58 +01:00
|
|
|
|
2022-12-09 18:36:32 +01:00
|
|
|
def test_filter_relation_type(self) -> None:
|
2021-11-09 14:10:58 +01:00
|
|
|
# Messages which have annotations.
|
2022-03-10 16:36:13 +01:00
|
|
|
filter = {"related_by_rel_types": [RelationTypes.ANNOTATION]}
|
2021-11-09 14:10:58 +01:00
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertEqual(chunk, [self.event_id_1])
|
2021-11-09 14:10:58 +01:00
|
|
|
|
|
|
|
# Messages which have references.
|
2022-03-10 16:36:13 +01:00
|
|
|
filter = {"related_by_rel_types": [RelationTypes.REFERENCE]}
|
2021-11-09 14:10:58 +01:00
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertEqual(chunk, [self.event_id_2])
|
2021-11-09 14:10:58 +01:00
|
|
|
|
|
|
|
# Messages which have either annotations or references.
|
|
|
|
filter = {
|
2022-03-10 16:36:13 +01:00
|
|
|
"related_by_rel_types": [
|
2021-11-09 14:10:58 +01:00
|
|
|
RelationTypes.ANNOTATION,
|
|
|
|
RelationTypes.REFERENCE,
|
|
|
|
]
|
|
|
|
}
|
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertCountEqual(chunk, [self.event_id_1, self.event_id_2])
|
2021-11-09 14:10:58 +01:00
|
|
|
|
2022-12-09 18:36:32 +01:00
|
|
|
def test_filter_relation_senders_and_type(self) -> None:
|
2021-11-09 14:10:58 +01:00
|
|
|
# Messages which second user reacted to.
|
|
|
|
filter = {
|
2022-03-10 16:36:13 +01:00
|
|
|
"related_by_senders": [self.second_user_id],
|
|
|
|
"related_by_rel_types": [RelationTypes.ANNOTATION],
|
2021-11-09 14:10:58 +01:00
|
|
|
}
|
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertEqual(chunk, [self.event_id_1])
|
2021-11-09 14:10:58 +01:00
|
|
|
|
2022-12-09 18:36:32 +01:00
|
|
|
def test_duplicate_relation(self) -> None:
|
2021-11-09 14:10:58 +01:00
|
|
|
"""An event should only be returned once if there are multiple relations to it."""
|
|
|
|
self.helper.send_event(
|
|
|
|
room_id=self.room_id,
|
|
|
|
type="m.reaction",
|
|
|
|
content={
|
|
|
|
"m.relates_to": {
|
|
|
|
"rel_type": RelationTypes.ANNOTATION,
|
|
|
|
"event_id": self.event_id_1,
|
|
|
|
"key": "A",
|
|
|
|
}
|
|
|
|
},
|
|
|
|
tok=self.second_tok,
|
|
|
|
)
|
|
|
|
|
2022-03-10 16:36:13 +01:00
|
|
|
filter = {"related_by_senders": [self.second_user_id]}
|
2021-11-09 14:10:58 +01:00
|
|
|
chunk = self._filter_messages(filter)
|
2022-10-17 17:32:11 +02:00
|
|
|
self.assertEqual(chunk, [self.event_id_1])
|
|
|
|
|
|
|
|
def test_filter_rel_types(self) -> None:
|
|
|
|
# Messages which are annotations.
|
|
|
|
filter = {"org.matrix.msc3874.rel_types": [RelationTypes.ANNOTATION]}
|
|
|
|
chunk = self._filter_messages(filter)
|
|
|
|
self.assertEqual(chunk, [self.event_id_annotation])
|
|
|
|
|
|
|
|
# Messages which are references.
|
|
|
|
filter = {"org.matrix.msc3874.rel_types": [RelationTypes.REFERENCE]}
|
|
|
|
chunk = self._filter_messages(filter)
|
|
|
|
self.assertEqual(chunk, [self.event_id_reference])
|
|
|
|
|
|
|
|
# Messages which are either annotations or references.
|
|
|
|
filter = {
|
|
|
|
"org.matrix.msc3874.rel_types": [
|
|
|
|
RelationTypes.ANNOTATION,
|
|
|
|
RelationTypes.REFERENCE,
|
|
|
|
]
|
|
|
|
}
|
|
|
|
chunk = self._filter_messages(filter)
|
|
|
|
self.assertCountEqual(
|
|
|
|
chunk,
|
|
|
|
[self.event_id_annotation, self.event_id_reference],
|
|
|
|
)
|
|
|
|
|
|
|
|
def test_filter_not_rel_types(self) -> None:
|
|
|
|
# Messages which are not annotations.
|
|
|
|
filter = {"org.matrix.msc3874.not_rel_types": [RelationTypes.ANNOTATION]}
|
|
|
|
chunk = self._filter_messages(filter)
|
|
|
|
self.assertEqual(
|
|
|
|
chunk,
|
|
|
|
[
|
|
|
|
self.event_id_1,
|
|
|
|
self.event_id_2,
|
|
|
|
self.event_id_reference,
|
|
|
|
self.event_id_none,
|
|
|
|
],
|
|
|
|
)
|
|
|
|
|
|
|
|
# Messages which are not references.
|
|
|
|
filter = {"org.matrix.msc3874.not_rel_types": [RelationTypes.REFERENCE]}
|
|
|
|
chunk = self._filter_messages(filter)
|
|
|
|
self.assertEqual(
|
|
|
|
chunk,
|
|
|
|
[
|
|
|
|
self.event_id_1,
|
|
|
|
self.event_id_annotation,
|
|
|
|
self.event_id_2,
|
|
|
|
self.event_id_none,
|
|
|
|
],
|
|
|
|
)
|
|
|
|
|
|
|
|
# Messages which are neither annotations or references.
|
|
|
|
filter = {
|
|
|
|
"org.matrix.msc3874.not_rel_types": [
|
|
|
|
RelationTypes.ANNOTATION,
|
|
|
|
RelationTypes.REFERENCE,
|
|
|
|
]
|
|
|
|
}
|
|
|
|
chunk = self._filter_messages(filter)
|
|
|
|
self.assertEqual(chunk, [self.event_id_1, self.event_id_2, self.event_id_none])
|