2019-12-04 14:52:46 +01:00
|
|
|
# Copyright 2014-2016 OpenMarket Ltd
|
|
|
|
# Copyright 2017-2018 New Vector Ltd
|
|
|
|
# Copyright 2019 The Matrix.org Foundation C.I.C.
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
2021-12-13 20:01:27 +01:00
|
|
|
import inspect
|
2019-12-04 14:52:46 +01:00
|
|
|
import logging
|
|
|
|
import time
|
2021-12-13 20:01:27 +01:00
|
|
|
import types
|
2021-08-02 15:24:43 +02:00
|
|
|
from collections import defaultdict
|
2020-06-16 14:51:47 +02:00
|
|
|
from sys import intern
|
2020-02-27 12:53:40 +01:00
|
|
|
from time import monotonic as monotonic_time
|
2020-04-08 00:06:39 +02:00
|
|
|
from typing import (
|
2021-10-22 19:15:41 +02:00
|
|
|
TYPE_CHECKING,
|
2020-04-08 00:06:39 +02:00
|
|
|
Any,
|
|
|
|
Callable,
|
2021-04-22 17:43:50 +02:00
|
|
|
Collection,
|
2020-04-08 00:06:39 +02:00
|
|
|
Dict,
|
|
|
|
Iterable,
|
|
|
|
Iterator,
|
|
|
|
List,
|
|
|
|
Optional,
|
|
|
|
Tuple,
|
2022-05-12 16:33:50 +02:00
|
|
|
Type,
|
2020-04-08 00:06:39 +02:00
|
|
|
TypeVar,
|
2020-09-02 19:11:02 +02:00
|
|
|
cast,
|
2020-08-26 13:19:32 +02:00
|
|
|
overload,
|
2020-04-08 00:06:39 +02:00
|
|
|
)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-10-02 16:20:45 +02:00
|
|
|
import attr
|
2019-12-04 14:52:46 +01:00
|
|
|
from prometheus_client import Histogram
|
2022-05-09 11:28:38 +02:00
|
|
|
from typing_extensions import Concatenate, Literal, ParamSpec
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2019-12-18 11:45:12 +01:00
|
|
|
from twisted.enterprise import adbapi
|
2022-05-12 16:33:50 +02:00
|
|
|
from twisted.internet.interfaces import IReactorCore
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
from synapse.api.errors import StoreError
|
2019-12-18 11:45:12 +01:00
|
|
|
from synapse.config.database import DatabaseConnectionConfig
|
2021-06-03 17:31:56 +02:00
|
|
|
from synapse.logging import opentracing
|
2020-03-10 15:40:28 +01:00
|
|
|
from synapse.logging.context import (
|
|
|
|
LoggingContext,
|
2020-03-24 15:45:33 +01:00
|
|
|
current_context,
|
2020-03-10 15:40:28 +01:00
|
|
|
make_deferred_yieldable,
|
|
|
|
)
|
2021-11-01 12:21:36 +01:00
|
|
|
from synapse.metrics import register_threadpool
|
2019-12-04 14:52:46 +01:00
|
|
|
from synapse.metrics.background_process_metrics import run_as_background_process
|
2019-12-04 16:09:36 +01:00
|
|
|
from synapse.storage.background_updates import BackgroundUpdater
|
2020-02-27 12:53:40 +01:00
|
|
|
from synapse.storage.engines import BaseDatabaseEngine, PostgresEngine, Sqlite3Engine
|
|
|
|
from synapse.storage.types import Connection, Cursor
|
2022-03-16 16:07:41 +01:00
|
|
|
from synapse.util.async_helpers import delay_cancellation
|
2021-12-15 18:00:50 +01:00
|
|
|
from synapse.util.iterutils import batch_iter
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2021-10-22 19:15:41 +02:00
|
|
|
if TYPE_CHECKING:
|
|
|
|
from synapse.server import HomeServer
|
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
# python 3 does not have a maximum int value
|
2022-03-29 12:41:19 +02:00
|
|
|
MAX_TXN_ID = 2**63 - 1
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-07-28 19:52:13 +02:00
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
sql_logger = logging.getLogger("synapse.storage.SQL")
|
|
|
|
transaction_logger = logging.getLogger("synapse.storage.txn")
|
|
|
|
perf_logger = logging.getLogger("synapse.storage.TIME")
|
|
|
|
|
|
|
|
sql_scheduling_timer = Histogram("synapse_storage_schedule_time", "sec")
|
|
|
|
|
|
|
|
sql_query_timer = Histogram("synapse_storage_query_time", "sec", ["verb"])
|
|
|
|
sql_txn_timer = Histogram("synapse_storage_transaction_time", "sec", ["desc"])
|
|
|
|
|
|
|
|
|
|
|
|
# Unique indexes which have been added in background updates. Maps from table name
|
|
|
|
# to the name of the background update which added the unique index to that table.
|
|
|
|
#
|
|
|
|
# This is used by the upsert logic to figure out which tables are safe to do a proper
|
|
|
|
# UPSERT on: until the relevant background update has completed, we
|
|
|
|
# have to emulate an upsert by locking the table.
|
|
|
|
#
|
|
|
|
UNIQUE_INDEX_BACKGROUND_UPDATES = {
|
|
|
|
"user_ips": "user_ips_device_unique_index",
|
|
|
|
"device_lists_remote_extremeties": "device_lists_remote_extremeties_unique_idx",
|
|
|
|
"device_lists_remote_cache": "device_lists_remote_cache_unique_idx",
|
|
|
|
"event_search": "event_search_event_id_idx",
|
2022-05-23 11:28:56 +02:00
|
|
|
"local_media_repository_thumbnails": "local_media_repository_thumbnails_method_idx",
|
|
|
|
"remote_media_cache_thumbnails": "remote_media_repository_thumbnails_method_idx",
|
2019-12-04 14:52:46 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2019-12-18 11:45:12 +01:00
|
|
|
def make_pool(
|
2022-05-12 16:33:50 +02:00
|
|
|
reactor: IReactorCore,
|
|
|
|
db_config: DatabaseConnectionConfig,
|
|
|
|
engine: BaseDatabaseEngine,
|
2019-12-18 11:45:12 +01:00
|
|
|
) -> adbapi.ConnectionPool:
|
2021-02-16 23:32:34 +01:00
|
|
|
"""Get the connection pool for the database."""
|
2019-12-18 11:45:12 +01:00
|
|
|
|
2020-11-12 15:26:24 +01:00
|
|
|
# By default enable `cp_reconnect`. We need to fiddle with db_args in case
|
|
|
|
# someone has explicitly set `cp_reconnect`.
|
|
|
|
db_args = dict(db_config.config.get("args", {}))
|
|
|
|
db_args.setdefault("cp_reconnect", True)
|
|
|
|
|
2022-05-12 16:33:50 +02:00
|
|
|
def _on_new_connection(conn: Connection) -> None:
|
2021-06-08 14:49:29 +02:00
|
|
|
# Ensure we have a logging context so we can correctly track queries,
|
|
|
|
# etc.
|
|
|
|
with LoggingContext("db.on_new_connection"):
|
|
|
|
engine.on_new_connection(
|
|
|
|
LoggingDatabaseConnection(conn, engine, "on_new_connection")
|
|
|
|
)
|
|
|
|
|
2021-11-01 12:21:36 +01:00
|
|
|
connection_pool = adbapi.ConnectionPool(
|
2019-12-18 11:45:12 +01:00
|
|
|
db_config.config["name"],
|
|
|
|
cp_reactor=reactor,
|
2021-06-08 14:49:29 +02:00
|
|
|
cp_openfun=_on_new_connection,
|
2020-11-12 15:26:24 +01:00
|
|
|
**db_args,
|
2019-12-18 11:45:12 +01:00
|
|
|
)
|
|
|
|
|
2021-11-01 12:21:36 +01:00
|
|
|
register_threadpool(f"database-{db_config.name}", connection_pool.threadpool)
|
|
|
|
|
|
|
|
return connection_pool
|
|
|
|
|
2019-12-18 11:45:12 +01:00
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
def make_conn(
|
2020-10-02 16:20:45 +02:00
|
|
|
db_config: DatabaseConnectionConfig,
|
|
|
|
engine: BaseDatabaseEngine,
|
|
|
|
default_txn_name: str,
|
2021-07-06 14:03:16 +02:00
|
|
|
) -> "LoggingDatabaseConnection":
|
2019-12-18 11:45:12 +01:00
|
|
|
"""Make a new connection to the database and return it.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
Connection
|
|
|
|
"""
|
|
|
|
|
|
|
|
db_params = {
|
|
|
|
k: v
|
|
|
|
for k, v in db_config.config.get("args", {}).items()
|
|
|
|
if not k.startswith("cp_")
|
|
|
|
}
|
2020-10-02 16:20:45 +02:00
|
|
|
native_db_conn = engine.module.connect(**db_params)
|
|
|
|
db_conn = LoggingDatabaseConnection(native_db_conn, engine, default_txn_name)
|
|
|
|
|
2019-12-18 11:45:12 +01:00
|
|
|
engine.on_new_connection(db_conn)
|
|
|
|
return db_conn
|
|
|
|
|
|
|
|
|
2022-01-13 14:49:28 +01:00
|
|
|
@attr.s(slots=True, auto_attribs=True)
|
2020-10-02 16:20:45 +02:00
|
|
|
class LoggingDatabaseConnection:
|
|
|
|
"""A wrapper around a database connection that returns `LoggingTransaction`
|
|
|
|
as its cursor class.
|
|
|
|
|
|
|
|
This is mainly used on startup to ensure that queries get logged correctly
|
|
|
|
"""
|
|
|
|
|
2022-01-13 14:49:28 +01:00
|
|
|
conn: Connection
|
|
|
|
engine: BaseDatabaseEngine
|
|
|
|
default_txn_name: str
|
2020-10-02 16:20:45 +02:00
|
|
|
|
|
|
|
def cursor(
|
2022-05-12 16:33:50 +02:00
|
|
|
self,
|
|
|
|
*,
|
|
|
|
txn_name: Optional[str] = None,
|
|
|
|
after_callbacks: Optional[List["_CallbackListEntry"]] = None,
|
|
|
|
exception_callbacks: Optional[List["_CallbackListEntry"]] = None,
|
2020-10-02 16:20:45 +02:00
|
|
|
) -> "LoggingTransaction":
|
|
|
|
if not txn_name:
|
|
|
|
txn_name = self.default_txn_name
|
|
|
|
|
|
|
|
return LoggingTransaction(
|
|
|
|
self.conn.cursor(),
|
|
|
|
name=txn_name,
|
|
|
|
database_engine=self.engine,
|
|
|
|
after_callbacks=after_callbacks,
|
|
|
|
exception_callbacks=exception_callbacks,
|
|
|
|
)
|
|
|
|
|
|
|
|
def close(self) -> None:
|
|
|
|
self.conn.close()
|
|
|
|
|
|
|
|
def commit(self) -> None:
|
|
|
|
self.conn.commit()
|
|
|
|
|
2021-02-05 21:39:19 +01:00
|
|
|
def rollback(self) -> None:
|
|
|
|
self.conn.rollback()
|
2020-10-02 16:20:45 +02:00
|
|
|
|
2021-12-13 18:05:00 +01:00
|
|
|
def __enter__(self) -> "LoggingDatabaseConnection":
|
2020-10-02 16:20:45 +02:00
|
|
|
self.conn.__enter__()
|
|
|
|
return self
|
|
|
|
|
2022-05-12 16:33:50 +02:00
|
|
|
def __exit__(
|
|
|
|
self,
|
|
|
|
exc_type: Optional[Type[BaseException]],
|
|
|
|
exc_value: Optional[BaseException],
|
|
|
|
traceback: Optional[types.TracebackType],
|
|
|
|
) -> Optional[bool]:
|
2020-10-02 16:20:45 +02:00
|
|
|
return self.conn.__exit__(exc_type, exc_value, traceback)
|
|
|
|
|
|
|
|
# Proxy through any unknown lookups to the DB conn class.
|
2022-05-12 16:33:50 +02:00
|
|
|
def __getattr__(self, name: str) -> Any:
|
2020-10-02 16:20:45 +02:00
|
|
|
return getattr(self.conn, name)
|
|
|
|
|
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
# The type of entry which goes on our after_callbacks and exception_callbacks lists.
|
2022-05-09 12:27:39 +02:00
|
|
|
_CallbackListEntry = Tuple[Callable[..., object], Tuple[object, ...], Dict[str, object]]
|
2020-02-27 12:53:40 +01:00
|
|
|
|
2022-05-09 11:28:38 +02:00
|
|
|
P = ParamSpec("P")
|
2021-01-11 17:09:22 +01:00
|
|
|
R = TypeVar("R")
|
|
|
|
|
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
class LoggingTransaction:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""An object that almost-transparently proxies for the 'txn' object
|
|
|
|
passed to the constructor. Adds logging and metrics to the .execute()
|
|
|
|
method.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
txn: The database transaction object to wrap.
|
2020-02-27 12:53:40 +01:00
|
|
|
name: The name of this transactions for logging.
|
|
|
|
database_engine
|
|
|
|
after_callbacks: A list that callbacks will be appended to
|
2019-12-04 14:52:46 +01:00
|
|
|
that have been added by `call_after` which should be run on
|
|
|
|
successful completion of the transaction. None indicates that no
|
|
|
|
callbacks should be allowed to be scheduled to run.
|
2020-02-27 12:53:40 +01:00
|
|
|
exception_callbacks: A list that callbacks will be appended
|
2019-12-04 14:52:46 +01:00
|
|
|
to that have been added by `call_on_exception` which should be run
|
|
|
|
if transaction ends with an error. None indicates that no callbacks
|
|
|
|
should be allowed to be scheduled to run.
|
|
|
|
"""
|
|
|
|
|
|
|
|
__slots__ = [
|
|
|
|
"txn",
|
|
|
|
"name",
|
|
|
|
"database_engine",
|
|
|
|
"after_callbacks",
|
|
|
|
"exception_callbacks",
|
|
|
|
]
|
|
|
|
|
|
|
|
def __init__(
|
2020-02-27 12:53:40 +01:00
|
|
|
self,
|
|
|
|
txn: Cursor,
|
|
|
|
name: str,
|
|
|
|
database_engine: BaseDatabaseEngine,
|
|
|
|
after_callbacks: Optional[List[_CallbackListEntry]] = None,
|
|
|
|
exception_callbacks: Optional[List[_CallbackListEntry]] = None,
|
2019-12-04 14:52:46 +01:00
|
|
|
):
|
2020-02-27 12:53:40 +01:00
|
|
|
self.txn = txn
|
|
|
|
self.name = name
|
|
|
|
self.database_engine = database_engine
|
|
|
|
self.after_callbacks = after_callbacks
|
|
|
|
self.exception_callbacks = exception_callbacks
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-05-09 12:27:39 +02:00
|
|
|
def call_after(
|
|
|
|
self, callback: Callable[P, object], *args: P.args, **kwargs: P.kwargs
|
|
|
|
) -> None:
|
2022-03-29 13:31:05 +02:00
|
|
|
"""Call the given callback on the main twisted thread after the transaction has
|
|
|
|
finished.
|
|
|
|
|
|
|
|
Mostly used to invalidate the caches on the correct thread.
|
|
|
|
|
|
|
|
Note that transactions may be retried a few times if they encounter database
|
|
|
|
errors such as serialization failures. Callbacks given to `call_after`
|
|
|
|
will accumulate across transaction attempts and will _all_ be called once a
|
|
|
|
transaction attempt succeeds, regardless of whether previous transaction
|
|
|
|
attempts failed. Otherwise, if all transaction attempts fail, all
|
|
|
|
`call_on_exception` callbacks will be run instead.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2020-02-27 12:53:40 +01:00
|
|
|
# if self.after_callbacks is None, that means that whatever constructed the
|
|
|
|
# LoggingTransaction isn't expecting there to be any callbacks; assert that
|
|
|
|
# is not the case.
|
|
|
|
assert self.after_callbacks is not None
|
2022-05-09 12:27:39 +02:00
|
|
|
# type-ignore: need mypy containing https://github.com/python/mypy/pull/12668
|
|
|
|
self.after_callbacks.append((callback, args, kwargs)) # type: ignore[arg-type]
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def call_on_exception(
|
2022-05-09 12:27:39 +02:00
|
|
|
self, callback: Callable[P, object], *args: P.args, **kwargs: P.kwargs
|
|
|
|
) -> None:
|
2022-03-29 13:31:05 +02:00
|
|
|
"""Call the given callback on the main twisted thread after the transaction has
|
|
|
|
failed.
|
|
|
|
|
|
|
|
Note that transactions may be retried a few times if they encounter database
|
|
|
|
errors such as serialization failures. Callbacks given to `call_on_exception`
|
|
|
|
will accumulate across transaction attempts and will _all_ be called once the
|
|
|
|
final transaction attempt fails. No `call_on_exception` callbacks will be run
|
|
|
|
if any transaction attempt succeeds.
|
|
|
|
"""
|
2020-02-27 12:53:40 +01:00
|
|
|
# if self.exception_callbacks is None, that means that whatever constructed the
|
|
|
|
# LoggingTransaction isn't expecting there to be any callbacks; assert that
|
|
|
|
# is not the case.
|
|
|
|
assert self.exception_callbacks is not None
|
2022-05-09 12:27:39 +02:00
|
|
|
# type-ignore: need mypy containing https://github.com/python/mypy/pull/12668
|
|
|
|
self.exception_callbacks.append((callback, args, kwargs)) # type: ignore[arg-type]
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2021-02-05 21:39:19 +01:00
|
|
|
def fetchone(self) -> Optional[Tuple]:
|
|
|
|
return self.txn.fetchone()
|
|
|
|
|
|
|
|
def fetchmany(self, size: Optional[int] = None) -> List[Tuple]:
|
|
|
|
return self.txn.fetchmany(size=size)
|
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
def fetchall(self) -> List[Tuple]:
|
|
|
|
return self.txn.fetchall()
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
def __iter__(self) -> Iterator[Tuple]:
|
2019-12-04 14:52:46 +01:00
|
|
|
return self.txn.__iter__()
|
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
@property
|
|
|
|
def rowcount(self) -> int:
|
|
|
|
return self.txn.rowcount
|
|
|
|
|
|
|
|
@property
|
|
|
|
def description(self) -> Any:
|
|
|
|
return self.txn.description
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def execute_batch(self, sql: str, args: Iterable[Iterable[Any]]) -> None:
|
2021-01-21 15:44:12 +01:00
|
|
|
"""Similar to `executemany`, except `txn.rowcount` will not be correct
|
|
|
|
afterwards.
|
|
|
|
|
|
|
|
More efficient than `executemany` on PostgreSQL
|
|
|
|
"""
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
if isinstance(self.database_engine, PostgresEngine):
|
2022-03-23 15:03:24 +01:00
|
|
|
from psycopg2.extras import execute_batch
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-03-28 18:21:23 +02:00
|
|
|
self._do_execute(
|
|
|
|
lambda the_sql: execute_batch(self.txn, the_sql, args), sql
|
|
|
|
)
|
2019-12-04 14:52:46 +01:00
|
|
|
else:
|
2021-01-21 11:22:53 +01:00
|
|
|
self.executemany(sql, args)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-03-28 18:21:23 +02:00
|
|
|
def execute_values(
|
|
|
|
self, sql: str, values: Iterable[Iterable[Any]], fetch: bool = True
|
|
|
|
) -> List[Tuple]:
|
2021-01-11 17:09:22 +01:00
|
|
|
"""Corresponds to psycopg2.extras.execute_values. Only available when
|
|
|
|
using postgres.
|
|
|
|
|
2021-09-03 17:35:49 +02:00
|
|
|
The `fetch` parameter must be set to False if the query does not return
|
|
|
|
rows (e.g. INSERTs).
|
2021-01-11 17:09:22 +01:00
|
|
|
"""
|
|
|
|
assert isinstance(self.database_engine, PostgresEngine)
|
2022-03-23 15:03:24 +01:00
|
|
|
from psycopg2.extras import execute_values
|
2021-01-11 17:09:22 +01:00
|
|
|
|
|
|
|
return self._do_execute(
|
2022-03-28 18:21:23 +02:00
|
|
|
lambda the_sql: execute_values(self.txn, the_sql, values, fetch=fetch),
|
2022-03-23 15:03:24 +01:00
|
|
|
sql,
|
2021-01-11 17:09:22 +01:00
|
|
|
)
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def execute(self, sql: str, *args: Any) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
self._do_execute(self.txn.execute, sql, *args)
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def executemany(self, sql: str, *args: Any) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
self._do_execute(self.txn.executemany, sql, *args)
|
|
|
|
|
2020-05-12 12:20:48 +02:00
|
|
|
def _make_sql_one_line(self, sql: str) -> str:
|
2019-12-04 14:52:46 +01:00
|
|
|
"Strip newlines out of SQL so that the loggers in the DB are on one line"
|
2020-05-12 12:20:48 +02:00
|
|
|
return " ".join(line.strip() for line in sql.splitlines() if line.strip())
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-05-09 11:28:38 +02:00
|
|
|
def _do_execute(
|
|
|
|
self,
|
|
|
|
func: Callable[Concatenate[str, P], R],
|
|
|
|
sql: str,
|
|
|
|
*args: P.args,
|
|
|
|
**kwargs: P.kwargs,
|
|
|
|
) -> R:
|
2019-12-04 14:52:46 +01:00
|
|
|
sql = self._make_sql_one_line(sql)
|
|
|
|
|
|
|
|
# TODO(paul): Maybe use 'info' and 'debug' for values?
|
|
|
|
sql_logger.debug("[SQL] {%s} %s", self.name, sql)
|
|
|
|
|
|
|
|
sql = self.database_engine.convert_param_style(sql)
|
|
|
|
if args:
|
|
|
|
try:
|
2022-05-09 11:28:38 +02:00
|
|
|
# The type-ignore should be redundant once mypy releases a version with
|
|
|
|
# https://github.com/python/mypy/pull/12668. (`args` might be empty,
|
|
|
|
# (but we'll catch the index error if so.)
|
|
|
|
sql_logger.debug("[SQL values] {%s} %r", self.name, args[0]) # type: ignore[index]
|
2019-12-04 14:52:46 +01:00
|
|
|
except Exception:
|
|
|
|
# Don't let logging failures stop SQL from working
|
|
|
|
pass
|
|
|
|
|
|
|
|
start = time.time()
|
|
|
|
|
|
|
|
try:
|
2021-06-03 17:31:56 +02:00
|
|
|
with opentracing.start_active_span(
|
|
|
|
"db.query",
|
|
|
|
tags={
|
|
|
|
opentracing.tags.DATABASE_TYPE: "sql",
|
|
|
|
opentracing.tags.DATABASE_STATEMENT: sql,
|
|
|
|
},
|
|
|
|
):
|
2022-05-09 11:28:38 +02:00
|
|
|
return func(sql, *args, **kwargs)
|
2019-12-04 14:52:46 +01:00
|
|
|
except Exception as e:
|
2020-07-28 19:52:13 +02:00
|
|
|
sql_logger.debug("[SQL FAIL] {%s} %s", self.name, e)
|
2019-12-04 14:52:46 +01:00
|
|
|
raise
|
|
|
|
finally:
|
|
|
|
secs = time.time() - start
|
|
|
|
sql_logger.debug("[SQL time] {%s} %f sec", self.name, secs)
|
|
|
|
sql_query_timer.labels(sql.split()[0]).observe(secs)
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def close(self) -> None:
|
2020-02-27 12:53:40 +01:00
|
|
|
self.txn.close()
|
|
|
|
|
2020-10-02 16:20:45 +02:00
|
|
|
def __enter__(self) -> "LoggingTransaction":
|
|
|
|
return self
|
|
|
|
|
2022-05-12 16:33:50 +02:00
|
|
|
def __exit__(
|
|
|
|
self,
|
|
|
|
exc_type: Optional[Type[BaseException]],
|
|
|
|
exc_value: Optional[BaseException],
|
|
|
|
traceback: Optional[types.TracebackType],
|
|
|
|
) -> None:
|
2020-10-02 16:20:45 +02:00
|
|
|
self.close()
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-09-04 12:54:56 +02:00
|
|
|
class PerformanceCounters:
|
2022-05-12 16:33:50 +02:00
|
|
|
def __init__(self) -> None:
|
|
|
|
self.current_counters: Dict[str, Tuple[int, float]] = {}
|
|
|
|
self.previous_counters: Dict[str, Tuple[int, float]] = {}
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def update(self, key: str, duration_secs: float) -> None:
|
2022-05-12 16:33:50 +02:00
|
|
|
count, cum_time = self.current_counters.get(key, (0, 0.0))
|
2019-12-04 14:52:46 +01:00
|
|
|
count += 1
|
|
|
|
cum_time += duration_secs
|
|
|
|
self.current_counters[key] = (count, cum_time)
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def interval(self, interval_duration_secs: float, limit: int = 3) -> str:
|
2019-12-04 14:52:46 +01:00
|
|
|
counters = []
|
2020-06-15 13:03:36 +02:00
|
|
|
for name, (count, cum_time) in self.current_counters.items():
|
2019-12-04 14:52:46 +01:00
|
|
|
prev_count, prev_time = self.previous_counters.get(name, (0, 0))
|
|
|
|
counters.append(
|
|
|
|
(
|
|
|
|
(cum_time - prev_time) / interval_duration_secs,
|
|
|
|
count - prev_count,
|
|
|
|
name,
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
self.previous_counters = dict(self.current_counters)
|
|
|
|
|
|
|
|
counters.sort(reverse=True)
|
|
|
|
|
|
|
|
top_n_counters = ", ".join(
|
|
|
|
"%s(%d): %.3f%%" % (name, count, 100 * ratio)
|
|
|
|
for ratio, count, name in counters[:limit]
|
|
|
|
)
|
|
|
|
|
|
|
|
return top_n_counters
|
|
|
|
|
|
|
|
|
2020-09-04 12:54:56 +02:00
|
|
|
class DatabasePool:
|
2019-12-04 15:00:29 +01:00
|
|
|
"""Wraps a single physical database and connection pool.
|
|
|
|
|
|
|
|
A single database may be used by multiple data stores.
|
|
|
|
"""
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
_TXN_ID = 0
|
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
def __init__(
|
2021-02-24 11:13:53 +01:00
|
|
|
self,
|
2021-10-22 19:15:41 +02:00
|
|
|
hs: "HomeServer",
|
2021-02-24 11:13:53 +01:00
|
|
|
database_config: DatabaseConnectionConfig,
|
|
|
|
engine: BaseDatabaseEngine,
|
2020-02-27 12:53:40 +01:00
|
|
|
):
|
2019-12-04 14:52:46 +01:00
|
|
|
self.hs = hs
|
|
|
|
self._clock = hs.get_clock()
|
2021-08-02 15:24:43 +02:00
|
|
|
self._txn_limit = database_config.config.get("txn_limit", 0)
|
2019-12-18 11:45:12 +01:00
|
|
|
self._database_config = database_config
|
|
|
|
self._db_pool = make_pool(hs.get_reactor(), database_config, engine)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2019-12-04 16:09:36 +01:00
|
|
|
self.updates = BackgroundUpdater(hs, self)
|
|
|
|
|
2020-02-27 12:53:40 +01:00
|
|
|
self._previous_txn_total_time = 0.0
|
|
|
|
self._current_txn_total_time = 0.0
|
|
|
|
self._previous_loop_ts = 0.0
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2021-08-02 15:24:43 +02:00
|
|
|
# Transaction counter: key is the twisted thread id, value is the current count
|
|
|
|
self._txn_counters: Dict[int, int] = defaultdict(int)
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
# TODO(paul): These can eventually be removed once the metrics code
|
|
|
|
# is running in mainline, and we have some nice monitoring frontends
|
|
|
|
# to watch it
|
|
|
|
self._txn_perf_counters = PerformanceCounters()
|
|
|
|
|
2019-12-18 11:45:12 +01:00
|
|
|
self.engine = engine
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
# A set of tables that are not safe to use native upserts in.
|
|
|
|
self._unsafe_to_upsert_tables = set(UNIQUE_INDEX_BACKGROUND_UPDATES.keys())
|
|
|
|
|
|
|
|
# We add the user_directory_search table to the blacklist on SQLite
|
|
|
|
# because the existing search table does not have an index, making it
|
|
|
|
# unsafe to use native upserts.
|
2019-12-06 14:40:02 +01:00
|
|
|
if isinstance(self.engine, Sqlite3Engine):
|
2019-12-04 14:52:46 +01:00
|
|
|
self._unsafe_to_upsert_tables.add("user_directory_search")
|
|
|
|
|
2019-12-06 14:40:02 +01:00
|
|
|
if self.engine.can_native_upsert:
|
2019-12-04 14:52:46 +01:00
|
|
|
# Check ASAP (and then later, every 1s) to see if we have finished
|
|
|
|
# background updates of tables that aren't safe to update.
|
|
|
|
self._clock.call_later(
|
|
|
|
0.0,
|
|
|
|
run_as_background_process,
|
|
|
|
"upsert_safety_check",
|
|
|
|
self._check_safe_to_upsert,
|
|
|
|
)
|
2021-01-14 18:19:35 +01:00
|
|
|
|
2021-11-08 17:08:02 +01:00
|
|
|
def name(self) -> str:
|
|
|
|
"Return the name of this database"
|
|
|
|
return self._database_config.name
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def is_running(self) -> bool:
|
2021-02-16 23:32:34 +01:00
|
|
|
"""Is the database pool currently running"""
|
2019-12-18 11:45:12 +01:00
|
|
|
return self._db_pool.running
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
async def _check_safe_to_upsert(self) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
Is it safe to use native UPSERT?
|
|
|
|
|
|
|
|
If there are background updates, we will need to wait, as they may be
|
|
|
|
the addition of indexes that set the UNIQUE constraint that we require.
|
|
|
|
|
|
|
|
If the background updates have not completed, wait 15 sec and check again.
|
|
|
|
"""
|
2020-08-17 18:18:01 +02:00
|
|
|
updates = await self.simple_select_list(
|
2019-12-04 14:52:46 +01:00
|
|
|
"background_updates",
|
|
|
|
keyvalues=None,
|
|
|
|
retcols=["update_name"],
|
|
|
|
desc="check_background_updates",
|
|
|
|
)
|
|
|
|
updates = [x["update_name"] for x in updates]
|
|
|
|
|
|
|
|
for table, update_name in UNIQUE_INDEX_BACKGROUND_UPDATES.items():
|
|
|
|
if update_name not in updates:
|
|
|
|
logger.debug("Now safe to upsert in %s", table)
|
|
|
|
self._unsafe_to_upsert_tables.discard(table)
|
|
|
|
|
|
|
|
# If there's any updates still running, reschedule to run.
|
|
|
|
if updates:
|
|
|
|
self._clock.call_later(
|
|
|
|
15.0,
|
|
|
|
run_as_background_process,
|
|
|
|
"upsert_safety_check",
|
|
|
|
self._check_safe_to_upsert,
|
|
|
|
)
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
def start_profiling(self) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
self._previous_loop_ts = monotonic_time()
|
|
|
|
|
2022-05-12 16:33:50 +02:00
|
|
|
def loop() -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
curr = self._current_txn_total_time
|
|
|
|
prev = self._previous_txn_total_time
|
|
|
|
self._previous_txn_total_time = curr
|
|
|
|
|
|
|
|
time_now = monotonic_time()
|
|
|
|
time_then = self._previous_loop_ts
|
|
|
|
self._previous_loop_ts = time_now
|
|
|
|
|
|
|
|
duration = time_now - time_then
|
|
|
|
ratio = (curr - prev) / duration
|
|
|
|
|
|
|
|
top_three_counters = self._txn_perf_counters.interval(duration, limit=3)
|
|
|
|
|
2020-02-05 09:57:38 +01:00
|
|
|
perf_logger.debug(
|
2019-12-04 14:52:46 +01:00
|
|
|
"Total database time: %.3f%% {%s}", ratio * 100, top_three_counters
|
|
|
|
)
|
|
|
|
|
|
|
|
self._clock.looping_call(loop, 10000)
|
|
|
|
|
|
|
|
def new_transaction(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
2020-10-02 16:20:45 +02:00
|
|
|
conn: LoggingDatabaseConnection,
|
2020-08-20 15:00:59 +02:00
|
|
|
desc: str,
|
|
|
|
after_callbacks: List[_CallbackListEntry],
|
|
|
|
exception_callbacks: List[_CallbackListEntry],
|
2022-05-09 12:27:39 +02:00
|
|
|
func: Callable[Concatenate[LoggingTransaction, P], R],
|
|
|
|
*args: P.args,
|
|
|
|
**kwargs: P.kwargs,
|
2020-08-20 15:00:59 +02:00
|
|
|
) -> R:
|
2020-10-07 16:15:57 +02:00
|
|
|
"""Start a new database transaction with the given connection.
|
|
|
|
|
|
|
|
Note: The given func may be called multiple times under certain
|
|
|
|
failure modes. This is normally fine when in a standard transaction,
|
|
|
|
but care must be taken if the connection is in `autocommit` mode that
|
|
|
|
the function will correctly handle being aborted and retried half way
|
|
|
|
through its execution.
|
|
|
|
|
2021-12-13 20:01:27 +01:00
|
|
|
Similarly, the arguments to `func` (`args`, `kwargs`) should not be generators,
|
|
|
|
since they could be evaluated multiple times (which would produce an empty
|
|
|
|
result on the second or subsequent evaluation). Likewise, the closure of `func`
|
|
|
|
must not reference any generators. This method attempts to detect such usage
|
|
|
|
and will log an error.
|
|
|
|
|
2020-10-07 16:15:57 +02:00
|
|
|
Args:
|
|
|
|
conn
|
|
|
|
desc
|
|
|
|
after_callbacks
|
|
|
|
exception_callbacks
|
|
|
|
func
|
|
|
|
*args
|
|
|
|
**kwargs
|
|
|
|
"""
|
|
|
|
|
2021-12-13 20:01:27 +01:00
|
|
|
# Robustness check: ensure that none of the arguments are generators, since that
|
|
|
|
# will fail if we have to repeat the transaction.
|
|
|
|
# For now, we just log an error, and hope that it works on the first attempt.
|
|
|
|
# TODO: raise an exception.
|
2022-05-09 12:27:39 +02:00
|
|
|
|
|
|
|
# Type-ignore Mypy doesn't yet consider ParamSpec.args to be iterable; see
|
|
|
|
# https://github.com/python/mypy/pull/12668
|
|
|
|
for i, arg in enumerate(args): # type: ignore[arg-type, var-annotated]
|
2021-12-13 20:01:27 +01:00
|
|
|
if inspect.isgenerator(arg):
|
|
|
|
logger.error(
|
|
|
|
"Programming error: generator passed to new_transaction as "
|
|
|
|
"argument %i to function %s",
|
|
|
|
i,
|
|
|
|
func,
|
|
|
|
)
|
2022-05-09 12:27:39 +02:00
|
|
|
# Type-ignore Mypy doesn't yet consider ParamSpec.args to be a mapping; see
|
|
|
|
# https://github.com/python/mypy/pull/12668
|
|
|
|
for name, val in kwargs.items(): # type: ignore[attr-defined]
|
2021-12-13 20:01:27 +01:00
|
|
|
if inspect.isgenerator(val):
|
|
|
|
logger.error(
|
|
|
|
"Programming error: generator passed to new_transaction as "
|
|
|
|
"argument %s to function %s",
|
|
|
|
name,
|
|
|
|
func,
|
|
|
|
)
|
|
|
|
# also check variables referenced in func's closure
|
|
|
|
if inspect.isfunction(func):
|
|
|
|
f = cast(types.FunctionType, func)
|
|
|
|
if f.__closure__:
|
|
|
|
for i, cell in enumerate(f.__closure__):
|
|
|
|
if inspect.isgenerator(cell.cell_contents):
|
|
|
|
logger.error(
|
|
|
|
"Programming error: function %s references generator %s "
|
|
|
|
"via its closure",
|
|
|
|
f,
|
|
|
|
f.__code__.co_freevars[i],
|
|
|
|
)
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
start = monotonic_time()
|
|
|
|
txn_id = self._TXN_ID
|
|
|
|
|
|
|
|
# We don't really need these to be unique, so lets stop it from
|
|
|
|
# growing really large.
|
|
|
|
self._TXN_ID = (self._TXN_ID + 1) % (MAX_TXN_ID)
|
|
|
|
|
|
|
|
name = "%s-%x" % (desc, txn_id)
|
|
|
|
|
|
|
|
transaction_logger.debug("[TXN START] {%s}", name)
|
|
|
|
|
|
|
|
try:
|
|
|
|
i = 0
|
|
|
|
N = 5
|
|
|
|
while True:
|
2020-10-02 16:20:45 +02:00
|
|
|
cursor = conn.cursor(
|
|
|
|
txn_name=name,
|
|
|
|
after_callbacks=after_callbacks,
|
|
|
|
exception_callbacks=exception_callbacks,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
try:
|
2021-06-03 17:31:56 +02:00
|
|
|
with opentracing.start_active_span(
|
|
|
|
"db.txn",
|
|
|
|
tags={
|
|
|
|
opentracing.SynapseTags.DB_TXN_DESC: desc,
|
|
|
|
opentracing.SynapseTags.DB_TXN_ID: name,
|
|
|
|
},
|
|
|
|
):
|
|
|
|
r = func(cursor, *args, **kwargs)
|
2021-06-07 19:01:32 +02:00
|
|
|
opentracing.log_kv({"message": "commit"})
|
2021-06-03 17:31:56 +02:00
|
|
|
conn.commit()
|
|
|
|
return r
|
2019-12-06 14:40:02 +01:00
|
|
|
except self.engine.module.OperationalError as e:
|
2019-12-04 14:52:46 +01:00
|
|
|
# This can happen if the database disappears mid
|
|
|
|
# transaction.
|
2020-07-28 19:52:13 +02:00
|
|
|
transaction_logger.warning(
|
2021-02-16 23:32:34 +01:00
|
|
|
"[TXN OPERROR] {%s} %s %d/%d",
|
|
|
|
name,
|
|
|
|
e,
|
|
|
|
i,
|
|
|
|
N,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
if i < N:
|
|
|
|
i += 1
|
|
|
|
try:
|
2021-06-07 19:01:32 +02:00
|
|
|
with opentracing.start_active_span("db.rollback"):
|
|
|
|
conn.rollback()
|
2019-12-06 14:40:02 +01:00
|
|
|
except self.engine.module.Error as e1:
|
2020-07-28 19:52:13 +02:00
|
|
|
transaction_logger.warning("[TXN EROLL] {%s} %s", name, e1)
|
2019-12-04 14:52:46 +01:00
|
|
|
continue
|
|
|
|
raise
|
2019-12-06 14:40:02 +01:00
|
|
|
except self.engine.module.DatabaseError as e:
|
|
|
|
if self.engine.is_deadlock(e):
|
2020-07-28 19:52:13 +02:00
|
|
|
transaction_logger.warning(
|
|
|
|
"[TXN DEADLOCK] {%s} %d/%d", name, i, N
|
|
|
|
)
|
2019-12-04 14:52:46 +01:00
|
|
|
if i < N:
|
|
|
|
i += 1
|
|
|
|
try:
|
2021-06-07 19:01:32 +02:00
|
|
|
with opentracing.start_active_span("db.rollback"):
|
|
|
|
conn.rollback()
|
2019-12-06 14:40:02 +01:00
|
|
|
except self.engine.module.Error as e1:
|
2020-07-28 19:52:13 +02:00
|
|
|
transaction_logger.warning(
|
2021-02-16 23:32:34 +01:00
|
|
|
"[TXN EROLL] {%s} %s",
|
|
|
|
name,
|
|
|
|
e1,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
continue
|
|
|
|
raise
|
|
|
|
finally:
|
|
|
|
# we're either about to retry with a new cursor, or we're about to
|
|
|
|
# release the connection. Once we release the connection, it could
|
|
|
|
# get used for another query, which might do a conn.rollback().
|
|
|
|
#
|
|
|
|
# In the latter case, even though that probably wouldn't affect the
|
|
|
|
# results of this transaction, python's sqlite will reset all
|
|
|
|
# statements on the connection [1], which will make our cursor
|
|
|
|
# invalid [2].
|
|
|
|
#
|
|
|
|
# In any case, continuing to read rows after commit()ing seems
|
|
|
|
# dubious from the PoV of ACID transactional semantics
|
|
|
|
# (sqlite explicitly says that once you commit, you may see rows
|
|
|
|
# from subsequent updates.)
|
|
|
|
#
|
|
|
|
# In psycopg2, cursors are essentially a client-side fabrication -
|
|
|
|
# all the data is transferred to the client side when the statement
|
|
|
|
# finishes executing - so in theory we could go on streaming results
|
|
|
|
# from the cursor, but attempting to do so would make us
|
|
|
|
# incompatible with sqlite, so let's make sure we're not doing that
|
|
|
|
# by closing the cursor.
|
|
|
|
#
|
|
|
|
# (*named* cursors in psycopg2 are different and are proper server-
|
|
|
|
# side things, but (a) we don't use them and (b) they are implicitly
|
|
|
|
# closed by ending the transaction anyway.)
|
|
|
|
#
|
|
|
|
# In short, if we haven't finished with the cursor yet, that's a
|
|
|
|
# problem waiting to bite us.
|
|
|
|
#
|
|
|
|
# TL;DR: we're done with the cursor, so we can close it.
|
|
|
|
#
|
|
|
|
# [1]: https://github.com/python/cpython/blob/v3.8.0/Modules/_sqlite/connection.c#L465
|
|
|
|
# [2]: https://github.com/python/cpython/blob/v3.8.0/Modules/_sqlite/cursor.c#L236
|
|
|
|
cursor.close()
|
|
|
|
except Exception as e:
|
2020-07-28 19:52:13 +02:00
|
|
|
transaction_logger.debug("[TXN FAIL] {%s} %s", name, e)
|
2019-12-04 14:52:46 +01:00
|
|
|
raise
|
|
|
|
finally:
|
|
|
|
end = monotonic_time()
|
|
|
|
duration = end - start
|
|
|
|
|
2020-03-24 15:45:33 +01:00
|
|
|
current_context().add_database_transaction(duration)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
transaction_logger.debug("[TXN END] {%s} %f sec", name, duration)
|
|
|
|
|
|
|
|
self._current_txn_total_time += duration
|
|
|
|
self._txn_perf_counters.update(desc, duration)
|
|
|
|
sql_txn_timer.labels(desc).observe(duration)
|
|
|
|
|
2020-09-02 19:11:02 +02:00
|
|
|
async def runInteraction(
|
2020-10-07 16:15:57 +02:00
|
|
|
self,
|
|
|
|
desc: str,
|
2021-04-27 14:13:07 +02:00
|
|
|
func: Callable[..., R],
|
2020-10-07 16:15:57 +02:00
|
|
|
*args: Any,
|
|
|
|
db_autocommit: bool = False,
|
2022-01-25 15:14:46 +01:00
|
|
|
isolation_level: Optional[int] = None,
|
2021-04-13 11:41:34 +02:00
|
|
|
**kwargs: Any,
|
2020-09-02 19:11:02 +02:00
|
|
|
) -> R:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Starts a transaction on the database and runs a given function
|
|
|
|
|
|
|
|
Arguments:
|
2020-02-27 12:53:40 +01:00
|
|
|
desc: description of the transaction, for logging and metrics
|
|
|
|
func: callback function, which will be called with a
|
2019-12-04 14:52:46 +01:00
|
|
|
database transaction (twisted.enterprise.adbapi.Transaction) as
|
|
|
|
its first argument, followed by `args` and `kwargs`.
|
|
|
|
|
2020-10-07 16:15:57 +02:00
|
|
|
db_autocommit: Whether to run the function in "autocommit" mode,
|
|
|
|
i.e. outside of a transaction. This is useful for transactions
|
|
|
|
that are only a single query.
|
|
|
|
|
|
|
|
Currently, this is only implemented for Postgres. SQLite will still
|
|
|
|
run the function inside a transaction.
|
|
|
|
|
|
|
|
WARNING: This means that if func fails half way through then
|
|
|
|
the changes will *not* be rolled back. `func` may also get
|
|
|
|
called multiple times if the transaction is retried, so must
|
|
|
|
correctly handle that case.
|
|
|
|
|
2022-01-25 15:14:46 +01:00
|
|
|
isolation_level: Set the server isolation level for this transaction.
|
2020-02-27 12:53:40 +01:00
|
|
|
args: positional args to pass to `func`
|
|
|
|
kwargs: named args to pass to `func`
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Returns:
|
2020-09-02 19:11:02 +02:00
|
|
|
The result of func
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
|
2022-03-16 16:07:41 +01:00
|
|
|
async def _runInteraction() -> R:
|
|
|
|
after_callbacks: List[_CallbackListEntry] = []
|
|
|
|
exception_callbacks: List[_CallbackListEntry] = []
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-03-16 16:07:41 +01:00
|
|
|
if not current_context():
|
|
|
|
logger.warning("Starting db txn '%s' from sentinel context", desc)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-03-16 16:07:41 +01:00
|
|
|
try:
|
|
|
|
with opentracing.start_active_span(f"db.{desc}"):
|
|
|
|
result = await self.runWithConnection(
|
|
|
|
self.new_transaction,
|
|
|
|
desc,
|
|
|
|
after_callbacks,
|
|
|
|
exception_callbacks,
|
|
|
|
func,
|
|
|
|
*args,
|
|
|
|
db_autocommit=db_autocommit,
|
|
|
|
isolation_level=isolation_level,
|
|
|
|
**kwargs,
|
|
|
|
)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-03-16 16:07:41 +01:00
|
|
|
for after_callback, after_args, after_kwargs in after_callbacks:
|
|
|
|
after_callback(*after_args, **after_kwargs)
|
|
|
|
|
|
|
|
return cast(R, result)
|
|
|
|
except Exception:
|
|
|
|
for after_callback, after_args, after_kwargs in exception_callbacks:
|
|
|
|
after_callback(*after_args, **after_kwargs)
|
|
|
|
raise
|
|
|
|
|
|
|
|
# To handle cancellation, we ensure that `after_callback`s and
|
|
|
|
# `exception_callback`s are always run, since the transaction will complete
|
|
|
|
# on another thread regardless of cancellation.
|
|
|
|
#
|
|
|
|
# We also wait until everything above is done before releasing the
|
|
|
|
# `CancelledError`, so that logging contexts won't get used after they have been
|
|
|
|
# finished.
|
2022-04-22 19:20:06 +02:00
|
|
|
return await delay_cancellation(_runInteraction())
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
async def runWithConnection(
|
2020-10-07 16:15:57 +02:00
|
|
|
self,
|
2021-04-27 14:13:07 +02:00
|
|
|
func: Callable[..., R],
|
2020-10-07 16:15:57 +02:00
|
|
|
*args: Any,
|
|
|
|
db_autocommit: bool = False,
|
2022-01-25 15:14:46 +01:00
|
|
|
isolation_level: Optional[int] = None,
|
2021-04-13 11:41:34 +02:00
|
|
|
**kwargs: Any,
|
2020-08-20 15:00:59 +02:00
|
|
|
) -> R:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Wraps the .runWithConnection() method on the underlying db_pool.
|
|
|
|
|
|
|
|
Arguments:
|
2020-02-27 12:53:40 +01:00
|
|
|
func: callback function, which will be called with a
|
2019-12-04 14:52:46 +01:00
|
|
|
database connection (twisted.enterprise.adbapi.Connection) as
|
|
|
|
its first argument, followed by `args` and `kwargs`.
|
2020-02-27 12:53:40 +01:00
|
|
|
args: positional args to pass to `func`
|
2020-10-07 16:15:57 +02:00
|
|
|
db_autocommit: Whether to run the function in "autocommit" mode,
|
|
|
|
i.e. outside of a transaction. This is useful for transaction
|
|
|
|
that are only a single query. Currently only affects postgres.
|
2022-01-25 15:14:46 +01:00
|
|
|
isolation_level: Set the server isolation level for this transaction.
|
2020-02-27 12:53:40 +01:00
|
|
|
kwargs: named args to pass to `func`
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Returns:
|
2020-08-19 13:09:24 +02:00
|
|
|
The result of func
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-01-05 14:06:55 +01:00
|
|
|
curr_context = current_context()
|
|
|
|
if not curr_context:
|
2019-12-04 14:52:46 +01:00
|
|
|
logger.warning(
|
|
|
|
"Starting db connection from sentinel context: metrics will be lost"
|
|
|
|
)
|
|
|
|
parent_context = None
|
2021-01-05 14:06:55 +01:00
|
|
|
else:
|
|
|
|
assert isinstance(curr_context, LoggingContext)
|
|
|
|
parent_context = curr_context
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
start_time = monotonic_time()
|
|
|
|
|
|
|
|
def inner_func(conn, *args, **kwargs):
|
2020-10-07 16:15:57 +02:00
|
|
|
# We shouldn't be in a transaction. If we are then something
|
|
|
|
# somewhere hasn't committed after doing work. (This is likely only
|
|
|
|
# possible during startup, as `run*` will ensure changes are
|
|
|
|
# committed/rolled back before putting the connection back in the
|
|
|
|
# pool).
|
|
|
|
assert not self.engine.in_transaction(conn)
|
|
|
|
|
2021-04-28 13:44:52 +02:00
|
|
|
with LoggingContext(
|
|
|
|
str(curr_context), parent_context=parent_context
|
|
|
|
) as context:
|
2021-06-03 17:31:56 +02:00
|
|
|
with opentracing.start_active_span(
|
|
|
|
operation_name="db.connection",
|
|
|
|
):
|
|
|
|
sched_duration_sec = monotonic_time() - start_time
|
|
|
|
sql_scheduling_timer.observe(sched_duration_sec)
|
|
|
|
context.add_database_scheduled(sched_duration_sec)
|
|
|
|
|
2021-08-02 15:24:43 +02:00
|
|
|
if self._txn_limit > 0:
|
|
|
|
tid = self._db_pool.threadID()
|
|
|
|
self._txn_counters[tid] += 1
|
|
|
|
|
|
|
|
if self._txn_counters[tid] > self._txn_limit:
|
|
|
|
logger.debug(
|
|
|
|
"Reconnecting database connection over transaction limit"
|
|
|
|
)
|
|
|
|
conn.reconnect()
|
|
|
|
opentracing.log_kv(
|
|
|
|
{"message": "reconnected due to txn limit"}
|
|
|
|
)
|
|
|
|
self._txn_counters[tid] = 1
|
|
|
|
|
2021-06-03 17:31:56 +02:00
|
|
|
if self.engine.is_connection_closed(conn):
|
|
|
|
logger.debug("Reconnecting closed database connection")
|
|
|
|
conn.reconnect()
|
|
|
|
opentracing.log_kv({"message": "reconnected"})
|
2021-08-02 15:24:43 +02:00
|
|
|
if self._txn_limit > 0:
|
|
|
|
self._txn_counters[tid] = 1
|
2021-06-03 17:31:56 +02:00
|
|
|
|
|
|
|
try:
|
|
|
|
if db_autocommit:
|
|
|
|
self.engine.attempt_to_set_autocommit(conn, True)
|
2022-01-25 15:14:46 +01:00
|
|
|
if isolation_level is not None:
|
|
|
|
self.engine.attempt_to_set_isolation_level(
|
|
|
|
conn, isolation_level
|
|
|
|
)
|
2021-06-03 17:31:56 +02:00
|
|
|
|
|
|
|
db_conn = LoggingDatabaseConnection(
|
|
|
|
conn, self.engine, "runWithConnection"
|
|
|
|
)
|
|
|
|
return func(db_conn, *args, **kwargs)
|
|
|
|
finally:
|
|
|
|
if db_autocommit:
|
|
|
|
self.engine.attempt_to_set_autocommit(conn, False)
|
2022-01-25 15:14:46 +01:00
|
|
|
if isolation_level:
|
|
|
|
self.engine.attempt_to_set_isolation_level(conn, None)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-08-19 13:09:24 +02:00
|
|
|
return await make_deferred_yieldable(
|
2019-12-04 14:52:46 +01:00
|
|
|
self._db_pool.runWithConnection(inner_func, *args, **kwargs)
|
|
|
|
)
|
|
|
|
|
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def cursor_to_dict(cursor: Cursor) -> List[Dict[str, Any]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Converts a SQL cursor into an list of dicts.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
cursor: The DBAPI cursor which has executed a query.
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
|
|
|
A list of dicts where the key is the column header.
|
|
|
|
"""
|
2021-02-05 21:39:19 +01:00
|
|
|
assert cursor.description is not None, "cursor.description was None"
|
2020-02-21 13:15:07 +01:00
|
|
|
col_headers = [intern(str(column[0])) for column in cursor.description]
|
|
|
|
results = [dict(zip(col_headers, row)) for row in cursor]
|
2019-12-04 14:52:46 +01:00
|
|
|
return results
|
|
|
|
|
2020-09-02 18:52:38 +02:00
|
|
|
@overload
|
|
|
|
async def execute(
|
|
|
|
self, desc: str, decoder: Literal[None], query: str, *args: Any
|
|
|
|
) -> List[Tuple[Any, ...]]:
|
|
|
|
...
|
|
|
|
|
|
|
|
@overload
|
|
|
|
async def execute(
|
|
|
|
self, desc: str, decoder: Callable[[Cursor], R], query: str, *args: Any
|
|
|
|
) -> R:
|
|
|
|
...
|
|
|
|
|
2020-08-27 13:41:01 +02:00
|
|
|
async def execute(
|
|
|
|
self,
|
|
|
|
desc: str,
|
|
|
|
decoder: Optional[Callable[[Cursor], R]],
|
|
|
|
query: str,
|
2021-04-13 11:41:34 +02:00
|
|
|
*args: Any,
|
2020-08-27 13:41:01 +02:00
|
|
|
) -> R:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Runs a single query for a result set.
|
|
|
|
|
|
|
|
Args:
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2019-12-04 14:52:46 +01:00
|
|
|
decoder - The function which can resolve the cursor results to
|
|
|
|
something meaningful.
|
|
|
|
query - The query string to execute
|
|
|
|
*args - Query args.
|
|
|
|
Returns:
|
2020-08-27 13:41:01 +02:00
|
|
|
The result of decoder(results)
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
|
|
|
|
def interaction(txn):
|
|
|
|
txn.execute(query, args)
|
|
|
|
if decoder:
|
|
|
|
return decoder(txn)
|
|
|
|
else:
|
|
|
|
return txn.fetchall()
|
|
|
|
|
2020-08-27 13:41:01 +02:00
|
|
|
return await self.runInteraction(desc, interaction)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
# "Simple" SQL API methods that operate on a single table with no JOINs,
|
|
|
|
# no complex WHERE clauses, just a dict of values for columns.
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
async def simple_insert(
|
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
values: Dict[str, Any],
|
|
|
|
desc: str = "simple_insert",
|
2021-07-22 13:39:50 +02:00
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes an INSERT query on the named table.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: string giving the table name
|
|
|
|
values: dict of new column names and values for them
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-07-22 13:39:50 +02:00
|
|
|
await self.runInteraction(desc, self.simple_insert_txn, table, values)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_insert_txn(
|
|
|
|
txn: LoggingTransaction, table: str, values: Dict[str, Any]
|
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
keys, vals = zip(*values.items())
|
|
|
|
|
|
|
|
sql = "INSERT INTO %s (%s) VALUES(%s)" % (
|
|
|
|
table,
|
|
|
|
", ".join(k for k in keys),
|
|
|
|
", ".join("?" for _ in keys),
|
|
|
|
)
|
|
|
|
|
|
|
|
txn.execute(sql, vals)
|
|
|
|
|
2020-08-27 13:41:01 +02:00
|
|
|
async def simple_insert_many(
|
2021-12-10 16:02:33 +01:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keys: Collection[str],
|
2021-12-15 18:00:50 +01:00
|
|
|
values: Collection[Collection[Any]],
|
2021-12-10 16:02:33 +01:00
|
|
|
desc: str,
|
|
|
|
) -> None:
|
|
|
|
"""Executes an INSERT query on the named table.
|
|
|
|
|
|
|
|
The input is given as a list of rows, where each row is a list of values.
|
|
|
|
(Actually any iterable is fine.)
|
|
|
|
|
|
|
|
Args:
|
|
|
|
table: string giving the table name
|
|
|
|
keys: list of column names
|
|
|
|
values: for each row, a list of values in the same order as `keys`
|
|
|
|
desc: description of the transaction, for logging and metrics
|
|
|
|
"""
|
|
|
|
await self.runInteraction(
|
2022-01-14 01:44:18 +01:00
|
|
|
desc, self.simple_insert_many_txn, table, keys, values
|
2021-12-10 16:02:33 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
@staticmethod
|
2022-01-14 01:44:18 +01:00
|
|
|
def simple_insert_many_txn(
|
2021-12-10 16:02:33 +01:00
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keys: Collection[str],
|
|
|
|
values: Iterable[Iterable[Any]],
|
|
|
|
) -> None:
|
|
|
|
"""Executes an INSERT query on the named table.
|
|
|
|
|
|
|
|
The input is given as a list of rows, where each row is a list of values.
|
|
|
|
(Actually any iterable is fine.)
|
|
|
|
|
|
|
|
Args:
|
|
|
|
txn: The transaction to use.
|
|
|
|
table: string giving the table name
|
|
|
|
keys: list of column names
|
|
|
|
values: for each row, a list of values in the same order as `keys`
|
|
|
|
"""
|
|
|
|
|
2021-09-03 17:35:49 +02:00
|
|
|
if isinstance(txn.database_engine, PostgresEngine):
|
|
|
|
# We use `execute_values` as it can be a lot faster than `execute_batch`,
|
|
|
|
# but it's only available on postgres.
|
|
|
|
sql = "INSERT INTO %s (%s) VALUES ?" % (
|
|
|
|
table,
|
2021-12-10 16:02:33 +01:00
|
|
|
", ".join(k for k in keys),
|
2021-09-03 17:35:49 +02:00
|
|
|
)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2021-12-10 16:02:33 +01:00
|
|
|
txn.execute_values(sql, values, fetch=False)
|
2021-09-03 17:35:49 +02:00
|
|
|
else:
|
|
|
|
sql = "INSERT INTO %s (%s) VALUES(%s)" % (
|
|
|
|
table,
|
2021-12-10 16:02:33 +01:00
|
|
|
", ".join(k for k in keys),
|
|
|
|
", ".join("?" for _ in keys),
|
2021-09-03 17:35:49 +02:00
|
|
|
)
|
|
|
|
|
2021-12-10 16:02:33 +01:00
|
|
|
txn.execute_batch(sql, values)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-08-17 18:18:01 +02:00
|
|
|
async def simple_upsert(
|
2019-12-04 14:52:46 +01:00
|
|
|
self,
|
2020-08-20 15:00:59 +02:00
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
values: Dict[str, Any],
|
2021-04-08 23:38:54 +02:00
|
|
|
insertion_values: Optional[Dict[str, Any]] = None,
|
2020-08-20 15:00:59 +02:00
|
|
|
desc: str = "simple_upsert",
|
|
|
|
lock: bool = True,
|
2021-07-22 13:39:50 +02:00
|
|
|
) -> bool:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
|
|
|
|
`lock` should generally be set to True (the default), but can be set
|
|
|
|
to False if either of the following are true:
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 19:07:57 +02:00
|
|
|
1. there is a UNIQUE INDEX on the key columns. In this case a conflict
|
|
|
|
will cause an IntegrityError in which case this function will retry
|
|
|
|
the update.
|
|
|
|
2. we somehow know that we are the only thread which will be updating
|
|
|
|
this table.
|
|
|
|
As an additional note, this parameter only matters for old SQLite versions
|
|
|
|
because we will use native upserts otherwise.
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: The table to upsert into
|
|
|
|
keyvalues: The unique key columns and their new values
|
|
|
|
values: The nonunique columns and their new values
|
|
|
|
insertion_values: additional key/values to use only when inserting
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2020-08-20 15:00:59 +02:00
|
|
|
lock: True to lock the table when doing the upsert.
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
2021-07-22 13:39:50 +02:00
|
|
|
Returns True if a row was inserted or updated (i.e. if `values` is
|
|
|
|
not empty then this always returns True)
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-04-08 23:38:54 +02:00
|
|
|
insertion_values = insertion_values or {}
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
attempts = 0
|
|
|
|
while True:
|
|
|
|
try:
|
2020-10-14 16:50:59 +02:00
|
|
|
# We can autocommit if we are going to use native upserts
|
|
|
|
autocommit = (
|
|
|
|
self.engine.can_native_upsert
|
|
|
|
and table not in self._unsafe_to_upsert_tables
|
|
|
|
)
|
|
|
|
|
2020-08-17 18:18:01 +02:00
|
|
|
return await self.runInteraction(
|
2019-12-04 14:52:46 +01:00
|
|
|
desc,
|
|
|
|
self.simple_upsert_txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
values,
|
|
|
|
insertion_values,
|
|
|
|
lock=lock,
|
2020-10-14 16:50:59 +02:00
|
|
|
db_autocommit=autocommit,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
2019-12-06 14:40:02 +01:00
|
|
|
except self.engine.module.IntegrityError as e:
|
2019-12-04 14:52:46 +01:00
|
|
|
attempts += 1
|
|
|
|
if attempts >= 5:
|
|
|
|
# don't retry forever, because things other than races
|
|
|
|
# can cause IntegrityErrors
|
|
|
|
raise
|
|
|
|
|
|
|
|
# presumably we raced with another transaction: let's retry.
|
|
|
|
logger.warning(
|
|
|
|
"IntegrityError when upserting into %s; retrying: %s", table, e
|
|
|
|
)
|
|
|
|
|
|
|
|
def simple_upsert_txn(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
values: Dict[str, Any],
|
2021-04-08 23:38:54 +02:00
|
|
|
insertion_values: Optional[Dict[str, Any]] = None,
|
2020-08-20 15:00:59 +02:00
|
|
|
lock: bool = True,
|
2021-07-22 13:39:50 +02:00
|
|
|
) -> bool:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
Pick the UPSERT method which works best on the platform. Either the
|
|
|
|
native one (Pg9.5+, recent SQLites), or fall back to an emulated method.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
txn: The transaction to use.
|
2020-08-20 15:00:59 +02:00
|
|
|
table: The table to upsert into
|
|
|
|
keyvalues: The unique key tables and their new values
|
|
|
|
values: The nonunique columns and their new values
|
|
|
|
insertion_values: additional key/values to use only when inserting
|
|
|
|
lock: True to lock the table when doing the upsert.
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
2021-07-22 13:39:50 +02:00
|
|
|
Returns True if a row was inserted or updated (i.e. if `values` is
|
|
|
|
not empty then this always returns True)
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-04-08 23:38:54 +02:00
|
|
|
insertion_values = insertion_values or {}
|
|
|
|
|
2019-12-06 14:40:02 +01:00
|
|
|
if self.engine.can_native_upsert and table not in self._unsafe_to_upsert_tables:
|
2021-07-22 13:39:50 +02:00
|
|
|
return self.simple_upsert_txn_native_upsert(
|
2019-12-04 14:52:46 +01:00
|
|
|
txn, table, keyvalues, values, insertion_values=insertion_values
|
|
|
|
)
|
|
|
|
else:
|
|
|
|
return self.simple_upsert_txn_emulated(
|
|
|
|
txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
values,
|
|
|
|
insertion_values=insertion_values,
|
|
|
|
lock=lock,
|
|
|
|
)
|
|
|
|
|
|
|
|
def simple_upsert_txn_emulated(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
values: Dict[str, Any],
|
2021-04-08 23:38:54 +02:00
|
|
|
insertion_values: Optional[Dict[str, Any]] = None,
|
2020-08-20 15:00:59 +02:00
|
|
|
lock: bool = True,
|
|
|
|
) -> bool:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: The table to upsert into
|
|
|
|
keyvalues: The unique key tables and their new values
|
|
|
|
values: The nonunique columns and their new values
|
|
|
|
insertion_values: additional key/values to use only when inserting
|
|
|
|
lock: True to lock the table when doing the upsert.
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
2021-07-22 13:39:50 +02:00
|
|
|
Returns True if a row was inserted or updated (i.e. if `values` is
|
|
|
|
not empty then this always returns True)
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-04-08 23:38:54 +02:00
|
|
|
insertion_values = insertion_values or {}
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
# We need to lock the table :(, unless we're *really* careful
|
|
|
|
if lock:
|
2019-12-06 14:40:02 +01:00
|
|
|
self.engine.lock_table(txn, table)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-05-12 16:33:50 +02:00
|
|
|
def _getwhere(key: str) -> str:
|
2019-12-04 14:52:46 +01:00
|
|
|
# If the value we're passing in is None (aka NULL), we need to use
|
|
|
|
# IS, not =, as NULL = NULL equals NULL (False).
|
|
|
|
if keyvalues[key] is None:
|
|
|
|
return "%s IS ?" % (key,)
|
|
|
|
else:
|
|
|
|
return "%s = ?" % (key,)
|
|
|
|
|
|
|
|
if not values:
|
|
|
|
# If `values` is empty, then all of the values we care about are in
|
|
|
|
# the unique key, so there is nothing to UPDATE. We can just do a
|
|
|
|
# SELECT instead to see if it exists.
|
|
|
|
sql = "SELECT 1 FROM %s WHERE %s" % (
|
|
|
|
table,
|
|
|
|
" AND ".join(_getwhere(k) for k in keyvalues),
|
|
|
|
)
|
|
|
|
sqlargs = list(keyvalues.values())
|
|
|
|
txn.execute(sql, sqlargs)
|
|
|
|
if txn.fetchall():
|
|
|
|
# We have an existing record.
|
|
|
|
return False
|
|
|
|
else:
|
|
|
|
# First try to update.
|
|
|
|
sql = "UPDATE %s SET %s WHERE %s" % (
|
|
|
|
table,
|
|
|
|
", ".join("%s = ?" % (k,) for k in values),
|
|
|
|
" AND ".join(_getwhere(k) for k in keyvalues),
|
|
|
|
)
|
|
|
|
sqlargs = list(values.values()) + list(keyvalues.values())
|
|
|
|
|
|
|
|
txn.execute(sql, sqlargs)
|
|
|
|
if txn.rowcount > 0:
|
2021-07-22 13:39:50 +02:00
|
|
|
return True
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
# We didn't find any existing rows, so insert a new one
|
2021-07-15 18:46:54 +02:00
|
|
|
allvalues: Dict[str, Any] = {}
|
2019-12-04 14:52:46 +01:00
|
|
|
allvalues.update(keyvalues)
|
|
|
|
allvalues.update(values)
|
|
|
|
allvalues.update(insertion_values)
|
|
|
|
|
|
|
|
sql = "INSERT INTO %s (%s) VALUES (%s)" % (
|
|
|
|
table,
|
|
|
|
", ".join(k for k in allvalues),
|
|
|
|
", ".join("?" for _ in allvalues),
|
|
|
|
)
|
|
|
|
txn.execute(sql, list(allvalues.values()))
|
|
|
|
# successfully inserted
|
|
|
|
return True
|
|
|
|
|
|
|
|
def simple_upsert_txn_native_upsert(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
values: Dict[str, Any],
|
2021-04-08 23:38:54 +02:00
|
|
|
insertion_values: Optional[Dict[str, Any]] = None,
|
2021-07-22 13:39:50 +02:00
|
|
|
) -> bool:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-07-22 13:39:50 +02:00
|
|
|
Use the native UPSERT functionality in PostgreSQL.
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: The table to upsert into
|
|
|
|
keyvalues: The unique key tables and their new values
|
|
|
|
values: The nonunique columns and their new values
|
|
|
|
insertion_values: additional key/values to use only when inserting
|
2021-07-22 13:39:50 +02:00
|
|
|
|
|
|
|
Returns:
|
|
|
|
Returns True if a row was inserted or updated (i.e. if `values` is
|
|
|
|
not empty then this always returns True)
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-07-15 18:46:54 +02:00
|
|
|
allvalues: Dict[str, Any] = {}
|
2019-12-04 14:52:46 +01:00
|
|
|
allvalues.update(keyvalues)
|
2021-04-08 23:38:54 +02:00
|
|
|
allvalues.update(insertion_values or {})
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
if not values:
|
|
|
|
latter = "NOTHING"
|
|
|
|
else:
|
|
|
|
allvalues.update(values)
|
|
|
|
latter = "UPDATE SET " + ", ".join(k + "=EXCLUDED." + k for k in values)
|
|
|
|
|
|
|
|
sql = ("INSERT INTO %s (%s) VALUES (%s) ON CONFLICT (%s) DO %s") % (
|
|
|
|
table,
|
|
|
|
", ".join(k for k in allvalues),
|
|
|
|
", ".join("?" for _ in allvalues),
|
|
|
|
", ".join(k for k in keyvalues),
|
|
|
|
latter,
|
|
|
|
)
|
|
|
|
txn.execute(sql, list(allvalues.values()))
|
|
|
|
|
2021-07-22 13:39:50 +02:00
|
|
|
return bool(txn.rowcount)
|
|
|
|
|
2020-10-14 16:50:59 +02:00
|
|
|
async def simple_upsert_many(
|
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
key_names: Collection[str],
|
2021-12-13 20:01:27 +01:00
|
|
|
key_values: Collection[Collection[Any]],
|
2020-10-14 16:50:59 +02:00
|
|
|
value_names: Collection[str],
|
2021-12-13 20:01:27 +01:00
|
|
|
value_values: Collection[Collection[Any]],
|
2020-10-14 16:50:59 +02:00
|
|
|
desc: str,
|
2022-04-08 16:29:13 +02:00
|
|
|
lock: bool = True,
|
2020-10-14 16:50:59 +02:00
|
|
|
) -> None:
|
|
|
|
"""
|
|
|
|
Upsert, many times.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
table: The table to upsert into
|
|
|
|
key_names: The key column names.
|
|
|
|
key_values: A list of each row's key column values.
|
|
|
|
value_names: The value column names
|
|
|
|
value_values: A list of each row's value column values.
|
|
|
|
Ignored if value_names is empty.
|
2022-04-08 16:29:13 +02:00
|
|
|
lock: True to lock the table when doing the upsert. Unused if the database engine
|
|
|
|
supports native upserts.
|
2020-10-14 16:50:59 +02:00
|
|
|
"""
|
|
|
|
|
|
|
|
# We can autocommit if we are going to use native upserts
|
|
|
|
autocommit = (
|
|
|
|
self.engine.can_native_upsert and table not in self._unsafe_to_upsert_tables
|
|
|
|
)
|
|
|
|
|
2022-04-08 16:29:13 +02:00
|
|
|
await self.runInteraction(
|
2020-10-14 16:50:59 +02:00
|
|
|
desc,
|
|
|
|
self.simple_upsert_many_txn,
|
|
|
|
table,
|
|
|
|
key_names,
|
|
|
|
key_values,
|
|
|
|
value_names,
|
|
|
|
value_values,
|
2022-04-08 16:29:13 +02:00
|
|
|
lock=lock,
|
2020-10-14 16:50:59 +02:00
|
|
|
db_autocommit=autocommit,
|
|
|
|
)
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
def simple_upsert_many_txn(
|
2020-05-06 02:08:15 +02:00
|
|
|
self,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
key_names: Collection[str],
|
|
|
|
key_values: Collection[Iterable[Any]],
|
|
|
|
value_names: Collection[str],
|
2020-09-04 13:22:23 +02:00
|
|
|
value_values: Iterable[Iterable[Any]],
|
2022-04-08 16:29:13 +02:00
|
|
|
lock: bool = True,
|
2020-05-06 02:08:15 +02:00
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
Upsert, many times.
|
|
|
|
|
|
|
|
Args:
|
2020-05-06 02:08:15 +02:00
|
|
|
table: The table to upsert into
|
|
|
|
key_names: The key column names.
|
|
|
|
key_values: A list of each row's key column values.
|
|
|
|
value_names: The value column names
|
|
|
|
value_values: A list of each row's value column values.
|
|
|
|
Ignored if value_names is empty.
|
2022-04-08 16:29:13 +02:00
|
|
|
lock: True to lock the table when doing the upsert. Unused if the database engine
|
|
|
|
supports native upserts.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2019-12-06 14:40:02 +01:00
|
|
|
if self.engine.can_native_upsert and table not in self._unsafe_to_upsert_tables:
|
2019-12-04 14:52:46 +01:00
|
|
|
return self.simple_upsert_many_txn_native_upsert(
|
|
|
|
txn, table, key_names, key_values, value_names, value_values
|
|
|
|
)
|
|
|
|
else:
|
|
|
|
return self.simple_upsert_many_txn_emulated(
|
2022-04-08 16:29:13 +02:00
|
|
|
txn, table, key_names, key_values, value_names, value_values, lock=lock
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
def simple_upsert_many_txn_emulated(
|
2020-05-06 02:08:15 +02:00
|
|
|
self,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
key_names: Iterable[str],
|
|
|
|
key_values: Collection[Iterable[Any]],
|
|
|
|
value_names: Collection[str],
|
2020-09-04 13:22:23 +02:00
|
|
|
value_values: Iterable[Iterable[Any]],
|
2022-04-08 16:29:13 +02:00
|
|
|
lock: bool = True,
|
2020-05-06 02:08:15 +02:00
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
Upsert, many times, but without native UPSERT support or batching.
|
|
|
|
|
|
|
|
Args:
|
2020-05-06 02:08:15 +02:00
|
|
|
table: The table to upsert into
|
|
|
|
key_names: The key column names.
|
|
|
|
key_values: A list of each row's key column values.
|
|
|
|
value_names: The value column names
|
|
|
|
value_values: A list of each row's value column values.
|
|
|
|
Ignored if value_names is empty.
|
2022-04-08 16:29:13 +02:00
|
|
|
lock: True to lock the table when doing the upsert.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
# No value columns, therefore make a blank list so that the following
|
|
|
|
# zip() works correctly.
|
|
|
|
if not value_names:
|
|
|
|
value_values = [() for x in range(len(key_values))]
|
|
|
|
|
2022-04-08 16:29:13 +02:00
|
|
|
if lock:
|
|
|
|
# Lock the table just once, to prevent it being done once per row.
|
|
|
|
# Note that, according to Postgres' documentation, once obtained,
|
|
|
|
# the lock is held for the remainder of the current transaction.
|
|
|
|
self.engine.lock_table(txn, "user_ips")
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
for keyv, valv in zip(key_values, value_values):
|
|
|
|
_keys = {x: y for x, y in zip(key_names, keyv)}
|
|
|
|
_vals = {x: y for x, y in zip(value_names, valv)}
|
|
|
|
|
2022-04-08 16:29:13 +02:00
|
|
|
self.simple_upsert_txn_emulated(txn, table, _keys, _vals, lock=False)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
def simple_upsert_many_txn_native_upsert(
|
2020-05-06 02:08:15 +02:00
|
|
|
self,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
key_names: Collection[str],
|
|
|
|
key_values: Collection[Iterable[Any]],
|
|
|
|
value_names: Collection[str],
|
|
|
|
value_values: Iterable[Iterable[Any]],
|
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
Upsert, many times, using batching where possible.
|
|
|
|
|
|
|
|
Args:
|
2020-05-06 02:08:15 +02:00
|
|
|
table: The table to upsert into
|
|
|
|
key_names: The key column names.
|
|
|
|
key_values: A list of each row's key column values.
|
|
|
|
value_names: The value column names
|
|
|
|
value_values: A list of each row's value column values.
|
|
|
|
Ignored if value_names is empty.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-07-15 18:46:54 +02:00
|
|
|
allnames: List[str] = []
|
2019-12-04 14:52:46 +01:00
|
|
|
allnames.extend(key_names)
|
|
|
|
allnames.extend(value_names)
|
|
|
|
|
|
|
|
if not value_names:
|
|
|
|
# No value columns, therefore make a blank list so that the
|
|
|
|
# following zip() works correctly.
|
|
|
|
latter = "NOTHING"
|
|
|
|
value_values = [() for x in range(len(key_values))]
|
|
|
|
else:
|
|
|
|
latter = "UPDATE SET " + ", ".join(
|
|
|
|
k + "=EXCLUDED." + k for k in value_names
|
|
|
|
)
|
|
|
|
|
|
|
|
args = []
|
|
|
|
|
|
|
|
for x, y in zip(key_values, value_values):
|
|
|
|
args.append(tuple(x) + tuple(y))
|
|
|
|
|
2021-09-03 17:35:49 +02:00
|
|
|
if isinstance(txn.database_engine, PostgresEngine):
|
|
|
|
# We use `execute_values` as it can be a lot faster than `execute_batch`,
|
|
|
|
# but it's only available on postgres.
|
|
|
|
sql = "INSERT INTO %s (%s) VALUES ? ON CONFLICT (%s) DO %s" % (
|
|
|
|
table,
|
|
|
|
", ".join(k for k in allnames),
|
|
|
|
", ".join(key_names),
|
|
|
|
latter,
|
|
|
|
)
|
|
|
|
|
|
|
|
txn.execute_values(sql, args, fetch=False)
|
|
|
|
|
|
|
|
else:
|
|
|
|
sql = "INSERT INTO %s (%s) VALUES (%s) ON CONFLICT (%s) DO %s" % (
|
|
|
|
table,
|
|
|
|
", ".join(k for k in allnames),
|
|
|
|
", ".join("?" for _ in allnames),
|
|
|
|
", ".join(key_names),
|
|
|
|
latter,
|
|
|
|
)
|
|
|
|
|
|
|
|
return txn.execute_batch(sql, args)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-08-26 13:19:32 +02:00
|
|
|
@overload
|
|
|
|
async def simple_select_one(
|
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2021-12-15 18:00:50 +01:00
|
|
|
retcols: Collection[str],
|
2020-08-26 13:19:32 +02:00
|
|
|
allow_none: Literal[False] = False,
|
|
|
|
desc: str = "simple_select_one",
|
|
|
|
) -> Dict[str, Any]:
|
|
|
|
...
|
|
|
|
|
|
|
|
@overload
|
|
|
|
async def simple_select_one(
|
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2021-12-15 18:00:50 +01:00
|
|
|
retcols: Collection[str],
|
2020-08-26 13:19:32 +02:00
|
|
|
allow_none: Literal[True] = True,
|
|
|
|
desc: str = "simple_select_one",
|
|
|
|
) -> Optional[Dict[str, Any]]:
|
|
|
|
...
|
|
|
|
|
|
|
|
async def simple_select_one(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2021-12-15 18:00:50 +01:00
|
|
|
retcols: Collection[str],
|
2020-08-20 15:00:59 +02:00
|
|
|
allow_none: bool = False,
|
|
|
|
desc: str = "simple_select_one",
|
2020-08-26 13:19:32 +02:00
|
|
|
) -> Optional[Dict[str, Any]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which is expected to
|
|
|
|
return a single row, returning multiple columns from it.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: string giving the table name
|
|
|
|
keyvalues: dict of column names and values to select the row with
|
|
|
|
retcols: list of strings giving the names of the columns to return
|
|
|
|
allow_none: If true, return None instead of failing if the SELECT
|
|
|
|
statement returns no rows
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2020-08-26 13:19:32 +02:00
|
|
|
return await self.runInteraction(
|
2020-10-14 16:50:59 +02:00
|
|
|
desc,
|
|
|
|
self.simple_select_one_txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
retcols,
|
|
|
|
allow_none,
|
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
2020-09-02 18:52:38 +02:00
|
|
|
@overload
|
|
|
|
async def simple_select_one_onecol(
|
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2020-09-04 13:02:29 +02:00
|
|
|
retcol: str,
|
2020-09-02 18:52:38 +02:00
|
|
|
allow_none: Literal[False] = False,
|
|
|
|
desc: str = "simple_select_one_onecol",
|
|
|
|
) -> Any:
|
|
|
|
...
|
|
|
|
|
|
|
|
@overload
|
|
|
|
async def simple_select_one_onecol(
|
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2020-09-04 13:02:29 +02:00
|
|
|
retcol: str,
|
2020-09-02 18:52:38 +02:00
|
|
|
allow_none: Literal[True] = True,
|
|
|
|
desc: str = "simple_select_one_onecol",
|
|
|
|
) -> Optional[Any]:
|
|
|
|
...
|
|
|
|
|
2020-08-26 13:19:32 +02:00
|
|
|
async def simple_select_one_onecol(
|
2019-12-04 14:52:46 +01:00
|
|
|
self,
|
2020-08-20 15:00:59 +02:00
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2020-09-04 13:02:29 +02:00
|
|
|
retcol: str,
|
2020-08-20 15:00:59 +02:00
|
|
|
allow_none: bool = False,
|
|
|
|
desc: str = "simple_select_one_onecol",
|
2020-08-26 13:19:32 +02:00
|
|
|
) -> Optional[Any]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which is expected to
|
|
|
|
return a single row, returning a single column from it.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: string giving the table name
|
|
|
|
keyvalues: dict of column names and values to select the row with
|
|
|
|
retcol: string giving the name of the column to return
|
|
|
|
allow_none: If true, return None instead of failing if the SELECT
|
|
|
|
statement returns no rows
|
|
|
|
desc: description of the transaction, for logging and metrics
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2020-08-26 13:19:32 +02:00
|
|
|
return await self.runInteraction(
|
2019-12-04 14:52:46 +01:00
|
|
|
desc,
|
|
|
|
self.simple_select_one_onecol_txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
retcol,
|
|
|
|
allow_none=allow_none,
|
2020-10-14 16:50:59 +02:00
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
2020-09-02 21:03:12 +02:00
|
|
|
@overload
|
|
|
|
@classmethod
|
|
|
|
def simple_select_one_onecol_txn(
|
|
|
|
cls,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2020-09-04 13:02:29 +02:00
|
|
|
retcol: str,
|
2020-09-02 21:03:12 +02:00
|
|
|
allow_none: Literal[False] = False,
|
|
|
|
) -> Any:
|
|
|
|
...
|
|
|
|
|
|
|
|
@overload
|
|
|
|
@classmethod
|
|
|
|
def simple_select_one_onecol_txn(
|
|
|
|
cls,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2020-09-04 13:02:29 +02:00
|
|
|
retcol: str,
|
2020-09-02 21:03:12 +02:00
|
|
|
allow_none: Literal[True] = True,
|
|
|
|
) -> Optional[Any]:
|
|
|
|
...
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
@classmethod
|
|
|
|
def simple_select_one_onecol_txn(
|
2020-08-20 15:00:59 +02:00
|
|
|
cls,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2020-09-04 13:02:29 +02:00
|
|
|
retcol: str,
|
2020-08-20 15:00:59 +02:00
|
|
|
allow_none: bool = False,
|
|
|
|
) -> Optional[Any]:
|
2019-12-04 14:52:46 +01:00
|
|
|
ret = cls.simple_select_onecol_txn(
|
|
|
|
txn, table=table, keyvalues=keyvalues, retcol=retcol
|
|
|
|
)
|
|
|
|
|
|
|
|
if ret:
|
|
|
|
return ret[0]
|
|
|
|
else:
|
|
|
|
if allow_none:
|
|
|
|
return None
|
|
|
|
else:
|
|
|
|
raise StoreError(404, "No row found")
|
|
|
|
|
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_select_onecol_txn(
|
2021-02-16 23:32:34 +01:00
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
retcol: str,
|
2020-08-20 15:00:59 +02:00
|
|
|
) -> List[Any]:
|
2019-12-04 14:52:46 +01:00
|
|
|
sql = ("SELECT %(retcol)s FROM %(table)s") % {"retcol": retcol, "table": table}
|
|
|
|
|
|
|
|
if keyvalues:
|
2020-06-15 13:03:36 +02:00
|
|
|
sql += " WHERE %s" % " AND ".join("%s = ?" % k for k in keyvalues.keys())
|
2019-12-04 14:52:46 +01:00
|
|
|
txn.execute(sql, list(keyvalues.values()))
|
|
|
|
else:
|
|
|
|
txn.execute(sql)
|
|
|
|
|
|
|
|
return [r[0] for r in txn]
|
|
|
|
|
2020-08-27 13:08:38 +02:00
|
|
|
async def simple_select_onecol(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Optional[Dict[str, Any]],
|
|
|
|
retcol: str,
|
|
|
|
desc: str = "simple_select_onecol",
|
2020-08-27 13:08:38 +02:00
|
|
|
) -> List[Any]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which returns a list
|
|
|
|
comprising of the values of the named column from the selected rows.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: table name
|
|
|
|
keyvalues: column names and values to select the rows with
|
|
|
|
retcol: column whos value we wish to retrieve.
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Returns:
|
2020-08-27 13:08:38 +02:00
|
|
|
Results in a list
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2020-08-27 13:08:38 +02:00
|
|
|
return await self.runInteraction(
|
2020-10-14 16:50:59 +02:00
|
|
|
desc,
|
|
|
|
self.simple_select_onecol_txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
retcol,
|
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
2020-08-27 13:08:38 +02:00
|
|
|
async def simple_select_list(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Optional[Dict[str, Any]],
|
2021-12-15 18:00:50 +01:00
|
|
|
retcols: Collection[str],
|
2020-08-20 15:00:59 +02:00
|
|
|
desc: str = "simple_select_list",
|
2020-08-27 13:08:38 +02:00
|
|
|
) -> List[Dict[str, Any]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which may return zero or
|
|
|
|
more rows, returning the result as a list of dicts.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: the table name
|
|
|
|
keyvalues:
|
2019-12-04 14:52:46 +01:00
|
|
|
column names and values to select the rows with, or None to not
|
|
|
|
apply a WHERE clause.
|
2020-08-20 15:00:59 +02:00
|
|
|
retcols: the names of the columns to return
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2020-08-27 13:08:38 +02:00
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
2020-08-27 13:08:38 +02:00
|
|
|
A list of dictionaries.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2020-08-27 13:08:38 +02:00
|
|
|
return await self.runInteraction(
|
2020-10-14 16:50:59 +02:00
|
|
|
desc,
|
|
|
|
self.simple_select_list_txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
retcols,
|
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
@classmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_select_list_txn(
|
|
|
|
cls,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Optional[Dict[str, Any]],
|
|
|
|
retcols: Iterable[str],
|
|
|
|
) -> List[Dict[str, Any]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which may return zero or
|
|
|
|
more rows, returning the result as a list of dicts.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
txn: Transaction object
|
|
|
|
table: the table name
|
|
|
|
keyvalues:
|
2019-12-04 14:52:46 +01:00
|
|
|
column names and values to select the rows with, or None to not
|
|
|
|
apply a WHERE clause.
|
2020-08-20 15:00:59 +02:00
|
|
|
retcols: the names of the columns to return
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
if keyvalues:
|
|
|
|
sql = "SELECT %s FROM %s WHERE %s" % (
|
|
|
|
", ".join(retcols),
|
|
|
|
table,
|
|
|
|
" AND ".join("%s = ?" % (k,) for k in keyvalues),
|
|
|
|
)
|
|
|
|
txn.execute(sql, list(keyvalues.values()))
|
|
|
|
else:
|
|
|
|
sql = "SELECT %s FROM %s" % (", ".join(retcols), table)
|
|
|
|
txn.execute(sql)
|
|
|
|
|
|
|
|
return cls.cursor_to_dict(txn)
|
|
|
|
|
2020-08-17 18:18:01 +02:00
|
|
|
async def simple_select_many_batch(
|
2019-12-04 14:52:46 +01:00
|
|
|
self,
|
2020-08-20 15:00:59 +02:00
|
|
|
table: str,
|
|
|
|
column: str,
|
|
|
|
iterable: Iterable[Any],
|
2021-12-15 18:00:50 +01:00
|
|
|
retcols: Collection[str],
|
2021-04-08 23:38:54 +02:00
|
|
|
keyvalues: Optional[Dict[str, Any]] = None,
|
2020-08-20 15:00:59 +02:00
|
|
|
desc: str = "simple_select_many_batch",
|
|
|
|
batch_size: int = 100,
|
|
|
|
) -> List[Any]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which may return zero or
|
|
|
|
more rows, returning the result as a list of dicts.
|
|
|
|
|
2020-08-27 20:16:41 +02:00
|
|
|
Filters rows by whether the value of `column` is in `iterable`.
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: string giving the table name
|
|
|
|
column: column name to test for inclusion against `iterable`
|
|
|
|
iterable: list
|
|
|
|
retcols: list of strings giving the names of the columns to return
|
2020-08-27 20:16:41 +02:00
|
|
|
keyvalues: dict of column names and values to select the rows with
|
|
|
|
desc: description of the transaction, for logging and metrics
|
|
|
|
batch_size: the number of rows for each select query
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-04-08 23:38:54 +02:00
|
|
|
keyvalues = keyvalues or {}
|
|
|
|
|
2021-07-15 18:46:54 +02:00
|
|
|
results: List[Dict[str, Any]] = []
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2021-12-15 18:00:50 +01:00
|
|
|
for chunk in batch_iter(iterable, batch_size):
|
2020-08-17 18:18:01 +02:00
|
|
|
rows = await self.runInteraction(
|
2019-12-04 14:52:46 +01:00
|
|
|
desc,
|
|
|
|
self.simple_select_many_txn,
|
|
|
|
table,
|
|
|
|
column,
|
|
|
|
chunk,
|
|
|
|
keyvalues,
|
|
|
|
retcols,
|
2020-10-14 16:50:59 +02:00
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
results.extend(rows)
|
|
|
|
|
|
|
|
return results
|
|
|
|
|
|
|
|
@classmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_select_many_txn(
|
|
|
|
cls,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
column: str,
|
2021-09-20 11:26:13 +02:00
|
|
|
iterable: Collection[Any],
|
2020-08-20 15:00:59 +02:00
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
retcols: Iterable[str],
|
|
|
|
) -> List[Dict[str, Any]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which may return zero or
|
|
|
|
more rows, returning the result as a list of dicts.
|
|
|
|
|
2020-08-27 20:16:41 +02:00
|
|
|
Filters rows by whether the value of `column` is in `iterable`.
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
txn: Transaction object
|
|
|
|
table: string giving the table name
|
|
|
|
column: column name to test for inclusion against `iterable`
|
|
|
|
iterable: list
|
|
|
|
keyvalues: dict of column names and values to select the rows with
|
|
|
|
retcols: list of strings giving the names of the columns to return
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
if not iterable:
|
|
|
|
return []
|
|
|
|
|
|
|
|
clause, values = make_in_list_sql_clause(txn.database_engine, column, iterable)
|
|
|
|
clauses = [clause]
|
|
|
|
|
2020-06-15 13:03:36 +02:00
|
|
|
for key, value in keyvalues.items():
|
2019-12-04 14:52:46 +01:00
|
|
|
clauses.append("%s = ?" % (key,))
|
|
|
|
values.append(value)
|
|
|
|
|
|
|
|
sql = "SELECT %s FROM %s WHERE %s" % (
|
|
|
|
", ".join(retcols),
|
|
|
|
table,
|
|
|
|
" AND ".join(clauses),
|
|
|
|
)
|
|
|
|
|
|
|
|
txn.execute(sql, values)
|
|
|
|
return cls.cursor_to_dict(txn)
|
|
|
|
|
2020-08-27 13:08:38 +02:00
|
|
|
async def simple_update(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
updatevalues: Dict[str, Any],
|
|
|
|
desc: str,
|
2020-08-27 13:08:38 +02:00
|
|
|
) -> int:
|
|
|
|
return await self.runInteraction(
|
2019-12-04 14:52:46 +01:00
|
|
|
desc, self.simple_update_txn, table, keyvalues, updatevalues
|
|
|
|
)
|
|
|
|
|
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_update_txn(
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
updatevalues: Dict[str, Any],
|
|
|
|
) -> int:
|
2019-12-04 14:52:46 +01:00
|
|
|
if keyvalues:
|
2020-06-15 13:03:36 +02:00
|
|
|
where = "WHERE %s" % " AND ".join("%s = ?" % k for k in keyvalues.keys())
|
2019-12-04 14:52:46 +01:00
|
|
|
else:
|
|
|
|
where = ""
|
|
|
|
|
|
|
|
update_sql = "UPDATE %s SET %s %s" % (
|
|
|
|
table,
|
|
|
|
", ".join("%s = ?" % (k,) for k in updatevalues),
|
|
|
|
where,
|
|
|
|
)
|
|
|
|
|
|
|
|
txn.execute(update_sql, list(updatevalues.values()) + list(keyvalues.values()))
|
|
|
|
|
|
|
|
return txn.rowcount
|
|
|
|
|
2022-04-08 16:29:13 +02:00
|
|
|
async def simple_update_many(
|
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
key_names: Collection[str],
|
|
|
|
key_values: Collection[Iterable[Any]],
|
|
|
|
value_names: Collection[str],
|
|
|
|
value_values: Iterable[Iterable[Any]],
|
|
|
|
desc: str,
|
|
|
|
) -> None:
|
|
|
|
"""
|
|
|
|
Update, many times, using batching where possible.
|
|
|
|
If the keys don't match anything, nothing will be updated.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
table: The table to update
|
|
|
|
key_names: The key column names.
|
|
|
|
key_values: A list of each row's key column values.
|
|
|
|
value_names: The names of value columns to update.
|
|
|
|
value_values: A list of each row's value column values.
|
|
|
|
"""
|
|
|
|
|
|
|
|
await self.runInteraction(
|
|
|
|
desc,
|
|
|
|
self.simple_update_many_txn,
|
|
|
|
table,
|
|
|
|
key_names,
|
|
|
|
key_values,
|
|
|
|
value_names,
|
|
|
|
value_values,
|
|
|
|
)
|
|
|
|
|
|
|
|
@staticmethod
|
|
|
|
def simple_update_many_txn(
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
key_names: Collection[str],
|
|
|
|
key_values: Collection[Iterable[Any]],
|
|
|
|
value_names: Collection[str],
|
|
|
|
value_values: Collection[Iterable[Any]],
|
|
|
|
) -> None:
|
|
|
|
"""
|
|
|
|
Update, many times, using batching where possible.
|
|
|
|
If the keys don't match anything, nothing will be updated.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
table: The table to update
|
|
|
|
key_names: The key column names.
|
|
|
|
key_values: A list of each row's key column values.
|
|
|
|
value_names: The names of value columns to update.
|
|
|
|
value_values: A list of each row's value column values.
|
|
|
|
"""
|
|
|
|
|
|
|
|
if len(value_values) != len(key_values):
|
|
|
|
raise ValueError(
|
|
|
|
f"{len(key_values)} key rows and {len(value_values)} value rows: should be the same number."
|
|
|
|
)
|
|
|
|
|
|
|
|
# List of tuples of (value values, then key values)
|
|
|
|
# (This matches the order needed for the query)
|
|
|
|
args = [tuple(x) + tuple(y) for x, y in zip(value_values, key_values)]
|
|
|
|
|
|
|
|
for ks, vs in zip(key_values, value_values):
|
|
|
|
args.append(tuple(vs) + tuple(ks))
|
|
|
|
|
|
|
|
# 'col1 = ?, col2 = ?, ...'
|
|
|
|
set_clause = ", ".join(f"{n} = ?" for n in value_names)
|
|
|
|
|
|
|
|
if key_names:
|
|
|
|
# 'WHERE col3 = ? AND col4 = ? AND col5 = ?'
|
|
|
|
where_clause = "WHERE " + (" AND ".join(f"{n} = ?" for n in key_names))
|
|
|
|
else:
|
|
|
|
where_clause = ""
|
|
|
|
|
|
|
|
# UPDATE mytable SET col1 = ?, col2 = ? WHERE col3 = ? AND col4 = ?
|
|
|
|
sql = f"""
|
|
|
|
UPDATE {table} SET {set_clause} {where_clause}
|
|
|
|
"""
|
|
|
|
|
|
|
|
txn.execute_batch(sql, args)
|
|
|
|
|
2020-08-27 13:08:38 +02:00
|
|
|
async def simple_update_one(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
updatevalues: Dict[str, Any],
|
|
|
|
desc: str = "simple_update_one",
|
2020-08-27 13:08:38 +02:00
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes an UPDATE query on the named table, setting new values for
|
|
|
|
columns in a row matching the key values.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: string giving the table name
|
|
|
|
keyvalues: dict of column names and values to select the row with
|
|
|
|
updatevalues: dict giving column names and values to update
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2020-08-27 13:08:38 +02:00
|
|
|
await self.runInteraction(
|
2020-10-14 16:50:59 +02:00
|
|
|
desc,
|
|
|
|
self.simple_update_one_txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
updatevalues,
|
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
@classmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_update_one_txn(
|
|
|
|
cls,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
updatevalues: Dict[str, Any],
|
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
rowcount = cls.simple_update_txn(txn, table, keyvalues, updatevalues)
|
|
|
|
|
|
|
|
if rowcount == 0:
|
|
|
|
raise StoreError(404, "No row found (%s)" % (table,))
|
|
|
|
if rowcount > 1:
|
|
|
|
raise StoreError(500, "More than one row matched (%s)" % (table,))
|
|
|
|
|
2020-08-20 15:00:59 +02:00
|
|
|
# Ideally we could use the overload decorator here to specify that the
|
|
|
|
# return type is only optional if allow_none is True, but this does not work
|
|
|
|
# when you call a static method from an instance.
|
|
|
|
# See https://github.com/python/mypy/issues/7781
|
2019-12-04 14:52:46 +01:00
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_select_one_txn(
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
keyvalues: Dict[str, Any],
|
2021-12-15 18:00:50 +01:00
|
|
|
retcols: Collection[str],
|
2020-08-20 15:00:59 +02:00
|
|
|
allow_none: bool = False,
|
|
|
|
) -> Optional[Dict[str, Any]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
select_sql = "SELECT %s FROM %s WHERE %s" % (
|
|
|
|
", ".join(retcols),
|
|
|
|
table,
|
|
|
|
" AND ".join("%s = ?" % (k,) for k in keyvalues),
|
|
|
|
)
|
|
|
|
|
|
|
|
txn.execute(select_sql, list(keyvalues.values()))
|
|
|
|
row = txn.fetchone()
|
|
|
|
|
|
|
|
if not row:
|
|
|
|
if allow_none:
|
|
|
|
return None
|
|
|
|
raise StoreError(404, "No row found (%s)" % (table,))
|
|
|
|
if txn.rowcount > 1:
|
|
|
|
raise StoreError(500, "More than one row matched (%s)" % (table,))
|
|
|
|
|
|
|
|
return dict(zip(retcols, row))
|
|
|
|
|
2020-08-27 13:41:01 +02:00
|
|
|
async def simple_delete_one(
|
2020-08-20 15:00:59 +02:00
|
|
|
self, table: str, keyvalues: Dict[str, Any], desc: str = "simple_delete_one"
|
2020-08-27 13:41:01 +02:00
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a DELETE query on the named table, expecting to delete a
|
|
|
|
single row.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: string giving the table name
|
|
|
|
keyvalues: dict of column names and values to select the row with
|
2020-08-27 20:16:41 +02:00
|
|
|
desc: description of the transaction, for logging and metrics
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2020-10-14 16:50:59 +02:00
|
|
|
await self.runInteraction(
|
2021-02-16 23:32:34 +01:00
|
|
|
desc,
|
|
|
|
self.simple_delete_one_txn,
|
|
|
|
table,
|
|
|
|
keyvalues,
|
|
|
|
db_autocommit=True,
|
2020-10-14 16:50:59 +02:00
|
|
|
)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_delete_one_txn(
|
|
|
|
txn: LoggingTransaction, table: str, keyvalues: Dict[str, Any]
|
|
|
|
) -> None:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a DELETE query on the named table, expecting to delete a
|
|
|
|
single row.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: string giving the table name
|
|
|
|
keyvalues: dict of column names and values to select the row with
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
sql = "DELETE FROM %s WHERE %s" % (
|
|
|
|
table,
|
|
|
|
" AND ".join("%s = ?" % (k,) for k in keyvalues),
|
|
|
|
)
|
|
|
|
|
|
|
|
txn.execute(sql, list(keyvalues.values()))
|
|
|
|
if txn.rowcount == 0:
|
|
|
|
raise StoreError(404, "No row found (%s)" % (table,))
|
|
|
|
if txn.rowcount > 1:
|
|
|
|
raise StoreError(500, "More than one row matched (%s)" % (table,))
|
|
|
|
|
2020-08-27 20:16:41 +02:00
|
|
|
async def simple_delete(
|
|
|
|
self, table: str, keyvalues: Dict[str, Any], desc: str
|
|
|
|
) -> int:
|
|
|
|
"""Executes a DELETE query on the named table.
|
|
|
|
|
|
|
|
Filters rows by the key-value pairs.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
table: string giving the table name
|
|
|
|
keyvalues: dict of column names and values to select the row with
|
|
|
|
desc: description of the transaction, for logging and metrics
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
The number of deleted rows.
|
|
|
|
"""
|
2020-10-14 16:50:59 +02:00
|
|
|
return await self.runInteraction(
|
|
|
|
desc, self.simple_delete_txn, table, keyvalues, db_autocommit=True
|
|
|
|
)
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_delete_txn(
|
|
|
|
txn: LoggingTransaction, table: str, keyvalues: Dict[str, Any]
|
|
|
|
) -> int:
|
2020-08-27 20:16:41 +02:00
|
|
|
"""Executes a DELETE query on the named table.
|
|
|
|
|
|
|
|
Filters rows by the key-value pairs.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
table: string giving the table name
|
|
|
|
keyvalues: dict of column names and values to select the row with
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
The number of deleted rows.
|
|
|
|
"""
|
2019-12-04 14:52:46 +01:00
|
|
|
sql = "DELETE FROM %s WHERE %s" % (
|
|
|
|
table,
|
|
|
|
" AND ".join("%s = ?" % (k,) for k in keyvalues),
|
|
|
|
)
|
|
|
|
|
|
|
|
txn.execute(sql, list(keyvalues.values()))
|
|
|
|
return txn.rowcount
|
|
|
|
|
2020-08-27 13:41:01 +02:00
|
|
|
async def simple_delete_many(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
column: str,
|
2021-12-13 20:01:27 +01:00
|
|
|
iterable: Collection[Any],
|
2020-08-20 15:00:59 +02:00
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
desc: str,
|
2020-08-27 13:41:01 +02:00
|
|
|
) -> int:
|
2020-08-27 20:16:41 +02:00
|
|
|
"""Executes a DELETE query on the named table.
|
|
|
|
|
|
|
|
Filters rows by if value of `column` is in `iterable`.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
table: string giving the table name
|
|
|
|
column: column name to test for inclusion against `iterable`
|
2021-12-13 20:01:27 +01:00
|
|
|
iterable: list of values to match against `column`. NB cannot be a generator
|
|
|
|
as it may be evaluated multiple times.
|
2020-08-27 20:16:41 +02:00
|
|
|
keyvalues: dict of column names and values to select the rows with
|
|
|
|
desc: description of the transaction, for logging and metrics
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
Number rows deleted
|
|
|
|
"""
|
2020-08-27 13:41:01 +02:00
|
|
|
return await self.runInteraction(
|
2020-10-14 16:50:59 +02:00
|
|
|
desc,
|
|
|
|
self.simple_delete_many_txn,
|
|
|
|
table,
|
|
|
|
column,
|
|
|
|
iterable,
|
|
|
|
keyvalues,
|
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
@staticmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_delete_many_txn(
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
column: str,
|
2021-09-20 11:26:13 +02:00
|
|
|
values: Collection[Any],
|
2020-08-20 15:00:59 +02:00
|
|
|
keyvalues: Dict[str, Any],
|
|
|
|
) -> int:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a DELETE query on the named table.
|
|
|
|
|
2021-09-20 11:26:13 +02:00
|
|
|
Deletes the rows:
|
|
|
|
- whose value of `column` is in `values`; AND
|
|
|
|
- that match extra column-value pairs specified in `keyvalues`.
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
txn: Transaction object
|
|
|
|
table: string giving the table name
|
2021-09-20 11:26:13 +02:00
|
|
|
column: column name to test for inclusion against `values`
|
|
|
|
values: values of `column` which choose rows to delete
|
|
|
|
keyvalues: dict of extra column names and values to select the rows
|
|
|
|
with. They will be ANDed together with the main predicate.
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
Returns:
|
2020-08-20 15:00:59 +02:00
|
|
|
Number rows deleted
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
2021-09-20 11:26:13 +02:00
|
|
|
if not values:
|
2019-12-04 14:52:46 +01:00
|
|
|
return 0
|
|
|
|
|
|
|
|
sql = "DELETE FROM %s" % table
|
|
|
|
|
2021-09-20 11:26:13 +02:00
|
|
|
clause, values = make_in_list_sql_clause(txn.database_engine, column, values)
|
2019-12-04 14:52:46 +01:00
|
|
|
clauses = [clause]
|
|
|
|
|
2020-06-15 13:03:36 +02:00
|
|
|
for key, value in keyvalues.items():
|
2019-12-04 14:52:46 +01:00
|
|
|
clauses.append("%s = ?" % (key,))
|
|
|
|
values.append(value)
|
|
|
|
|
|
|
|
if clauses:
|
|
|
|
sql = "%s WHERE %s" % (sql, " AND ".join(clauses))
|
|
|
|
txn.execute(sql, values)
|
|
|
|
|
|
|
|
return txn.rowcount
|
|
|
|
|
|
|
|
def get_cache_dict(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
2020-10-02 16:20:45 +02:00
|
|
|
db_conn: LoggingDatabaseConnection,
|
2020-08-20 15:00:59 +02:00
|
|
|
table: str,
|
|
|
|
entity_column: str,
|
|
|
|
stream_column: str,
|
|
|
|
max_value: int,
|
|
|
|
limit: int = 100000,
|
|
|
|
) -> Tuple[Dict[Any, int], int]:
|
2022-04-05 15:26:41 +02:00
|
|
|
"""Gets roughly the last N changes in the given stream table as a
|
|
|
|
map from entity to the stream ID of the most recent change.
|
|
|
|
|
|
|
|
Also returns the minimum stream ID.
|
|
|
|
"""
|
|
|
|
|
|
|
|
# This may return many rows for the same entity, but the `limit` is only
|
|
|
|
# a suggestion so we don't care that much.
|
|
|
|
#
|
|
|
|
# Note: Some stream tables can have multiple rows with the same stream
|
|
|
|
# ID. Instead of handling this with complicated SQL, we instead simply
|
|
|
|
# add one to the returned minimum stream ID to ensure correctness.
|
|
|
|
sql = f"""
|
|
|
|
SELECT {entity_column}, {stream_column}
|
|
|
|
FROM {table}
|
|
|
|
ORDER BY {stream_column} DESC
|
|
|
|
LIMIT ?
|
|
|
|
"""
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2020-10-02 16:20:45 +02:00
|
|
|
txn = db_conn.cursor(txn_name="get_cache_dict")
|
2022-04-05 15:26:41 +02:00
|
|
|
txn.execute(sql, (limit,))
|
2019-12-04 14:52:46 +01:00
|
|
|
|
2022-04-05 15:26:41 +02:00
|
|
|
# The rows come out in reverse stream ID order, so we want to keep the
|
|
|
|
# stream ID of the first row for each entity.
|
|
|
|
cache: Dict[Any, int] = {}
|
|
|
|
for row in txn:
|
|
|
|
cache.setdefault(row[0], int(row[1]))
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
txn.close()
|
|
|
|
|
|
|
|
if cache:
|
2022-04-05 15:26:41 +02:00
|
|
|
# We add one here as we don't know if we have all rows for the
|
|
|
|
# minimum stream ID.
|
|
|
|
min_val = min(cache.values()) + 1
|
2019-12-04 14:52:46 +01:00
|
|
|
else:
|
|
|
|
min_val = max_value
|
|
|
|
|
|
|
|
return cache, min_val
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
def simple_select_list_paginate_txn(
|
|
|
|
cls,
|
2020-08-20 15:00:59 +02:00
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
orderby: str,
|
|
|
|
start: int,
|
|
|
|
limit: int,
|
|
|
|
retcols: Iterable[str],
|
|
|
|
filters: Optional[Dict[str, Any]] = None,
|
|
|
|
keyvalues: Optional[Dict[str, Any]] = None,
|
2021-03-25 11:34:23 +01:00
|
|
|
exclude_keyvalues: Optional[Dict[str, Any]] = None,
|
2020-08-20 15:00:59 +02:00
|
|
|
order_direction: str = "ASC",
|
|
|
|
) -> List[Dict[str, Any]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
Executes a SELECT query on the named table with start and limit,
|
|
|
|
of row numbers, which may return zero or number of rows from start to limit,
|
|
|
|
returning the result as a list of dicts.
|
|
|
|
|
2019-12-06 12:28:44 +01:00
|
|
|
Use `filters` to search attributes using SQL wildcards and/or `keyvalues` to
|
|
|
|
select attributes with exact matches. All constraints are joined together
|
|
|
|
using 'AND'.
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
txn: Transaction object
|
|
|
|
table: the table name
|
|
|
|
orderby: Column to order the results by.
|
|
|
|
start: Index to begin the query at.
|
|
|
|
limit: Number of results to return.
|
|
|
|
retcols: the names of the columns to return
|
|
|
|
filters:
|
2019-12-06 12:28:44 +01:00
|
|
|
column names and values to filter the rows with, or None to not
|
|
|
|
apply a WHERE ? LIKE ? clause.
|
2020-08-20 15:00:59 +02:00
|
|
|
keyvalues:
|
2019-12-06 12:28:44 +01:00
|
|
|
column names and values to select the rows with, or None to not
|
2021-03-25 11:34:23 +01:00
|
|
|
apply a WHERE key = value clause.
|
|
|
|
exclude_keyvalues:
|
|
|
|
column names and values to exclude rows with, or None to not
|
|
|
|
apply a WHERE key != value clause.
|
2020-08-20 15:00:59 +02:00
|
|
|
order_direction: Whether the results should be ordered "ASC" or "DESC".
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
2020-08-20 15:00:59 +02:00
|
|
|
The result as a list of dictionaries.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
if order_direction not in ["ASC", "DESC"]:
|
|
|
|
raise ValueError("order_direction must be one of 'ASC' or 'DESC'.")
|
|
|
|
|
2021-03-25 11:34:23 +01:00
|
|
|
where_clause = "WHERE " if filters or keyvalues or exclude_keyvalues else ""
|
2021-07-15 18:46:54 +02:00
|
|
|
arg_list: List[Any] = []
|
2019-12-06 12:28:44 +01:00
|
|
|
if filters:
|
|
|
|
where_clause += " AND ".join("%s LIKE ?" % (k,) for k in filters)
|
|
|
|
arg_list += list(filters.values())
|
|
|
|
where_clause += " AND " if filters and keyvalues else ""
|
2019-12-04 14:52:46 +01:00
|
|
|
if keyvalues:
|
2019-12-06 12:28:44 +01:00
|
|
|
where_clause += " AND ".join("%s = ?" % (k,) for k in keyvalues)
|
|
|
|
arg_list += list(keyvalues.values())
|
2021-03-25 11:34:23 +01:00
|
|
|
if exclude_keyvalues:
|
|
|
|
where_clause += " AND ".join("%s != ?" % (k,) for k in exclude_keyvalues)
|
|
|
|
arg_list += list(exclude_keyvalues.values())
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
sql = "SELECT %s FROM %s %s ORDER BY %s %s LIMIT ? OFFSET ?" % (
|
|
|
|
", ".join(retcols),
|
|
|
|
table,
|
|
|
|
where_clause,
|
|
|
|
orderby,
|
|
|
|
order_direction,
|
|
|
|
)
|
2019-12-06 12:28:44 +01:00
|
|
|
txn.execute(sql, arg_list + [limit, start])
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
return cls.cursor_to_dict(txn)
|
|
|
|
|
2020-08-27 13:41:01 +02:00
|
|
|
async def simple_search_list(
|
2020-08-20 15:00:59 +02:00
|
|
|
self,
|
|
|
|
table: str,
|
|
|
|
term: Optional[str],
|
|
|
|
col: str,
|
2021-12-15 18:00:50 +01:00
|
|
|
retcols: Collection[str],
|
2022-05-12 16:33:50 +02:00
|
|
|
desc: str = "simple_search_list",
|
2020-08-27 13:41:01 +02:00
|
|
|
) -> Optional[List[Dict[str, Any]]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which may return zero or
|
|
|
|
more rows, returning the result as a list of dicts.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
table: the table name
|
|
|
|
term: term for searching the table matched to a column.
|
|
|
|
col: column to query term should be matched to
|
|
|
|
retcols: the names of the columns to return
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
2020-08-27 13:41:01 +02:00
|
|
|
A list of dictionaries or None.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
|
2020-08-27 13:41:01 +02:00
|
|
|
return await self.runInteraction(
|
2020-10-14 16:50:59 +02:00
|
|
|
desc,
|
|
|
|
self.simple_search_list_txn,
|
|
|
|
table,
|
|
|
|
term,
|
|
|
|
col,
|
|
|
|
retcols,
|
|
|
|
db_autocommit=True,
|
2019-12-04 14:52:46 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
@classmethod
|
2020-08-20 15:00:59 +02:00
|
|
|
def simple_search_list_txn(
|
|
|
|
cls,
|
|
|
|
txn: LoggingTransaction,
|
|
|
|
table: str,
|
|
|
|
term: Optional[str],
|
|
|
|
col: str,
|
|
|
|
retcols: Iterable[str],
|
2020-08-27 18:07:13 +02:00
|
|
|
) -> Optional[List[Dict[str, Any]]]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Executes a SELECT query on the named table, which may return zero or
|
|
|
|
more rows, returning the result as a list of dicts.
|
|
|
|
|
|
|
|
Args:
|
2020-08-20 15:00:59 +02:00
|
|
|
txn: Transaction object
|
|
|
|
table: the table name
|
|
|
|
term: term for searching the table matched to a column.
|
|
|
|
col: column to query term should be matched to
|
|
|
|
retcols: the names of the columns to return
|
|
|
|
|
2019-12-04 14:52:46 +01:00
|
|
|
Returns:
|
2020-08-27 18:07:13 +02:00
|
|
|
None if no term is given, otherwise a list of dictionaries.
|
2019-12-04 14:52:46 +01:00
|
|
|
"""
|
|
|
|
if term:
|
|
|
|
sql = "SELECT %s FROM %s WHERE %s LIKE ?" % (", ".join(retcols), table, col)
|
|
|
|
termvalues = ["%%" + term + "%%"]
|
|
|
|
txn.execute(sql, termvalues)
|
|
|
|
else:
|
2020-08-27 18:07:13 +02:00
|
|
|
return None
|
2019-12-04 14:52:46 +01:00
|
|
|
|
|
|
|
return cls.cursor_to_dict(txn)
|
|
|
|
|
|
|
|
|
|
|
|
def make_in_list_sql_clause(
|
2021-09-20 11:26:13 +02:00
|
|
|
database_engine: BaseDatabaseEngine, column: str, iterable: Collection[Any]
|
2020-02-19 16:47:11 +01:00
|
|
|
) -> Tuple[str, list]:
|
2019-12-04 14:52:46 +01:00
|
|
|
"""Returns an SQL clause that checks the given column is in the iterable.
|
|
|
|
|
|
|
|
On SQLite this expands to `column IN (?, ?, ...)`, whereas on Postgres
|
|
|
|
it expands to `column = ANY(?)`. While both DBs support the `IN` form,
|
|
|
|
using the `ANY` form on postgres means that it views queries with
|
|
|
|
different length iterables as the same, helping the query stats.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
database_engine
|
|
|
|
column: Name of the column
|
|
|
|
iterable: The values to check the column against.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
A tuple of SQL query and the args
|
|
|
|
"""
|
|
|
|
|
|
|
|
if database_engine.supports_using_any_list:
|
|
|
|
# This should hopefully be faster, but also makes postgres query
|
|
|
|
# stats easier to understand.
|
|
|
|
return "%s = ANY(?)" % (column,), [list(iterable)]
|
|
|
|
else:
|
|
|
|
return "%s IN (%s)" % (column, ",".join("?" for _ in iterable)), list(iterable)
|
2020-04-08 00:06:39 +02:00
|
|
|
|
|
|
|
|
|
|
|
KV = TypeVar("KV")
|
|
|
|
|
|
|
|
|
2021-04-08 19:29:57 +02:00
|
|
|
def make_tuple_comparison_clause(keys: List[Tuple[str, KV]]) -> Tuple[str, List[KV]]:
|
2020-04-08 00:06:39 +02:00
|
|
|
"""Returns a tuple comparison SQL clause
|
|
|
|
|
2021-04-08 14:45:19 +02:00
|
|
|
Builds a SQL clause that looks like "(a, b) > (?, ?)"
|
2020-04-08 00:06:39 +02:00
|
|
|
|
|
|
|
Args:
|
|
|
|
keys: A set of (column, value) pairs to be compared.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
A tuple of SQL query and the args
|
|
|
|
"""
|
2021-04-08 14:45:19 +02:00
|
|
|
return (
|
|
|
|
"(%s) > (%s)" % (",".join(k[0] for k in keys), ",".join("?" for _ in keys)),
|
|
|
|
[k[1] for k in keys],
|
|
|
|
)
|