2016-01-07 05:26:29 +01:00
|
|
|
# Copyright 2014-2016 OpenMarket Ltd
|
2019-04-11 18:08:13 +02:00
|
|
|
# Copyright 2018 New Vector Ltd
|
2014-08-12 16:10:52 +02:00
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
2019-10-02 14:29:01 +02:00
|
|
|
|
2018-07-20 13:43:23 +02:00
|
|
|
import collections
|
2020-12-11 20:05:15 +01:00
|
|
|
import inspect
|
2021-06-08 12:07:46 +02:00
|
|
|
import itertools
|
2018-07-09 08:09:20 +02:00
|
|
|
import logging
|
|
|
|
from contextlib import contextmanager
|
2020-09-08 22:50:51 +02:00
|
|
|
from typing import (
|
|
|
|
Any,
|
2020-12-11 20:05:15 +01:00
|
|
|
Awaitable,
|
2020-09-08 22:50:51 +02:00
|
|
|
Callable,
|
|
|
|
Dict,
|
|
|
|
Hashable,
|
|
|
|
Iterable,
|
|
|
|
List,
|
|
|
|
Optional,
|
|
|
|
Set,
|
|
|
|
TypeVar,
|
|
|
|
Union,
|
|
|
|
)
|
2018-07-09 08:09:20 +02:00
|
|
|
|
2019-10-11 16:26:09 +02:00
|
|
|
import attr
|
2020-08-28 22:47:11 +02:00
|
|
|
from typing_extensions import ContextManager
|
2019-10-11 16:26:09 +02:00
|
|
|
|
2018-06-22 10:37:10 +02:00
|
|
|
from twisted.internet import defer
|
2018-04-27 13:52:30 +02:00
|
|
|
from twisted.internet.defer import CancelledError
|
2020-09-08 22:50:51 +02:00
|
|
|
from twisted.internet.interfaces import IReactorTime
|
2018-04-27 13:52:30 +02:00
|
|
|
from twisted.python import failure
|
2014-08-12 16:10:52 +02:00
|
|
|
|
2019-07-03 16:07:04 +02:00
|
|
|
from synapse.logging.context import (
|
2018-07-09 08:09:20 +02:00
|
|
|
PreserveLoggingContext,
|
|
|
|
make_deferred_yieldable,
|
|
|
|
run_in_background,
|
2016-04-07 16:29:34 +02:00
|
|
|
)
|
2019-07-03 16:07:04 +02:00
|
|
|
from synapse.util import Clock, unwrapFirstError
|
2018-04-28 13:57:00 +02:00
|
|
|
|
2016-12-30 21:00:44 +01:00
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
2014-11-20 18:26:36 +01:00
|
|
|
|
2020-09-04 12:54:56 +02:00
|
|
|
class ObservableDeferred:
|
2015-05-08 17:27:36 +02:00
|
|
|
"""Wraps a deferred object so that we can add observer deferreds. These
|
|
|
|
observer deferreds do not affect the callback chain of the original
|
|
|
|
deferred.
|
|
|
|
|
|
|
|
If consumeErrors is true errors will be captured from the origin deferred.
|
2015-06-19 12:48:55 +02:00
|
|
|
|
|
|
|
Cancelling or otherwise resolving an observer will not affect the original
|
|
|
|
ObservableDeferred.
|
2017-10-17 11:59:30 +02:00
|
|
|
|
|
|
|
NB that it does not attempt to do anything with logcontexts; in general
|
|
|
|
you should probably make_deferred_yieldable the deferreds
|
|
|
|
returned by `observe`, and ensure that the original deferred runs its
|
|
|
|
callbacks in the sentinel logcontext.
|
2015-04-27 14:59:37 +02:00
|
|
|
"""
|
|
|
|
|
2015-05-08 17:27:36 +02:00
|
|
|
__slots__ = ["_deferred", "_observers", "_result"]
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def __init__(self, deferred: defer.Deferred, consumeErrors: bool = False):
|
2015-05-08 17:27:36 +02:00
|
|
|
object.__setattr__(self, "_deferred", deferred)
|
|
|
|
object.__setattr__(self, "_result", None)
|
2015-06-18 16:49:05 +02:00
|
|
|
object.__setattr__(self, "_observers", set())
|
2015-05-08 17:27:36 +02:00
|
|
|
|
|
|
|
def callback(r):
|
2015-08-06 14:33:34 +02:00
|
|
|
object.__setattr__(self, "_result", (True, r))
|
2015-05-08 17:27:36 +02:00
|
|
|
while self._observers:
|
2021-03-09 12:09:31 +01:00
|
|
|
observer = self._observers.pop()
|
2015-05-08 17:27:36 +02:00
|
|
|
try:
|
2021-03-09 12:09:31 +01:00
|
|
|
observer.callback(r)
|
|
|
|
except Exception as e:
|
|
|
|
logger.exception(
|
|
|
|
"%r threw an exception on .callback(%r), ignoring...",
|
|
|
|
observer,
|
|
|
|
r,
|
|
|
|
exc_info=e,
|
|
|
|
)
|
2015-05-08 17:27:36 +02:00
|
|
|
return r
|
|
|
|
|
|
|
|
def errback(f):
|
2015-08-06 14:33:34 +02:00
|
|
|
object.__setattr__(self, "_result", (False, f))
|
2015-05-08 17:27:36 +02:00
|
|
|
while self._observers:
|
2020-02-03 18:10:54 +01:00
|
|
|
# This is a little bit of magic to correctly propagate stack
|
|
|
|
# traces when we `await` on one of the observer deferreds.
|
|
|
|
f.value.__failure__ = f
|
|
|
|
|
2021-03-09 12:09:31 +01:00
|
|
|
observer = self._observers.pop()
|
2015-05-08 17:27:36 +02:00
|
|
|
try:
|
2021-03-09 12:09:31 +01:00
|
|
|
observer.errback(f)
|
|
|
|
except Exception as e:
|
|
|
|
logger.exception(
|
|
|
|
"%r threw an exception on .errback(%r), ignoring...",
|
|
|
|
observer,
|
|
|
|
f,
|
|
|
|
exc_info=e,
|
|
|
|
)
|
2015-05-08 17:27:36 +02:00
|
|
|
|
|
|
|
if consumeErrors:
|
|
|
|
return None
|
|
|
|
else:
|
|
|
|
return f
|
|
|
|
|
|
|
|
deferred.addCallbacks(callback, errback)
|
2015-04-27 14:59:37 +02:00
|
|
|
|
2019-10-30 12:35:46 +01:00
|
|
|
def observe(self) -> defer.Deferred:
|
2017-03-30 18:05:53 +02:00
|
|
|
"""Observe the underlying deferred.
|
2019-10-30 12:52:04 +01:00
|
|
|
|
|
|
|
This returns a brand new deferred that is resolved when the underlying
|
|
|
|
deferred is resolved. Interacting with the returned deferred does not
|
2020-06-16 18:01:18 +02:00
|
|
|
effect the underlying deferred.
|
2017-03-30 18:05:53 +02:00
|
|
|
"""
|
2015-05-08 17:27:36 +02:00
|
|
|
if not self._result:
|
|
|
|
d = defer.Deferred()
|
2015-06-18 16:49:05 +02:00
|
|
|
|
|
|
|
def remove(r):
|
|
|
|
self._observers.discard(d)
|
|
|
|
return r
|
2019-06-20 11:32:02 +02:00
|
|
|
|
2015-06-18 16:49:05 +02:00
|
|
|
d.addBoth(remove)
|
|
|
|
|
|
|
|
self._observers.add(d)
|
2015-05-08 17:27:36 +02:00
|
|
|
return d
|
|
|
|
else:
|
|
|
|
success, res = self._result
|
2019-10-30 12:35:46 +01:00
|
|
|
return defer.succeed(res) if success else defer.fail(res)
|
2015-04-27 14:59:37 +02:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def observers(self) -> List[defer.Deferred]:
|
2015-06-18 16:49:05 +02:00
|
|
|
return self._observers
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def has_called(self) -> bool:
|
2016-06-02 12:52:32 +02:00
|
|
|
return self._result is not None
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def has_succeeded(self) -> bool:
|
2016-06-02 12:52:32 +02:00
|
|
|
return self._result is not None and self._result[0] is True
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def get_result(self) -> Any:
|
2016-06-02 12:52:32 +02:00
|
|
|
return self._result[1]
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def __getattr__(self, name: str) -> Any:
|
2015-05-08 17:27:36 +02:00
|
|
|
return getattr(self._deferred, name)
|
2015-04-27 14:59:37 +02:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def __setattr__(self, name: str, value: Any) -> None:
|
2015-05-08 17:27:36 +02:00
|
|
|
setattr(self._deferred, name, value)
|
2015-08-06 14:33:34 +02:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def __repr__(self) -> str:
|
2015-08-06 14:33:34 +02:00
|
|
|
return "<ObservableDeferred object at %s, result=%r, _deferred=%r>" % (
|
2019-06-20 11:32:02 +02:00
|
|
|
id(self),
|
|
|
|
self._result,
|
|
|
|
self._deferred,
|
2015-08-06 14:33:34 +02:00
|
|
|
)
|
2016-04-01 15:06:00 +02:00
|
|
|
|
|
|
|
|
2021-06-08 12:07:46 +02:00
|
|
|
T = TypeVar("T")
|
|
|
|
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def concurrently_execute(
|
2021-06-08 12:07:46 +02:00
|
|
|
func: Callable[[T], Any], args: Iterable[T], limit: int
|
2020-09-08 22:50:51 +02:00
|
|
|
) -> defer.Deferred:
|
|
|
|
"""Executes the function with each argument concurrently while limiting
|
2016-04-01 15:06:00 +02:00
|
|
|
the number of concurrent executions.
|
|
|
|
|
|
|
|
Args:
|
2020-09-08 22:50:51 +02:00
|
|
|
func: Function to execute, should return a deferred or coroutine.
|
|
|
|
args: List of arguments to pass to func, each invocation of func
|
2019-12-16 13:26:28 +01:00
|
|
|
gets a single argument.
|
2020-09-08 22:50:51 +02:00
|
|
|
limit: Maximum number of conccurent executions.
|
2016-04-01 15:06:00 +02:00
|
|
|
|
|
|
|
Returns:
|
2021-06-08 12:07:46 +02:00
|
|
|
Deferred: Resolved when all function invocations have finished.
|
2016-04-01 15:06:00 +02:00
|
|
|
"""
|
|
|
|
it = iter(args)
|
|
|
|
|
2021-06-08 12:07:46 +02:00
|
|
|
async def _concurrently_execute_inner(value: T) -> None:
|
2016-04-01 15:06:00 +02:00
|
|
|
try:
|
|
|
|
while True:
|
2021-06-08 12:07:46 +02:00
|
|
|
await maybe_awaitable(func(value))
|
|
|
|
value = next(it)
|
2016-04-01 15:06:00 +02:00
|
|
|
except StopIteration:
|
|
|
|
pass
|
|
|
|
|
2021-06-08 12:07:46 +02:00
|
|
|
# We use `itertools.islice` to handle the case where the number of args is
|
|
|
|
# less than the limit, avoiding needlessly spawning unnecessary background
|
|
|
|
# tasks.
|
2019-07-03 16:07:04 +02:00
|
|
|
return make_deferred_yieldable(
|
2019-06-20 11:32:02 +02:00
|
|
|
defer.gatherResults(
|
2021-06-08 12:07:46 +02:00
|
|
|
[
|
|
|
|
run_in_background(_concurrently_execute_inner, value)
|
|
|
|
for value in itertools.islice(it, limit)
|
|
|
|
],
|
2019-06-20 11:32:02 +02:00
|
|
|
consumeErrors=True,
|
|
|
|
)
|
|
|
|
).addErrback(unwrapFirstError)
|
2019-05-09 14:21:57 +02:00
|
|
|
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def yieldable_gather_results(
|
|
|
|
func: Callable, iter: Iterable, *args: Any, **kwargs: Any
|
|
|
|
) -> defer.Deferred:
|
2019-05-09 14:21:57 +02:00
|
|
|
"""Executes the function with each argument concurrently.
|
|
|
|
|
|
|
|
Args:
|
2020-09-08 22:50:51 +02:00
|
|
|
func: Function to execute that returns a Deferred
|
|
|
|
iter: An iterable that yields items that get passed as the first
|
2019-05-09 14:21:57 +02:00
|
|
|
argument to the function
|
|
|
|
*args: Arguments to be passed to each call to func
|
2020-09-08 22:50:51 +02:00
|
|
|
**kwargs: Keyword arguments to be passed to each call to func
|
2019-05-09 14:21:57 +02:00
|
|
|
|
|
|
|
Returns
|
2019-05-15 10:52:52 +02:00
|
|
|
Deferred[list]: Resolved when all functions have been invoked, or errors if
|
2019-05-09 14:21:57 +02:00
|
|
|
one of the function calls fails.
|
|
|
|
"""
|
2019-07-03 16:07:04 +02:00
|
|
|
return make_deferred_yieldable(
|
2019-06-20 11:32:02 +02:00
|
|
|
defer.gatherResults(
|
|
|
|
[run_in_background(func, item, *args, **kwargs) for item in iter],
|
|
|
|
consumeErrors=True,
|
|
|
|
)
|
|
|
|
).addErrback(unwrapFirstError)
|
2016-04-06 16:44:22 +02:00
|
|
|
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
@attr.s(slots=True)
|
|
|
|
class _LinearizerEntry:
|
|
|
|
# The number of things executing.
|
|
|
|
count = attr.ib(type=int)
|
|
|
|
# Deferreds for the things blocked from executing.
|
|
|
|
deferreds = attr.ib(type=collections.OrderedDict)
|
|
|
|
|
|
|
|
|
2020-09-04 12:54:56 +02:00
|
|
|
class Linearizer:
|
2016-11-10 17:29:51 +01:00
|
|
|
"""Limits concurrent access to resources based on a key. Useful to ensure
|
2018-07-20 14:11:43 +02:00
|
|
|
only a few things happen at a time on a given resource.
|
2016-11-10 17:29:51 +01:00
|
|
|
|
|
|
|
Example:
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
with await limiter.queue("test_key"):
|
2016-11-10 17:29:51 +01:00
|
|
|
# do some work.
|
|
|
|
|
|
|
|
"""
|
2019-06-20 11:32:02 +02:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def __init__(
|
|
|
|
self,
|
|
|
|
name: Optional[str] = None,
|
|
|
|
max_count: int = 1,
|
|
|
|
clock: Optional[Clock] = None,
|
|
|
|
):
|
2016-11-10 17:29:51 +01:00
|
|
|
"""
|
|
|
|
Args:
|
2020-09-08 22:50:51 +02:00
|
|
|
max_count: The maximum number of concurrent accesses
|
2016-11-10 17:29:51 +01:00
|
|
|
"""
|
2018-07-20 13:43:23 +02:00
|
|
|
if name is None:
|
2021-07-15 18:46:54 +02:00
|
|
|
self.name: Union[str, int] = id(self)
|
2018-07-20 13:43:23 +02:00
|
|
|
else:
|
|
|
|
self.name = name
|
|
|
|
|
2018-07-20 13:37:12 +02:00
|
|
|
if not clock:
|
|
|
|
from twisted.internet import reactor
|
2019-06-20 11:32:02 +02:00
|
|
|
|
2018-07-20 13:37:12 +02:00
|
|
|
clock = Clock(reactor)
|
|
|
|
self._clock = clock
|
2016-11-10 17:29:51 +01:00
|
|
|
self.max_count = max_count
|
2016-11-11 11:42:08 +01:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
# key_to_defer is a map from the key to a _LinearizerEntry.
|
2021-07-15 18:46:54 +02:00
|
|
|
self.key_to_defer: Dict[Hashable, _LinearizerEntry] = {}
|
2016-11-10 17:29:51 +01:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def is_queued(self, key: Hashable) -> bool:
|
2021-02-16 23:32:34 +01:00
|
|
|
"""Checks whether there is a process queued up waiting"""
|
2020-05-27 20:31:44 +02:00
|
|
|
entry = self.key_to_defer.get(key)
|
|
|
|
if not entry:
|
|
|
|
# No entry so nothing is waiting.
|
|
|
|
return False
|
|
|
|
|
|
|
|
# There are waiting deferreds only in the OrderedDict of deferreds is
|
|
|
|
# non-empty.
|
2020-09-08 22:50:51 +02:00
|
|
|
return bool(entry.deferreds)
|
2020-05-27 20:31:44 +02:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def queue(self, key: Hashable) -> defer.Deferred:
|
2018-08-10 11:59:09 +02:00
|
|
|
# we avoid doing defer.inlineCallbacks here, so that cancellation works correctly.
|
|
|
|
# (https://twistedmatrix.com/trac/ticket/4632 meant that cancellations were not
|
|
|
|
# propagated inside inlineCallbacks until Twisted 18.7)
|
2020-09-08 22:50:51 +02:00
|
|
|
entry = self.key_to_defer.setdefault(
|
|
|
|
key, _LinearizerEntry(0, collections.OrderedDict())
|
|
|
|
)
|
2016-11-10 17:29:51 +01:00
|
|
|
|
2016-11-11 11:42:08 +01:00
|
|
|
# If the number of things executing is greater than the maximum
|
|
|
|
# then add a deferred to the list of blocked items
|
2018-08-10 11:59:09 +02:00
|
|
|
# When one of the things currently executing finishes it will callback
|
2016-11-11 11:42:08 +01:00
|
|
|
# this item so that it can continue executing.
|
2020-09-08 22:50:51 +02:00
|
|
|
if entry.count >= self.max_count:
|
2018-08-10 11:59:09 +02:00
|
|
|
res = self._await_lock(key)
|
2017-11-07 01:48:57 +01:00
|
|
|
else:
|
2019-01-29 12:05:31 +01:00
|
|
|
logger.debug(
|
2019-06-20 11:32:02 +02:00
|
|
|
"Acquired uncontended linearizer lock %r for key %r", self.name, key
|
2018-07-20 14:11:43 +02:00
|
|
|
)
|
2020-09-08 22:50:51 +02:00
|
|
|
entry.count += 1
|
2018-08-10 11:59:09 +02:00
|
|
|
res = defer.succeed(None)
|
|
|
|
|
|
|
|
# once we successfully get the lock, we need to return a context manager which
|
|
|
|
# will release the lock.
|
2016-11-10 17:29:51 +01:00
|
|
|
|
|
|
|
@contextmanager
|
2018-08-10 11:59:09 +02:00
|
|
|
def _ctx_manager(_):
|
2016-11-10 17:29:51 +01:00
|
|
|
try:
|
|
|
|
yield
|
|
|
|
finally:
|
2019-01-29 12:05:31 +01:00
|
|
|
logger.debug("Releasing linearizer lock %r for key %r", self.name, key)
|
2017-11-07 01:48:57 +01:00
|
|
|
|
2016-11-11 11:42:08 +01:00
|
|
|
# We've finished executing so check if there are any things
|
|
|
|
# blocked waiting to execute and start one of them
|
2020-09-08 22:50:51 +02:00
|
|
|
entry.count -= 1
|
2017-11-07 01:48:57 +01:00
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
if entry.deferreds:
|
|
|
|
(next_def, _) = entry.deferreds.popitem(last=False)
|
2017-11-07 01:48:57 +01:00
|
|
|
|
2018-07-20 13:43:23 +02:00
|
|
|
# we need to run the next thing in the sentinel context.
|
2017-11-07 01:48:57 +01:00
|
|
|
with PreserveLoggingContext():
|
|
|
|
next_def.callback(None)
|
2020-09-08 22:50:51 +02:00
|
|
|
elif entry.count == 0:
|
2017-11-07 01:48:57 +01:00
|
|
|
# We were the last thing for this key: remove it from the
|
|
|
|
# map.
|
|
|
|
del self.key_to_defer[key]
|
2016-11-10 17:29:51 +01:00
|
|
|
|
2018-08-10 11:59:09 +02:00
|
|
|
res.addCallback(_ctx_manager)
|
|
|
|
return res
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
def _await_lock(self, key: Hashable) -> defer.Deferred:
|
2018-08-10 11:59:09 +02:00
|
|
|
"""Helper for queue: adds a deferred to the queue
|
|
|
|
|
|
|
|
Assumes that we've already checked that we've reached the limit of the number
|
|
|
|
of lock-holders we allow. Creates a new deferred which is added to the list, and
|
|
|
|
adds some management around cancellations.
|
|
|
|
|
|
|
|
Returns the deferred, which will callback once we have secured the lock.
|
|
|
|
|
|
|
|
"""
|
|
|
|
entry = self.key_to_defer[key]
|
|
|
|
|
2019-06-20 11:32:02 +02:00
|
|
|
logger.debug("Waiting to acquire linearizer lock %r for key %r", self.name, key)
|
2018-08-10 11:59:09 +02:00
|
|
|
|
|
|
|
new_defer = make_deferred_yieldable(defer.Deferred())
|
2020-09-08 22:50:51 +02:00
|
|
|
entry.deferreds[new_defer] = 1
|
2018-08-10 11:59:09 +02:00
|
|
|
|
|
|
|
def cb(_r):
|
2019-01-29 12:05:31 +01:00
|
|
|
logger.debug("Acquired linearizer lock %r for key %r", self.name, key)
|
2020-09-08 22:50:51 +02:00
|
|
|
entry.count += 1
|
2018-08-10 11:59:09 +02:00
|
|
|
|
|
|
|
# if the code holding the lock completes synchronously, then it
|
|
|
|
# will recursively run the next claimant on the list. That can
|
|
|
|
# relatively rapidly lead to stack exhaustion. This is essentially
|
|
|
|
# the same problem as http://twistedmatrix.com/trac/ticket/9304.
|
|
|
|
#
|
|
|
|
# In order to break the cycle, we add a cheeky sleep(0) here to
|
|
|
|
# ensure that we fall back to the reactor between each iteration.
|
|
|
|
#
|
|
|
|
# (This needs to happen while we hold the lock, and the context manager's exit
|
|
|
|
# code must be synchronous, so this is the only sensible place.)
|
|
|
|
return self._clock.sleep(0)
|
|
|
|
|
|
|
|
def eb(e):
|
|
|
|
logger.info("defer %r got err %r", new_defer, e)
|
|
|
|
if isinstance(e, CancelledError):
|
2019-01-29 12:05:31 +01:00
|
|
|
logger.debug(
|
2019-06-20 11:32:02 +02:00
|
|
|
"Cancelling wait for linearizer lock %r for key %r", self.name, key
|
2018-08-10 11:59:09 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
else:
|
2019-10-31 11:23:24 +01:00
|
|
|
logger.warning(
|
2018-08-10 11:59:09 +02:00
|
|
|
"Unexpected exception waiting for linearizer lock %r for key %r",
|
2019-06-20 11:32:02 +02:00
|
|
|
self.name,
|
|
|
|
key,
|
2018-08-10 11:59:09 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
# we just have to take ourselves back out of the queue.
|
2020-09-08 22:50:51 +02:00
|
|
|
del entry.deferreds[new_defer]
|
2018-08-10 11:59:09 +02:00
|
|
|
return e
|
|
|
|
|
|
|
|
new_defer.addCallbacks(cb, eb)
|
|
|
|
return new_defer
|
2016-11-10 17:29:51 +01:00
|
|
|
|
|
|
|
|
2020-09-04 12:54:56 +02:00
|
|
|
class ReadWriteLock:
|
2020-08-28 22:47:11 +02:00
|
|
|
"""An async read write lock.
|
2016-07-05 15:44:25 +02:00
|
|
|
|
|
|
|
Example:
|
|
|
|
|
2020-08-28 22:47:11 +02:00
|
|
|
with await read_write_lock.read("test_key"):
|
2016-07-05 15:44:25 +02:00
|
|
|
# do some work
|
|
|
|
"""
|
|
|
|
|
|
|
|
# IMPLEMENTATION NOTES
|
|
|
|
#
|
|
|
|
# We track the most recent queued reader and writer deferreds (which get
|
|
|
|
# resolved when they release the lock).
|
|
|
|
#
|
|
|
|
# Read: We know its safe to acquire a read lock when the latest writer has
|
2020-07-09 15:52:58 +02:00
|
|
|
# been resolved. The new reader is appended to the list of latest readers.
|
2016-07-05 15:44:25 +02:00
|
|
|
#
|
|
|
|
# Write: We know its safe to acquire the write lock when both the latest
|
|
|
|
# writers and readers have been resolved. The new writer replaces the latest
|
|
|
|
# writer.
|
|
|
|
|
|
|
|
def __init__(self):
|
|
|
|
# Latest readers queued
|
2021-07-15 18:46:54 +02:00
|
|
|
self.key_to_current_readers: Dict[str, Set[defer.Deferred]] = {}
|
2016-07-05 15:44:25 +02:00
|
|
|
|
|
|
|
# Latest writer queued
|
2021-07-15 18:46:54 +02:00
|
|
|
self.key_to_current_writer: Dict[str, defer.Deferred] = {}
|
2016-07-05 15:44:25 +02:00
|
|
|
|
2020-08-28 22:47:11 +02:00
|
|
|
async def read(self, key: str) -> ContextManager:
|
2016-07-05 15:44:25 +02:00
|
|
|
new_defer = defer.Deferred()
|
|
|
|
|
|
|
|
curr_readers = self.key_to_current_readers.setdefault(key, set())
|
|
|
|
curr_writer = self.key_to_current_writer.get(key, None)
|
|
|
|
|
|
|
|
curr_readers.add(new_defer)
|
|
|
|
|
|
|
|
# We wait for the latest writer to finish writing. We can safely ignore
|
|
|
|
# any existing readers... as they're readers.
|
2020-08-28 22:47:11 +02:00
|
|
|
if curr_writer:
|
|
|
|
await make_deferred_yieldable(curr_writer)
|
2016-07-05 15:44:25 +02:00
|
|
|
|
|
|
|
@contextmanager
|
|
|
|
def _ctx_manager():
|
|
|
|
try:
|
|
|
|
yield
|
|
|
|
finally:
|
|
|
|
new_defer.callback(None)
|
|
|
|
self.key_to_current_readers.get(key, set()).discard(new_defer)
|
|
|
|
|
2019-07-23 15:00:55 +02:00
|
|
|
return _ctx_manager()
|
2016-07-05 15:44:25 +02:00
|
|
|
|
2020-08-28 22:47:11 +02:00
|
|
|
async def write(self, key: str) -> ContextManager:
|
2016-07-05 15:44:25 +02:00
|
|
|
new_defer = defer.Deferred()
|
|
|
|
|
|
|
|
curr_readers = self.key_to_current_readers.get(key, set())
|
|
|
|
curr_writer = self.key_to_current_writer.get(key, None)
|
|
|
|
|
|
|
|
# We wait on all latest readers and writer.
|
|
|
|
to_wait_on = list(curr_readers)
|
|
|
|
if curr_writer:
|
|
|
|
to_wait_on.append(curr_writer)
|
|
|
|
|
|
|
|
# We can clear the list of current readers since the new writer waits
|
|
|
|
# for them to finish.
|
|
|
|
curr_readers.clear()
|
|
|
|
self.key_to_current_writer[key] = new_defer
|
|
|
|
|
2020-08-28 22:47:11 +02:00
|
|
|
await make_deferred_yieldable(defer.gatherResults(to_wait_on))
|
2016-07-05 15:44:25 +02:00
|
|
|
|
|
|
|
@contextmanager
|
|
|
|
def _ctx_manager():
|
|
|
|
try:
|
|
|
|
yield
|
|
|
|
finally:
|
|
|
|
new_defer.callback(None)
|
|
|
|
if self.key_to_current_writer[key] == new_defer:
|
|
|
|
self.key_to_current_writer.pop(key)
|
|
|
|
|
2019-07-23 15:00:55 +02:00
|
|
|
return _ctx_manager()
|
2018-04-27 13:52:30 +02:00
|
|
|
|
|
|
|
|
2020-09-08 22:50:51 +02:00
|
|
|
R = TypeVar("R")
|
|
|
|
|
|
|
|
|
|
|
|
def timeout_deferred(
|
2021-02-16 23:32:34 +01:00
|
|
|
deferred: defer.Deferred,
|
|
|
|
timeout: float,
|
|
|
|
reactor: IReactorTime,
|
2020-09-08 22:50:51 +02:00
|
|
|
) -> defer.Deferred:
|
2018-09-19 11:39:40 +02:00
|
|
|
"""The in built twisted `Deferred.addTimeout` fails to time out deferreds
|
|
|
|
that have a canceller that throws exceptions. This method creates a new
|
|
|
|
deferred that wraps and times out the given deferred, correctly handling
|
|
|
|
the case where the given deferred's canceller throws.
|
2018-04-27 13:52:30 +02:00
|
|
|
|
2019-01-17 15:00:23 +01:00
|
|
|
(See https://twistedmatrix.com/trac/ticket/9534)
|
|
|
|
|
2020-09-29 11:29:21 +02:00
|
|
|
NOTE: Unlike `Deferred.addTimeout`, this function returns a new deferred.
|
|
|
|
|
|
|
|
NOTE: the TimeoutError raised by the resultant deferred is
|
|
|
|
twisted.internet.defer.TimeoutError, which is *different* to the built-in
|
|
|
|
TimeoutError, as well as various other TimeoutErrors you might have imported.
|
2018-04-27 13:52:30 +02:00
|
|
|
|
2018-09-19 11:39:40 +02:00
|
|
|
Args:
|
2020-09-08 22:50:51 +02:00
|
|
|
deferred: The Deferred to potentially timeout.
|
|
|
|
timeout: Timeout in seconds
|
|
|
|
reactor: The twisted reactor to use
|
2018-04-27 13:52:30 +02:00
|
|
|
|
|
|
|
|
2018-09-19 11:39:40 +02:00
|
|
|
Returns:
|
2020-09-29 11:29:21 +02:00
|
|
|
A new Deferred, which will errback with defer.TimeoutError on timeout.
|
2018-09-14 20:23:07 +02:00
|
|
|
"""
|
|
|
|
new_d = defer.Deferred()
|
|
|
|
|
|
|
|
timed_out = [False]
|
|
|
|
|
|
|
|
def time_it_out():
|
|
|
|
timed_out[0] = True
|
|
|
|
|
2018-09-19 12:04:42 +02:00
|
|
|
try:
|
|
|
|
deferred.cancel()
|
2021-03-24 14:34:30 +01:00
|
|
|
except Exception: # if we throw any exception it'll break time outs
|
2018-09-19 12:04:42 +02:00
|
|
|
logger.exception("Canceller failed during timeout")
|
|
|
|
|
2020-09-29 11:29:21 +02:00
|
|
|
# the cancel() call should have set off a chain of errbacks which
|
|
|
|
# will have errbacked new_d, but in case it hasn't, errback it now.
|
|
|
|
|
2018-09-14 20:23:07 +02:00
|
|
|
if not new_d.called:
|
2020-09-29 11:29:21 +02:00
|
|
|
new_d.errback(defer.TimeoutError("Timed out after %gs" % (timeout,)))
|
2018-09-14 20:23:07 +02:00
|
|
|
|
|
|
|
delayed_call = reactor.callLater(timeout, time_it_out)
|
|
|
|
|
2020-09-29 11:29:21 +02:00
|
|
|
def convert_cancelled(value: failure.Failure):
|
2021-02-12 17:01:48 +01:00
|
|
|
# if the original deferred was cancelled, and our timeout has fired, then
|
2020-09-29 11:29:21 +02:00
|
|
|
# the reason it was cancelled was due to our timeout. Turn the CancelledError
|
|
|
|
# into a TimeoutError.
|
|
|
|
if timed_out[0] and value.check(CancelledError):
|
|
|
|
raise defer.TimeoutError("Timed out after %gs" % (timeout,))
|
2018-09-14 20:23:07 +02:00
|
|
|
return value
|
|
|
|
|
2020-09-29 11:29:21 +02:00
|
|
|
deferred.addErrback(convert_cancelled)
|
2018-09-14 20:23:07 +02:00
|
|
|
|
|
|
|
def cancel_timeout(result):
|
|
|
|
# stop the pending call to cancel the deferred if it's been fired
|
|
|
|
if delayed_call.active():
|
|
|
|
delayed_call.cancel()
|
|
|
|
return result
|
|
|
|
|
|
|
|
deferred.addBoth(cancel_timeout)
|
|
|
|
|
|
|
|
def success_cb(val):
|
|
|
|
if not new_d.called:
|
|
|
|
new_d.callback(val)
|
|
|
|
|
|
|
|
def failure_cb(val):
|
|
|
|
if not new_d.called:
|
|
|
|
new_d.errback(val)
|
|
|
|
|
|
|
|
deferred.addCallbacks(success_cb, failure_cb)
|
|
|
|
|
|
|
|
return new_d
|
2019-10-11 16:26:09 +02:00
|
|
|
|
|
|
|
|
|
|
|
@attr.s(slots=True, frozen=True)
|
2020-09-04 12:54:56 +02:00
|
|
|
class DoneAwaitable:
|
2021-02-16 23:32:34 +01:00
|
|
|
"""Simple awaitable that returns the provided value."""
|
2019-10-11 16:26:09 +02:00
|
|
|
|
|
|
|
value = attr.ib()
|
|
|
|
|
|
|
|
def __await__(self):
|
|
|
|
return self
|
|
|
|
|
|
|
|
def __iter__(self):
|
|
|
|
return self
|
|
|
|
|
|
|
|
def __next__(self):
|
|
|
|
raise StopIteration(self.value)
|
|
|
|
|
|
|
|
|
2020-12-11 20:05:15 +01:00
|
|
|
def maybe_awaitable(value: Union[Awaitable[R], R]) -> Awaitable[R]:
|
2021-02-16 23:32:34 +01:00
|
|
|
"""Convert a value to an awaitable if not already an awaitable."""
|
2020-12-11 20:05:15 +01:00
|
|
|
if inspect.isawaitable(value):
|
|
|
|
assert isinstance(value, Awaitable)
|
2019-10-11 16:26:09 +02:00
|
|
|
return value
|
|
|
|
|
|
|
|
return DoneAwaitable(value)
|