From 02553901ce94461c6f140efc804443069b97f401 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Tue, 17 Dec 2019 11:44:32 +0000 Subject: [PATCH] Remove unused `get_pagination_rows` methods. (#6557) Remove unused get_pagination_rows methods --- changelog.d/6557.misc | 1 + synapse/handlers/account_data.py | 3 --- synapse/handlers/room.py | 12 ------------ synapse/handlers/typing.py | 3 --- 4 files changed, 1 insertion(+), 18 deletions(-) create mode 100644 changelog.d/6557.misc diff --git a/changelog.d/6557.misc b/changelog.d/6557.misc new file mode 100644 index 0000000000..80e7eaedb8 --- /dev/null +++ b/changelog.d/6557.misc @@ -0,0 +1 @@ +Remove unused `get_pagination_rows` methods from `EventSource` classes. diff --git a/synapse/handlers/account_data.py b/synapse/handlers/account_data.py index 20ec1ca01b..a8d3fbc6de 100644 --- a/synapse/handlers/account_data.py +++ b/synapse/handlers/account_data.py @@ -50,6 +50,3 @@ class AccountDataEventSource(object): ) return results, current_stream_id - - async def get_pagination_rows(self, user, config, key): - return [], config.to_id diff --git a/synapse/handlers/room.py b/synapse/handlers/room.py index 22768e97ff..2d7925547d 100644 --- a/synapse/handlers/room.py +++ b/synapse/handlers/room.py @@ -1008,15 +1008,3 @@ class RoomEventSource(object): def get_current_key_for_room(self, room_id): return self.store.get_room_events_max_id(room_id) - - @defer.inlineCallbacks - def get_pagination_rows(self, user, config, key): - events, next_key = yield self.store.paginate_room_events( - room_id=key, - from_key=config.from_key, - to_key=config.to_key, - direction=config.direction, - limit=config.limit, - ) - - return (events, next_key) diff --git a/synapse/handlers/typing.py b/synapse/handlers/typing.py index 6f78454322..b635c339ed 100644 --- a/synapse/handlers/typing.py +++ b/synapse/handlers/typing.py @@ -317,6 +317,3 @@ class TypingNotificationEventSource(object): def get_current_key(self): return self.get_typing_handler()._latest_room_serial - - def get_pagination_rows(self, user, pagination_config, key): - return [], pagination_config.from_key