Merge pull request #4669 from matrix-org/erikj/log_exception

Cleanup top level request exception logging
pull/4676/head
Erik Johnston 2019-02-18 16:41:41 +00:00 committed by GitHub
commit 028267acd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions

1
changelog.d/4669.misc Normal file
View File

@ -0,0 +1 @@
Cleanup request exception logging

View File

@ -106,10 +106,10 @@ def wrap_json_request_handler(h):
# trace.
f = failure.Failure()
logger.error(
"Failed handle request via %r: %r: %s",
h,
"Failed handle request via %r: %r",
request.request_metrics.name,
request,
f.getTraceback().rstrip(),
exc_info=(f.type, f.value, f.getTracebackObject()),
)
# Only respond with an error response if we haven't already started
# writing, otherwise lets just kill the connection