OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Actually use the picture_claim as configured in OIDC config. (#14751) 

Previously it was only using the default value ("picture") when
fetching the picture from the user info.
pull/14753/head
Patrick Cloke 2022-12-29 12:18:06 -05:00 committed by GitHub
parent eb9ae47799
commit 044fa1a1de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/14751.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.73.0 where the `picture_claim` configured under `oidc_providers` was unused (the default value of `"picture"` was used instead).

2
synapse/handlers/oidc.py
View File

@ -1615,7 +1615,7 @@ class JinjaOidcMappingProvider(OidcMappingProvider[JinjaOidcMappingConfig]):
if email: if email:
emails.append(email) emails.append(email)
picture = userinfo.get("picture") picture = userinfo.get(self._config.picture_claim)
return UserAttributeDict( return UserAttributeDict(
localpart=localpart, localpart=localpart,