OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Use READ COMMITTED isolation level when inserting read receipts (#12957)

pull/13022/head
Nick Mills-Barrett 2022-06-09 09:44:16 +01:00 committed by GitHub
parent dd2d66b0c9
commit 04ca3a52f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/12957.misc Normal file
View File

@ -0,0 +1 @@
Use lower isolation level when inserting read receipts to avoid serialization errors. Contributed by Nick @ Beeper.

5
synapse/storage/databases/main/receipts.py
View File

@ -36,6 +36,7 @@ from synapse.storage.database import (
LoggingTransaction, LoggingTransaction,
) )
from synapse.storage.engines import PostgresEngine from synapse.storage.engines import PostgresEngine
from synapse.storage.engines._base import IsolationLevel
from synapse.storage.util.id_generators import ( from synapse.storage.util.id_generators import (
AbstractStreamIdTracker, AbstractStreamIdTracker,
MultiWriterIdGenerator, MultiWriterIdGenerator,
@ -764,6 +765,10 @@ class ReceiptsWorkerStore(SQLBaseStore):
linearized_event_id, linearized_event_id,
data, data,
stream_id=stream_id, stream_id=stream_id,
# Read committed is actually beneficial here because we check for a receipt with
# greater stream order, and checking the very latest data at select time is better
# than the data at transaction start time.
isolation_level=IsolationLevel.READ_COMMITTED,
) )
# If the receipt was older than the currently persisted one, nothing to do. # If the receipt was older than the currently persisted one, nothing to do.