Add comment

2017-05-18 11:45:56 +01:00 · 2017-05-18 11:45:56 +01:00 · 056ba9b795
parent 66d8ffabbd
commit 056ba9b795
1 changed files with 3 additions and 0 deletions
--- a/synapse/push/bulk_push_rule_evaluator.py
+++ b/synapse/push/bulk_push_rule_evaluator.py
@ -74,6 +74,9 @@ class BulkPushRuleEvaluator:
        Returns:
            RulesForRoom
        """
+        # It's important that RulesForRoom gets added to self._get_rules_for_room.cache
+        # before any lookup methods get called on it as otherwise there may be
+        # a race if invalidate_all gets called (which assumes its in the cache)
        return RulesForRoom(self.hs, room_id, self._get_rules_for_room.cache)

    @defer.inlineCallbacks