Explain rationale

pull/5760/head
Brendan Abolivier 2019-08-01 10:19:04 +02:00
parent d2bb51080e
commit 0c6500a08b
No known key found for this signature in database
GPG Key ID: 1E015C145F1916CD
1 changed files with 4 additions and 0 deletions

View File

@ -438,6 +438,10 @@ class RoomAccessRules(object):
"""Check whether a join rule change is allowed. A join rule change is always
allowed unless the new join rule is "public" and the current access rule isn't
"restricted".
The rationale is that external users (those whose server would be denied access
to rooms enforcing the "restricted" access rule) should always rely on non-
external users for access to rooms, therefore they shouldn't be able to access
rooms that don't require an invite to be joined.
Note that we currently rely on the default access rule being "restricted": during
room creation, the m.room.join_rules event will be sent *before* the