OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix event chain bg update. (#9118) 

We passed in a graph to `sorted_topologically` which didn't have an
entry for each node (as we dropped nodes with no edges).
pull/9124/head
Erik Johnston 2021-01-14 18:57:32 +00:00 committed by GitHub
parent d2479c6870
commit 1a08e0cdab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/9118.misc Normal file
View File

@ -0,0 +1 @@
Improve efficiency of large state resolutions.

2
synapse/util/iterutils.py
View File

@ -92,7 +92,7 @@ def sorted_topologically(
node = heapq.heappop(zero_degree) node = heapq.heappop(zero_degree)
yield node yield node
for edge in reverse_graph[node]: for edge in reverse_graph.get(node, []):
if edge in degree_map: if edge in degree_map:
degree_map[edge] -= 1 degree_map[edge] -= 1
if degree_map[edge] == 0: if degree_map[edge] == 0:

8
tests/util/test_itertools.py
View File

@ -56,6 +56,14 @@ class SortTopologically(TestCase):
graph = {} # type: Dict[int, List[int]] graph = {} # type: Dict[int, List[int]]
self.assertEqual(list(sorted_topologically([], graph)), []) self.assertEqual(list(sorted_topologically([], graph)), [])
def test_handle_empty_graph(self):
"Test that a graph where a node doesn't have an entry is treated as empty"
graph = {} # type: Dict[int, List[int]]
# For disconnected nodes the output is simply sorted.
self.assertEqual(list(sorted_topologically([1, 2], graph)), [1, 2])
def test_disconnected(self): def test_disconnected(self):
"Test that a graph with no edges work" "Test that a graph with no edges work"