OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Improve performance of fetching event reports when there are many of them

rei/fetch_evt_report_slight_query_optimi
Olivier Wilkinson (reivilibre) 2023-11-10 14:01:08 +00:00
parent 2c6a7dfcbf
commit 1d1e8a5634
1 changed files with 29 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
synapse/storage/databases/main/room.py
View File

@ -1600,25 +1600,37 @@ class RoomWorkerStore(CacheInvalidationWorkerStore):
count = cast(Tuple[int], txn.fetchone())[0] count = cast(Tuple[int], txn.fetchone())[0]
sql = """ sql = """
WITH considered_event_reports AS (
SELECT
er.id,
er.received_ts,
er.room_id,
er.event_id,
er.user_id,
er.content,
room_stats_state.canonical_alias,
room_stats_state.name
FROM event_reports AS er
JOIN room_stats_state
ON room_stats_state.room_id = er.room_id
{where_clause}
ORDER BY er.received_ts {order}
LIMIT ?
OFFSET ?
)
-- only join on `events` after the LIMIT/OFFSET has been applied
SELECT SELECT
er.id, cer.id,
er.received_ts, cer.received_ts,
er.room_id, cer.room_id,
er.event_id, cer.event_id,
er.user_id, cer.user_id,
er.content, cer.content,
events.sender, events.sender,
room_stats_state.canonical_alias, cer.canonical_alias,
room_stats_state.name cer.name
FROM event_reports AS er FROM considered_event_reports AS cer
LEFT JOIN events LEFT JOIN events ON events.event_id = cer.event_id
ON events.event_id = er.event_id
JOIN room_stats_state
ON room_stats_state.room_id = er.room_id
{where_clause}
ORDER BY er.received_ts {order}
LIMIT ?
OFFSET ?
""".format( """.format(
where_clause=where_clause, where_clause=where_clause,
order=order, order=order,