Merge pull request #2268 from matrix-org/erikj/entity_has_changed

Fix has_any_entity_changed
2017-06-09 15:30:55 +01:00 · 2017-06-09 15:30:55 +01:00 · 1e9b4d5a95
parent bfd68019c2 efc2b7db95
commit 1e9b4d5a95
1 changed files with 4 additions and 4 deletions
--- a/synapse/util/caches/stream_change_cache.py
+++ b/synapse/util/caches/stream_change_cache.py
@ -96,10 +96,10 @@ class StreamChangeCache(object):

        if stream_pos >= self._earliest_known_stream_pos:
            self.metrics.inc_hits()
-            if stream_pos >= max(self._cache):
-                return False
-            else:
-                return True
+            keys = self._cache.keys()
+            i = keys.bisect_right(stream_pos)
+
+            return i < len(keys)
        else:
            self.metrics.inc_misses()
            return True