OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

SYN-202: Log as WARN the 404 'Presence information not visible' errors instead of as ERROR since they were spamming the logs

pull/52/head
Erik Johnston 2015-02-05 13:17:05 +00:00
parent 6a7e168009
commit 26a041541b
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
synapse/handlers/message.py
View File

@ -16,7 +16,7 @@
from twisted.internet import defer from twisted.internet import defer
from synapse.api.constants import EventTypes, Membership from synapse.api.constants import EventTypes, Membership
from synapse.api.errors import RoomError from synapse.api.errors import RoomError, SynapseError
from synapse.streams.config import PaginationConfig from synapse.streams.config import PaginationConfig
from synapse.events.utils import serialize_event from synapse.events.utils import serialize_event
from synapse.events.validator import EventValidator from synapse.events.validator import EventValidator
@ -372,7 +372,14 @@ class MessageHandler(BaseHandler):
as_event=True, as_event=True,
) )
presence.append(member_presence) presence.append(member_presence)
except Exception: except SynapseError as e:
if e.code == 404:
# FIXME: We are doing this as a warn since this gets hit a
# lot and spams the logs. Why is this happening?
logger.warn(
"Failed to get member presence of %r", m.user_id
)
else:
logger.exception( logger.exception(
"Failed to get member presence of %r", m.user_id "Failed to get member presence of %r", m.user_id
) )