more comments

pull/3967/head
Richard van der Hoff 2018-09-26 19:17:36 +01:00
parent ad8e137062
commit 28223841e0
2 changed files with 3 additions and 6 deletions

View File

@ -209,8 +209,6 @@ class FederationClient(FederationBase):
Will attempt to get the PDU from each destination in the list until
one succeeds.
This will persist the PDU locally upon receipt.
Args:
destinations (list): Which home servers to query
event_id (str): event to fetch

View File

@ -341,10 +341,9 @@ class FederationHandler(BaseHandler):
)
with logcontext.nested_logging_context(p):
# XXX if any of the missing prevs share missing state or auth
# events, we'll end up requesting those missing events for
# *each* missing prev, contributing to the hammering of /event
# as per https://github.com/matrix-org/synapse/issues/2164.
# note that if any of the missing prevs share missing state or
# auth events, the requests to fetch those events are deduped
# by the get_pdu_cache in federation_client.
remote_state, got_auth_chain = (
yield self.federation_client.get_state_for_room(
origin, room_id, p,