OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Calculate rooms changed for device lists to work. (#14810) 

Back-out some changes from 7e582a25f8
(#14786) which skipped necessary logic to calculate device lists properly.
pull/14817/head
Patrick Cloke 2023-01-11 07:16:41 -05:00 committed by GitHub
parent f417fb84b8
commit 3952297f6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/14810.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.75.0rc1 where device lists could be miscalculated with some sync filters.

3
synapse/api/filtering.py
View File

@ -283,9 +283,6 @@ class FilterCollection:
await self._room_filter.filter(events) await self._room_filter.filter(events)
) )
def blocks_all_rooms(self) -> bool:
return self._room_filter.filters_all_rooms()
def blocks_all_presence(self) -> bool: def blocks_all_presence(self) -> bool:
return ( return (
self._presence_filter.filters_all_types() self._presence_filter.filters_all_types()

4
synapse/handlers/sync.py
View File

@ -1793,10 +1793,6 @@ class SyncHandler:
- newly_left_users - newly_left_users
""" """
# If the request doesn't care about rooms then nothing to do!
if sync_result_builder.sync_config.filter_collection.blocks_all_rooms():
return set(), set(), set(), set()
since_token = sync_result_builder.since_token since_token = sync_result_builder.since_token
# 1. Start by fetching all ephemeral events in rooms we've joined (if required). # 1. Start by fetching all ephemeral events in rooms we've joined (if required).