Merge pull request #5808 from matrix-org/erikj/parse_decode_error
Handle incorrectly encoded query params correctlypull/5818/head
commit
3c076c79c5
|
@ -0,0 +1 @@
|
|||
Handle incorrectly encoded query params correctly by returning a 400.
|
|
@ -166,7 +166,12 @@ def parse_string_from_args(
|
|||
value = args[name][0]
|
||||
|
||||
if encoding:
|
||||
value = value.decode(encoding)
|
||||
try:
|
||||
value = value.decode(encoding)
|
||||
except ValueError:
|
||||
raise SynapseError(
|
||||
400, "Query parameter %r must be %s" % (name, encoding)
|
||||
)
|
||||
|
||||
if allowed_values is not None and value not in allowed_values:
|
||||
message = "Query parameter %r must be one of [%s]" % (
|
||||
|
|
Loading…
Reference in New Issue