1.41.0rc1

2021-08-18 15:52:11 +01:00 · 2021-08-18 15:52:11 +01:00 · 49cb7eae97
parent 3692f7fd33
commit 49cb7eae97
63 changed files with 86 additions and 61 deletions
--- a/CHANGES.md
+++ b/CHANGES.md
@ -1,3 +1,82 @@
+Synapse 1.41.0rc1 (2021-08-18)
+==============================
+
+Features
+--------
+
+- Add `get_userinfo_by_id` method to ModuleApi. ([\#9581](https://github.com/matrix-org/synapse/issues/9581))
+- Initial local support for [MSC3266](https://github.com/matrix-org/synapse/pull/10394), Room Summary over the unstable `/rooms/{roomIdOrAlias}/summary` API. ([\#10394](https://github.com/matrix-org/synapse/issues/10394))
+- Experimental support for [MSC3288](https://github.com/matrix-org/matrix-doc/pull/3288), sending `room_type` to the identity server for 3pid invites over the `/store-invite` API. ([\#10435](https://github.com/matrix-org/synapse/issues/10435))
+- Add support for sending federation requests through a proxy. Contributed by @Bubu and @dklimpel. ([\#10475](https://github.com/matrix-org/synapse/issues/10475))
+- Add support for "marker" events which makes historical events discoverable for servers that already have all of the scrollback history (part of MSC2716). ([\#10498](https://github.com/matrix-org/synapse/issues/10498))
+- Add a configuration setting for the time a `/sync` response is cached for. ([\#10513](https://github.com/matrix-org/synapse/issues/10513))
+- The default logging handler for new installations is now `PeriodicallyFlushingMemoryHandler`, a buffered logging handler which periodically flushes itself. ([\#10518](https://github.com/matrix-org/synapse/issues/10518))
+- Add support for new redaction rules for historical events specified in [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716). ([\#10538](https://github.com/matrix-org/synapse/issues/10538))
+- Add a setting to disable TLS when sending email. ([\#10546](https://github.com/matrix-org/synapse/issues/10546))
+- Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#10549](https://github.com/matrix-org/synapse/issues/10549), [\#10560](https://github.com/matrix-org/synapse/issues/10560), [\#10569](https://github.com/matrix-org/synapse/issues/10569), [\#10574](https://github.com/matrix-org/synapse/issues/10574), [\#10575](https://github.com/matrix-org/synapse/issues/10575), [\#10579](https://github.com/matrix-org/synapse/issues/10579), [\#10583](https://github.com/matrix-org/synapse/issues/10583))
+- Admin API to delete several media for a specific user. Contributed by @dklimpel. ([\#10558](https://github.com/matrix-org/synapse/issues/10558), [\#10628](https://github.com/matrix-org/synapse/issues/10628))
+- Add support for routing `/createRoom` to workers. ([\#10564](https://github.com/matrix-org/synapse/issues/10564))
+- Update the Synapse Grafana dashboard. ([\#10570](https://github.com/matrix-org/synapse/issues/10570))
+- Add an admin API (`GET /_synapse/admin/username_available`) to check if a username is available (regardless of registration settings). ([\#10578](https://github.com/matrix-org/synapse/issues/10578))
+- Allow editing a user's `external_ids` via the "Edit User" admin API. Contributed by @dklimpel. ([\#10598](https://github.com/matrix-org/synapse/issues/10598))
+- The Synapse manhole no longer needs coroutines to be wrapped in `defer.ensureDeferred`. ([\#10602](https://github.com/matrix-org/synapse/issues/10602))
+- Add option to allow modules to run periodic tasks on all instances, rather than just the one configured to run background tasks. ([\#10638](https://github.com/matrix-org/synapse/issues/10638))
+
+
+Bugfixes
+--------
+
+- Add some clarification to the sample config file. Contributed by @Kentokamoto. ([\#10129](https://github.com/matrix-org/synapse/issues/10129))
+- Fix a long-standing bug where protocols which are not implemented by any appservices were incorrectly returned via `GET /_matrix/client/r0/thirdparty/protocols`. ([\#10532](https://github.com/matrix-org/synapse/issues/10532))
+- Fix exceptions in logs when failing to get remote room list. ([\#10541](https://github.com/matrix-org/synapse/issues/10541))
+- Fix longstanding bug which caused the user "status" to be reset when the user went offline. Contributed by @dklimpel. ([\#10550](https://github.com/matrix-org/synapse/issues/10550))
+- Allow public rooms to be previewed in the spaces summary APIs from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#10580](https://github.com/matrix-org/synapse/issues/10580))
+- Fix a bug introduced in v1.37.1 where an error could occur in the asyncronous processing of PDUs when the queue was empty. ([\#10592](https://github.com/matrix-org/synapse/issues/10592))
+- Fix errors on /sync when read receipt data is a string. Only affects homeservers with the experimental flag for [MSC2285](https://github.com/matrix-org/matrix-doc/pull/2285) enabled. Contributed by @SimonBrandner. ([\#10606](https://github.com/matrix-org/synapse/issues/10606))
+- Additional validation for the spaces summary API to avoid errors like `ValueError: Stop argument for islice() must be None or an integer`. The missing validation has existed since v1.31.0. ([\#10611](https://github.com/matrix-org/synapse/issues/10611))
+- Revert behaviour introduced in v1.38.0 that strips `org.matrix.msc2732.device_unused_fallback_key_types` from `/sync` when its value is empty. This field should instead always be present according to [MSC2732](https://github.com/matrix-org/matrix-doc/blob/master/proposals/2732-olm-fallback-keys.md). ([\#10623](https://github.com/matrix-org/synapse/issues/10623))
+
+
+Improved Documentation
+----------------------
+
+- Add documentation for configuration a forward proxy. ([\#10443](https://github.com/matrix-org/synapse/issues/10443))
+- Updated the reverse proxy documentation to highlight the homserver configuration that is needed to make Synapse aware that is is intentionally reverse proxied. ([\#10551](https://github.com/matrix-org/synapse/issues/10551))
+- Update CONTRIBUTING.md to fix index links and the instructions for SyTest in docker. ([\#10599](https://github.com/matrix-org/synapse/issues/10599))
+
+
+Deprecations and Removals
+-------------------------
+
+- No longer build `.dev` packages for Ubuntu 20.10 LTS Groovy Gorilla, which has now EOLed. ([\#10588](https://github.com/matrix-org/synapse/issues/10588))
+- The `template_dir` configuration settings in the `sso`, `account_validity` and `email` sections of the configuration file are now deprecated in favour of the global `templates.custom_template_directory` setting. See the [upgrade notes](https://matrix-org.github.io/synapse/latest/upgrade.html) for more information. ([\#10596](https://github.com/matrix-org/synapse/issues/10596))
+
+
+Internal Changes
+----------------
+
+- Improve event caching mechanism to avoid having multiple copies of an event in memory at a time. ([\#10119](https://github.com/matrix-org/synapse/issues/10119))
+- Reduce errors in PostgreSQL logs due to concurrent serialization errors. ([\#10504](https://github.com/matrix-org/synapse/issues/10504))
+- Include room ID in ignored EDU log messages. Contributed by @ilmari. ([\#10507](https://github.com/matrix-org/synapse/issues/10507))
+- Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#10527](https://github.com/matrix-org/synapse/issues/10527), [\#10530](https://github.com/matrix-org/synapse/issues/10530))
+- Fix CI to not break when run against branches rather than pull requests. ([\#10529](https://github.com/matrix-org/synapse/issues/10529))
+- Mark all events stemming from the MSC2716 `/batch_send` endpoint as historical. ([\#10537](https://github.com/matrix-org/synapse/issues/10537))
+- Clean up some of the federation event authentication code for clarity. ([\#10539](https://github.com/matrix-org/synapse/issues/10539), [\#10591](https://github.com/matrix-org/synapse/issues/10591))
+- Convert `Transaction` and `Edu` objects to attrs. ([\#10542](https://github.com/matrix-org/synapse/issues/10542))
+- Update `/batch_send` endpoint to only return `state_events` created by the `state_events_from_before` passed in. ([\#10552](https://github.com/matrix-org/synapse/issues/10552))
+- Update contributing.md to warn against rebasing an open PR. ([\#10563](https://github.com/matrix-org/synapse/issues/10563))
+- Remove the unused public rooms replication stream. ([\#10565](https://github.com/matrix-org/synapse/issues/10565))
+- Clarify error message when failing to join a restricted room. ([\#10572](https://github.com/matrix-org/synapse/issues/10572))
+- Remove references to BuildKite in favour of GitHub Actions. ([\#10573](https://github.com/matrix-org/synapse/issues/10573))
+- Move `/batch_send` endpoint defined by [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) to the `/v2_alpha` directory. ([\#10576](https://github.com/matrix-org/synapse/issues/10576))
+- Allow multiple custom directories in `read_templates`. ([\#10587](https://github.com/matrix-org/synapse/issues/10587))
+- Re-organize the `synapse.federation.transport.server` module to create smaller files. ([\#10590](https://github.com/matrix-org/synapse/issues/10590))
+- Flatten the `synapse.rest.client` package by moving the contents of `v1` and `v2_alpha` into the parent. ([\#10600](https://github.com/matrix-org/synapse/issues/10600))
+- Build Debian packages for Debian 12 (Bookworm). ([\#10612](https://github.com/matrix-org/synapse/issues/10612))
+- Fix up a couple of links to the database schema documentation. ([\#10620](https://github.com/matrix-org/synapse/issues/10620))
+- Fix a broken link to the upgrade notes. ([\#10631](https://github.com/matrix-org/synapse/issues/10631))
+
+
 Synapse 1.40.0 (2021-08-10)
 ===========================

--- a/changelog.d/10119.misc
+++ b/changelog.d/10119.misc
@ -1 +0,0 @@
-Improve event caching mechanism to avoid having multiple copies of an event in memory at a time.
--- a/changelog.d/10129.bugfix
+++ b/changelog.d/10129.bugfix
@ -1 +0,0 @@
-Add some clarification to the sample config file. Contributed by @Kentokamoto.
--- a/changelog.d/10394.feature
+++ b/changelog.d/10394.feature
@ -1 +0,0 @@
-Initial local support for [MSC3266](https://github.com/matrix-org/synapse/pull/10394), Room Summary over the unstable `/rooms/{roomIdOrAlias}/summary` API.
--- a/changelog.d/10435.feature
+++ b/changelog.d/10435.feature
@ -1 +0,0 @@
-Experimental support for [MSC3288](https://github.com/matrix-org/matrix-doc/pull/3288), sending `room_type` to the identity server for 3pid invites over the `/store-invite` API.
--- a/changelog.d/10443.doc
+++ b/changelog.d/10443.doc
@ -1 +0,0 @@
-Add documentation for configuration a forward proxy.
--- a/changelog.d/10475.feature
+++ b/changelog.d/10475.feature
@ -1 +0,0 @@
-Add support for sending federation requests through a proxy. Contributed by @Bubu and @dklimpel.
--- a/changelog.d/10498.feature
+++ b/changelog.d/10498.feature
@ -1 +0,0 @@
-Add support for "marker" events which makes historical events discoverable for servers that already have all of the scrollback history (part of MSC2716).
--- a/changelog.d/10504.misc
+++ b/changelog.d/10504.misc
@ -1 +0,0 @@
-Reduce errors in PostgreSQL logs due to concurrent serialization errors.
--- a/changelog.d/10507.misc
+++ b/changelog.d/10507.misc
@ -1 +0,0 @@
-Include room ID in ignored EDU log messages. Contributed by @ilmari.
--- a/changelog.d/10513.feature
+++ b/changelog.d/10513.feature
@ -1 +0,0 @@
-Add a configuration setting for the time a `/sync` response is cached for.
--- a/changelog.d/10518.feature
+++ b/changelog.d/10518.feature
@ -1 +0,0 @@
-The default logging handler for new installations is now `PeriodicallyFlushingMemoryHandler`, a buffered logging handler which periodically flushes itself.
--- a/changelog.d/10527.misc
+++ b/changelog.d/10527.misc
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10529.misc
+++ b/changelog.d/10529.misc
@ -1 +0,0 @@
-Fix CI to not break when run against branches rather than pull requests.
--- a/changelog.d/10530.misc
+++ b/changelog.d/10530.misc
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10532.bugfix
+++ b/changelog.d/10532.bugfix
@ -1 +0,0 @@
-Fix a long-standing bug where protocols which are not implemented by any appservices were incorrectly returned via `GET /_matrix/client/r0/thirdparty/protocols`.
--- a/changelog.d/10537.misc
+++ b/changelog.d/10537.misc
@ -1 +0,0 @@
-Mark all events stemming from the MSC2716 `/batch_send` endpoint as historical.
--- a/changelog.d/10538.feature
+++ b/changelog.d/10538.feature
@ -1 +0,0 @@
-Add support for new redaction rules for historical events specified in [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716).
--- a/changelog.d/10539.misc
+++ b/changelog.d/10539.misc
@ -1 +0,0 @@
-Clean up some of the federation event authentication code for clarity.
--- a/changelog.d/10541.bugfix
+++ b/changelog.d/10541.bugfix
@ -1 +0,0 @@
-Fix exceptions in logs when failing to get remote room list.
--- a/changelog.d/10542.misc
+++ b/changelog.d/10542.misc
@ -1 +0,0 @@
-Convert `Transaction` and `Edu` objects to attrs.
--- a/changelog.d/10546.feature
+++ b/changelog.d/10546.feature
@ -1 +0,0 @@
-Add a setting to disable TLS when sending email.
--- a/changelog.d/10549.feature
+++ b/changelog.d/10549.feature
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10550.bugfix
+++ b/changelog.d/10550.bugfix
@ -1 +0,0 @@
-Fix longstanding bug which caused the user "status" to be reset when the user went offline. Contributed by @dklimpel.
--- a/changelog.d/10551.doc
+++ b/changelog.d/10551.doc
@ -1 +0,0 @@
-Updated the reverse proxy documentation to highlight the homserver configuration that is needed to make Synapse aware that is is intentionally reverse proxied.
--- a/changelog.d/10552.misc
+++ b/changelog.d/10552.misc
@ -1 +0,0 @@
-Update `/batch_send` endpoint to only return `state_events` created by the `state_events_from_before` passed in.
--- a/changelog.d/10558.feature
+++ b/changelog.d/10558.feature
@ -1 +0,0 @@
-Admin API to delete several media for a specific user. Contributed by @dklimpel.
--- a/changelog.d/10560.feature
+++ b/changelog.d/10560.feature
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10563.misc
+++ b/changelog.d/10563.misc
@ -1 +0,0 @@
-Update contributing.md to warn against rebasing an open PR.
--- a/changelog.d/10564.feature
+++ b/changelog.d/10564.feature
@ -1 +0,0 @@
-Add support for routing `/createRoom` to workers.
--- a/changelog.d/10565.misc
+++ b/changelog.d/10565.misc
@ -1 +0,0 @@
-Remove the unused public rooms replication stream.
--- a/changelog.d/10569.feature
+++ b/changelog.d/10569.feature
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10570.feature
+++ b/changelog.d/10570.feature
@ -1 +0,0 @@
-Update the Synapse Grafana dashboard.
--- a/changelog.d/10572.misc
+++ b/changelog.d/10572.misc
@ -1 +0,0 @@
-Clarify error message when failing to join a restricted room.
--- a/changelog.d/10573.misc
+++ b/changelog.d/10573.misc
@ -1 +0,0 @@
-Remove references to BuildKite in favour of GitHub Actions.
--- a/changelog.d/10574.feature
+++ b/changelog.d/10574.feature
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10575.feature
+++ b/changelog.d/10575.feature
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10576.misc
+++ b/changelog.d/10576.misc
@ -1 +0,0 @@
-Move `/batch_send` endpoint defined by [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) to the `/v2_alpha` directory.
--- a/changelog.d/10578.feature
+++ b/changelog.d/10578.feature
@ -1 +0,0 @@
-Add an admin API (`GET /_synapse/admin/username_available`) to check if a username is available (regardless of registration settings).
--- a/changelog.d/10579.feature
+++ b/changelog.d/10579.feature
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10580.bugfix
+++ b/changelog.d/10580.bugfix
@ -1 +0,0 @@
-Allow public rooms to be previewed in the spaces summary APIs from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10583.feature
+++ b/changelog.d/10583.feature
@ -1 +0,0 @@
-Add pagination to the spaces summary based on updates to [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946).
--- a/changelog.d/10587.misc
+++ b/changelog.d/10587.misc
@ -1 +0,0 @@
-Allow multiple custom directories in `read_templates`.
--- a/changelog.d/10588.removal
+++ b/changelog.d/10588.removal
@ -1 +0,0 @@
-No longer build `.dev` packages for Ubuntu 20.10 LTS Groovy Gorilla, which has now EOLed.
--- a/changelog.d/10590.misc
+++ b/changelog.d/10590.misc
@ -1 +0,0 @@
-Re-organize the `synapse.federation.transport.server` module to create smaller files.
--- a/changelog.d/10591.misc
+++ b/changelog.d/10591.misc
@ -1 +0,0 @@
-Clean up some of the federation event authentication code for clarity.
--- a/changelog.d/10592.bugfix
+++ b/changelog.d/10592.bugfix
@ -1 +0,0 @@
-Fix a bug introduced in v1.37.1 where an error could occur in the asyncronous processing of PDUs when the queue was empty.
--- a/changelog.d/10596.removal
+++ b/changelog.d/10596.removal
@ -1 +0,0 @@
-The `template_dir` configuration settings in the `sso`, `account_validity` and `email` sections of the configuration file are now deprecated in favour of the global `templates.custom_template_directory` setting. See the [upgrade notes](https://matrix-org.github.io/synapse/latest/upgrade.html) for more information.
--- a/changelog.d/10598.feature
+++ b/changelog.d/10598.feature
@ -1 +0,0 @@
-Allow editing a user's `external_ids` via the "Edit User" admin API. Contributed by @dklimpel.
--- a/changelog.d/10599.doc
+++ b/changelog.d/10599.doc
@ -1 +0,0 @@
-Update CONTRIBUTING.md to fix index links and the instructions for SyTest in docker.
--- a/changelog.d/10600.misc
+++ b/changelog.d/10600.misc
@ -1 +0,0 @@
-Flatten the `synapse.rest.client` package by moving the contents of `v1` and `v2_alpha` into the parent.
--- a/changelog.d/10602.feature
+++ b/changelog.d/10602.feature
@ -1 +0,0 @@
-The Synapse manhole no longer needs coroutines to be wrapped in `defer.ensureDeferred`.
--- a/changelog.d/10606.bugfix
+++ b/changelog.d/10606.bugfix
@ -1 +0,0 @@
-Fix errors on /sync when read receipt data is a string. Only affects homeservers with the experimental flag for [MSC2285](https://github.com/matrix-org/matrix-doc/pull/2285) enabled. Contributed by @SimonBrandner.
--- a/changelog.d/10611.bugfix
+++ b/changelog.d/10611.bugfix
@ -1 +0,0 @@
-Additional validation for the spaces summary API to avoid errors like `ValueError: Stop argument for islice() must be None or an integer`. The missing validation has existed since v1.31.0.
--- a/changelog.d/10612.misc
+++ b/changelog.d/10612.misc
@ -1 +0,0 @@
-Build Debian packages for Debian 12 (Bookworm).
--- a/changelog.d/10620.misc
+++ b/changelog.d/10620.misc
@ -1 +0,0 @@
-Fix up a couple of links to the database schema documentation.
--- a/changelog.d/10623.bugfix
+++ b/changelog.d/10623.bugfix
@ -1 +0,0 @@
-Revert behaviour introduced in v1.38.0 that strips `org.matrix.msc2732.device_unused_fallback_key_types` from `/sync` when its value is empty. This field should instead always be present according to [MSC2732](https://github.com/matrix-org/matrix-doc/blob/master/proposals/2732-olm-fallback-keys.md).
--- a/changelog.d/10628.feature
+++ b/changelog.d/10628.feature
@ -1 +0,0 @@
-Admin API to delete several media for a specific user. Contributed by @dklimpel.
--- a/changelog.d/10631.misc
+++ b/changelog.d/10631.misc
@ -1 +0,0 @@
-Fix a broken link to the upgrade notes.
--- a/changelog.d/10638.feature
+++ b/changelog.d/10638.feature
@ -1 +0,0 @@
-Add option to allow modules to run periodic tasks on all instances, rather than just the one configured to run background tasks.
--- a/changelog.d/9581.feature
+++ b/changelog.d/9581.feature
@ -1 +0,0 @@
-Add `get_userinfo_by_id` method to ModuleApi.
--- a/debian/changelog
+++ b/debian/changelog
@ -1,3 +1,9 @@
+matrix-synapse-py3 (1.41.0~rc1) stable; urgency=medium
+
+  * New synapse release 1.41.0~rc1.
+
+ -- Synapse Packaging team <packages@matrix.org>  Wed, 18 Aug 2021 15:52:00 +0100
+
 matrix-synapse-py3 (1.40.0) stable; urgency=medium

  * New synapse release 1.40.0.
--- a/synapse/init.py
+++ b/synapse/init.py
@ -47,7 +47,7 @@ try:
 except ImportError:
    pass

-__version__ = "1.40.0"
+__version__ = "1.41.0rc1"

 if bool(os.environ.get("SYNAPSE_TEST_PATCH_LOG_CONTEXTS", False)):
    # We import here so that we don't have to install a bunch of deps when
				`@ -1 +0,0 @@`
				`Improve event caching mechanism to avoid having multiple copies of an event in memory at a time.`
				`@ -1 +0,0 @@`
				`Add some clarification to the sample config file. Contributed by @Kentokamoto.`
				`@ -1 +0,0 @@`
				Initial local support for [MSC3266](https://github.com/matrix-org/synapse/pull/10394), Room Summary over the unstable `/rooms/{roomIdOrAlias}/summary` API.
				`@ -1 +0,0 @@`
				Experimental support for [MSC3288](https://github.com/matrix-org/matrix-doc/pull/3288), sending `room_type` to the identity server for 3pid invites over the `/store-invite` API.
				`@ -1 +0,0 @@`
				`Add documentation for configuration a forward proxy.`
				`@ -1 +0,0 @@`
				`Add support for sending federation requests through a proxy. Contributed by @Bubu and @dklimpel.`
				`@ -1 +0,0 @@`
				`Add support for "marker" events which makes historical events discoverable for servers that already have all of the scrollback history (part of MSC2716).`
				`@ -1 +0,0 @@`
				`Reduce errors in PostgreSQL logs due to concurrent serialization errors.`
				`@ -1 +0,0 @@`
				`Include room ID in ignored EDU log messages. Contributed by @ilmari.`
				`@ -1 +0,0 @@`
				Add a configuration setting for the time a `/sync` response is cached for.