Config values are almost never 'None', but they might be empty string. Detect their presence by truth

2014-09-23 15:18:59 +01:00 · 2014-09-23 15:18:59 +01:00 · 537c7e1137
parent 5f16439752
commit 537c7e1137
1 changed files with 1 additions and 1 deletions
--- a/synapse/rest/register.py
+++ b/synapse/rest/register.py
@ -153,7 +153,7 @@ class RegisterRestServlet(RestServlet):
    @defer.inlineCallbacks
    def _check_recaptcha(self, request, register_json):
        if "captcha_bypass_secret" in register_json:
-            if (self.hs.config.captcha_bypass_secret is not None and
+            if (self.hs.config.captcha_bypass_secret and
                    register_json["captcha_bypass_secret"] ==
                        self.hs.config.captcha_bypass_secret):
                defer.returnValue(None)