From 55eccdc094fe99c1619d046693c401cb5896f92c Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Mon, 6 Apr 2020 18:20:13 +0100 Subject: [PATCH] Address review comments --- synapse/replication/tcp/handler.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/synapse/replication/tcp/handler.py b/synapse/replication/tcp/handler.py index b415beb0fe..31584a971c 100644 --- a/synapse/replication/tcp/handler.py +++ b/synapse/replication/tcp/handler.py @@ -104,7 +104,7 @@ class ReplicationCommandHandler: # Let's drop the row for now, on the assumption we'll receive a # `POSITION` soon and we'll catch up correctly then. logger.warning( - "Discarding RDATA for unconnected stream %s -> ", + "Discarding RDATA for unconnected stream %s -> %s", stream_name, cmd.token, ) @@ -146,8 +146,8 @@ class ReplicationCommandHandler: # of connected streams. self._streams_connected.discard(cmd.stream_name) - # We clear the pending batches for the stream as the fetching - # updates below will fetch all rows in the batch. + # We clear the pending batches for the stream as the fetching of the + # missing updates below will fetch all rows in the batch. self._pending_batches.pop(cmd.stream_name, []) # Find where we previously streamed up to.