Allow unused ignores in "bleeding edge" CI (#12576)

* Allow unused ignores in "bleeding edge" CI

Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs.

Follow up from #12531.
Resolves #12574.

* Use `--extras all` in latest deps mypy CI

Twisted trunk job already does this.

Missed in #12531.

* changelog
pull/12596/head
David Robertson 2022-04-29 17:57:23 +01:00 committed by GitHub
parent 3ae56d125c
commit 57fac2a234
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 0 deletions

View File

@ -32,12 +32,15 @@ jobs:
with: with:
python-version: "3.x" python-version: "3.x"
poetry-version: "1.2.0b1" poetry-version: "1.2.0b1"
extras: "all"
# Dump installed versions for debugging. # Dump installed versions for debugging.
- run: poetry run pip list > before.txt - run: poetry run pip list > before.txt
# Upgrade all runtime dependencies only. This is intended to mimic a fresh # Upgrade all runtime dependencies only. This is intended to mimic a fresh
# `pip install matrix-synapse[all]` as closely as possible. # `pip install matrix-synapse[all]` as closely as possible.
- run: poetry update --no-dev - run: poetry update --no-dev
- run: poetry run pip list > after.txt && (diff -u before.txt after.txt || true) - run: poetry run pip list > after.txt && (diff -u before.txt after.txt || true)
- name: Remove warn_unused_ignores from mypy config
run: sed '/warn_unused_ignores = True/d' -i mypy.ini
- run: poetry run mypy - run: poetry run mypy
trial: trial:
runs-on: ubuntu-latest runs-on: ubuntu-latest

View File

@ -24,6 +24,8 @@ jobs:
poetry remove twisted poetry remove twisted
poetry add --extras tls git+https://github.com/twisted/twisted.git#trunk poetry add --extras tls git+https://github.com/twisted/twisted.git#trunk
poetry install --no-interaction --extras "all test" poetry install --no-interaction --extras "all test"
- name: Remove warn_unused_ignores from mypy config
run: sed '/warn_unused_ignores = True/d' -i mypy.ini
- run: poetry run mypy - run: poetry run mypy
trial: trial:

1
changelog.d/12576.misc Normal file
View File

@ -0,0 +1 @@
Allow unused `#type: ignore` comments in bleeding edge CI jobs.